CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-07-05 23:57:53 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge PR #1311: clear refs when iframe auto-detaches in getActiveFrameOrPage

Browse Source
This commit is contained in:
Garry Tan
2026-05-08 21:39:14 -07:00
parent c7438e06b6 369c7f230f
commit 9f5c91349f
2 changed files with 162 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browse/src/tab-session.ts
+8 -1
View File
@@ -149,9 +149,16 @@ export class TabSession {
* Use this for operations that work on both Page and Frame (locator, evaluate, etc.).
*/
getActiveFrameOrPage(): Page | Frame {
// Auto-recover from detached frames (iframe removed/navigated)
// Auto-recover from detached frames (iframe removed/navigated). Clear
// refs alongside the activeFrame — same staleness condition as
// onMainFrameNavigated() below: refs were captured against a frame
// that no longer exists. Without this, refMap entries linger against
// a dead frame after silently falling back to the main page; the
// next snapshot's role+name keys collide with stale entries and the
// resolver picks one at random.
if (this.activeFrame?.isDetached()) {
this.activeFrame = null;
this.clearRefs();
}
return this.activeFrame ?? this.page;
}