v1.86.0.0 feat: route outside reviews by harness (#2850)

* feat: add a restricted and supervised Claude Code runner

Preserve configured authentication and models while enforcing tool access, strict completion JSON, bounded output and process cleanup. Cover argv, failure handling, session metadata and Windows process containment.

* feat: route outside reviews by harness and migrate wrapper installs

Use Claude Code from Codex and Codex from other supported hosts, with shared invocation rendering, positive gate validation and per-phase provenance. Rename /claude to /claude-code, repair managed shared and copied installations safely, and generate native Kiro skills. Add installed-workflow, failure-injection and live cross-harness regression coverage.

* test: recognize CEO mode labels without terminal spacing

The paid workflow rendered SCOPEEXPANSION at option 4, but its driver required a literal space. Match the leading mode title without cursor-spacing artifacts and ignore adjacent preview text. Preserve missing-target failures and downstream posture assertions.

* test: isolate plan-count fixtures before starting review workflows

Seed the complete test plan in a private git repository before launching Claude, so a bare slash command cannot review the live workspace while a delayed fixture message remains queued. Preserve count thresholds, parsers and budgets. Add initial-context and installed-discovery tests, and retain startup/terminal diagnostics on failed evaluations.

* test: stabilize review fixtures and Claude eval startup

Preserve source boundaries in workflow judge inputs, isolate CEO mode plans, and wait for interactive trust input readiness. Keep startup failure evidence and retain existing models, budgets, and assertions.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: classify collapsed review modes and isolate seeded findings

Keep review questions out of the setup count when terminal cursor positioning removes spaces. State existing webhook safeguards so the five-finding control measures its seeded defects without accidental extra security and concurrency gaps. Preserve question bands and the paired control.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: isolate browser daemon state across free shards

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: stabilize native review counting and interactive navigation

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* chore: prepare v1.82.0.0 release

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* fix: eliminate browser and process-cleanup test flakes

Pin every CI surface to Bun 1.4.0 to avoid extra-stdio finalizers closing
reused live sockets. Add an isolated GC/listener regression that fails on
Bun 1.3.13, and prevent coordinated rollback to an affected CI runtime.

Check renderer cleanup against the render's own staging directory so
concurrent renders cannot invalidate the assertion. Make the no-pgrep
process-tree walk tolerate disappearing /proc entries, and synchronize
its test fixture through child readiness and pipe EOF instead of sleeps.

Validation: 9,157 passed, 31 skipped, zero failures across 556 files with
retries disabled. Build, all-host generation freshness, and skill checks
passed. All three races have failing-before/passing-after regressions.

* fix: count completed native review questions in evals

* fix: drive review navigation from confirmed native choices

* fix: require complete section-loading eval reports

* test: isolate telemetry HTTP transport from local assertions

* fix: keep review input on the active native question

* test: let tunnel revocation daemon choose an available port

* test: allocate available ports for pairing and watchdog fixtures

* fix: stabilize planning eval navigation and phase reporting

* test: isolate installed runtime paths in planning evals

* test: stabilize review evidence and concurrent refresh fixtures

* fix: resolve design findings before editing the plan

* fix: honor and persist disabled outside plan reviews

* fix: preserve planning decisions and terminal evidence

Load installed host reviews at autoplan phase entry and wait for completed
reviewers and saved artifacts. Reuse approved remedies while preserving
individual finding decisions.

Drive interactive evals from the current terminal viewport, bind native
questions across scrolling, and require complete native report evidence.
Cover captured stale menus, permission lifecycles, setup classification,
and disabled-review tool availability with deterministic regressions.

Advance release metadata and the upgrade migration to the unclaimed
1.83.0.0 slot.

* fix: drive native review questions and preserve current plans

Use the native single-choice keyboard protocol and current terminal viewport,
with per-question navigation inside packets and completed-call coverage.
Keep permissions, multi-select menus, and Submit controls distinct.

Send Autoplan reviewers the amended implementation plan, keep its review record
separate, and supply retained application contracts in the chain fixture.
Clarify individual DevEx decisions and complete CEO fix options; use one active
plan destination for the section-loading report.

* fix: preserve complete plan-review decisions

* fix: recognize native plan dialogs and reviewer controls

* fix: preserve review decisions and phase completion

* fix: recognize completed reviews without losing findings

* fix: preserve review continuity and native eval completion

* test: fix native review completion and eval retry isolation

* test: handle native review menus and complete eval fixtures

* test: fix native review setup, completion, and isolation failures

* test: limit native skill discovery to runtime assets

* fix: bind Autoplan reviews to full ordered phase inputs

* test: fix planning eval routing, counting, and timeout handling

* chore: advance queued release to v1.84.0.0

* fix: preserve complete review inputs and planning decisions

* fix: reconcile review approvals and preserve phase obligations

* fix: preserve review obligations and unblock eval permissions

Carry recorded Autoplan requirements into blind phase inputs, require Eng
review approvals before exit, and exercise combined asynchronous flows in
CEO reviews. Correct native finding and handoff classification and unblock
repeated report edits using scoped request identities.

* fix: retain plan requirements and complete native review dialogs

* fix: complete native review prompts and retain plan references

* fix: preserve review inputs and classify native eval evidence

* fix: check competing completion orders in CEO reviews

* fix: recognize review decisions and require phase methodology

Require the current phase methodology before Autoplan snapshots. Correct
substantive decision, closed handoff, and cache-finding classification, and
honor the recommended implementation approach in native review dialogs.

Add captured-transcript regressions without changing review thresholds,
provider models, retries, or deadlines.

* test: bind native review decisions and close completed handoffs

* fix: complete review dialogs and verify methodology delivery

* fix: preserve review evidence and unblock native eval prompts

* fix: handle native review question completions

* fix: recognize native review narration and controls

* fix: count native review decisions and isolate eval fixtures

* test: verify seeded review coverage and current artifact permissions

* test: isolate model and brain-aware skill renders

* fix: repair native workflow evaluation and clarify review steps

* fix: stabilize workflow eval evidence and review guidance

* test: repair native workflow observation and fixture isolation

* fix: recognize completed workflow evidence and owned skill reads

* test: repair seeded workflow delivery and completion evidence

* test: recognize current review evidence across native forms

* test: handle native review variants and permission redraws

* fix: honor review preferences and recognize native eval evidence

* test: recognize completed review decisions and queued permissions

* test: match current review contracts and partial-line edits

* test: recognize completed workflow evidence and bounded human waits

* fix: preserve review entry gates and native eval interactions

* fix: recognize native workflow evidence and preserve review gates

* test: recognize current review evidence and preconfigure workflow fixtures

* test: recognize completed review findings and scoped artifact permissions

* fix: stabilize native workflow review and permission evidence

* fix: recognize current review evidence and scoped edit confirmations

Clarify Design and engineering review entry instructions and Design scoring.
Recognize required legacy coverage and public Autoplan completion recaps.
Bind the pending Edit confirmation to its exact file, ordered digest, and
one-request approval when a preceding command display remains visible.
Keep reviews within their existing size limits and preserve scope gates
when extracting workflow fixtures from either supported preamble header.

Keep failure outcomes, review thresholds, provider choices, and eval budgets.

* fix: recover review workflow progress and eval evidence

* fix: recognize valid review evidence and scope selection

* test: fix review evidence parsing and repeated artifact prompts

* test: recognize valid review decisions and pending native cards

* fix(plan-eng-review): keep final navigation consistent with approved tasks

* test: recognize valid review evidence and bind legacy diff requests

* fix: stabilize review eval evidence and harness repair guidance

* docs: update project documentation for v1.85.0.0

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* test: fix Windows CI fixtures and credential scan

Rebase captured JSON values and filesystem evidence using the appropriate
path convention. Compile native fake CLIs on Windows and synchronize pipe
holder readiness, with cleanup retained when assertions fail.

Assemble synthetic credential fixtures at runtime so the added-line scan
keeps enforcing the same gate without flagging its own rejection controls.

Discover generated skills directly for the empty-find regression check,
avoiding a recursive scan through saved evaluation artifacts and dependencies.

* fix: preserve source renders on Windows

Compare canonical generator paths using native separators so an output
sidecar pointing at the source cannot overwrite its skill or metadata.
Keep the regression fixture isolated from the real checkout and expose
freshness diagnostics before asserting subprocess status.

Detach Windows drain-test pipe holders from the fake provider's automatic
child cleanup while preserving the enclosing runner job and its assertions.

* fix: clarify outside review fallback and CEO decisions

Render one applicable own-harness fallback path and retain native review,
disabled policy, and missing-coverage semantics. Align report field names
and mode labels, and make the existing per-cut scope approval explicit.

Regenerate skill outputs and keep the workflow judge's model, thresholds,
and retry policy unchanged.

* chore: move release to free version slot (v1.86.0.0)

PR #2852 now claims v1.85.0.0. Align the release metadata and
rename migration so upgrades from that version still receive it.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

* fix: include engineering review prerequisites and restore branch context

* fix: recognize coverage diagrams and clarify design review instructions

* fix: preserve file identities and join Windows test processes

---------

Co-authored-by: OpenAI Codex <noreply@openai.com>

docs/ADDING_A_HOST.md

@@ -64,7 +64,7 @@ That expands to the full `HostConfig` with these defaults:
 - `globalRoot` / `localSkillRoot`: `.myhost/skills/gstack`, `hostSubdir`: `.myhost`
 - `usesEnvVars: true` (false only for Claude, which uses literal `~` paths)
 - `frontmatter`: allowlist keeping `name` + `description`, no description limit
-- `generation`: no metadata file, `skipSkills: ['codex']` (codex skill is Claude-only)
+- `generation`: no metadata file, `skipSkills: []` (both outside-review skills are enabled; Claude and Codex explicitly omit their own wrapper)
 - `pathRewrites`: the standard trio derived from the resolved paths
   (`~/.claude/skills/gstack` → `~/{globalRoot}`, `.claude/skills/gstack` →
   `{localSkillRoot}`, `.claude/skills` → `{hostSubdir}/skills`)
@@ -86,8 +86,9 @@ Override any field by passing it to `defineHost()`. Two path-rewrite options:
 The two are mutually exclusive (the factory throws if you pass both).
 
 Shared constants exported from `define-host.ts` for spread-composition:
-`CROSS_MODEL_RESOLVERS` (the five Codex-invoking resolvers suppressed on
-hosts that can't invoke other models), `GBRAIN_RESOLVERS` (the default
+`CROSS_MODEL_RESOLVERS` (outside-provider review resolvers plus Review Army,
+suppressed on hosts that opt out; Codex keeps outside reviews and suppresses
+Review Army), `GBRAIN_RESOLVERS` (the default
 suppression pair), and `EXEC_STYLE_TOOL_REWRITES` (the OpenClaw-style
 lowercase-tool rewrites shared by openclaw and gbrain).
 
@@ -142,7 +143,7 @@ bun test test/host-config.test.ts
 
 The parameterized smoke tests automatically pick up the new host. Zero test
 code to write. They verify: output exists, no path leakage, valid frontmatter,
-freshness check passes, codex skill excluded.
+freshness check passes, and outside-review skills match each host's exclusions.
 
 ### 6. Update README.md
 

docs/TESTING_INTERNALS.md

@@ -36,6 +36,28 @@ two gate-tier canaries in `test/skill-e2e-hermetic-canary.test.ts`, and the
 seeding tripwires in `test/hermetic-skills-seeding.test.ts` /
 `test/pty-skill-seeding-wiring.test.ts`.
 
+Seeded planning sessions also receive an isolated runtime home through
+`test/helpers/hermetic-skill-runtime.ts`, so absolute lazy-section paths resolve
+to the working tree under test. Explicit per-test home overrides remain intact.
+Autoplan resolves each review skill from its own installed host registry.
+
+**Interactive planning evidence.** Finding-count and autoplan-chain drivers use
+`observeScreen: true` and await `currentScreen()` before choosing an input. The
+existing xterm dependency interprets cursor moves and erases; old menus in the
+raw stream cannot establish a current prompt. Snapshots preserve
+`terminal.raw.log`, `terminal.visible.log`, and `terminal.screen.log` separately.
+Completed native transcript calls establish question counts and phase coverage.
+Report-aware count tests also require a fresh, complete report and native
+completion evidence before accepting a completion heading.
+
+The engineering and DX finding fixtures check coverage of their seeded issues
+rather than cap the total number of review questions. Each decision needs a
+distinct, completed native question with an offered answer; accepting, rejecting,
+or deferring a recommendation all count as reviewing it. Engineering's mandatory
+legacy regression tests also need affirmative plan or public-narration evidence.
+Additional useful questions are allowed within the existing time limits. Generic
+question counts remain diagnostic, and a fresh final review report is required.
+
 E2E tests stream progress in real-time (tool-by-tool via `--output-format stream-json
 --verbose`). Results are persisted to `~/.gstack/projects/<slug>/evals/` (legacy
 fallback `~/.gstack-dev/evals/`) with auto-comparison
@@ -159,6 +181,43 @@ archaeology.
 `test/helpers/eval-budgets.ts` (JUDGE/CAPTURE/CAPTURE_LONG/PTY/PTY_LONG);
 `test/eval-budgets-policy.test.ts` pins that every tier fits the shard wall
 minus overhead and ratchets raw literals. Budget above the wall is fiction.
+The sole registered exception is `AUTOPLAN_CHAIN_BUDGET` for
+`test/skill-e2e-autoplan-chain.test.ts`: 80 minutes of work (four `PTY_LONG`
+allocations), an 84-minute session watchdog, an 85-minute Bun test deadline,
+and a 172-minute supervised shard wall. The unchanged retry count of one
+permits two 85-minute attempts plus two minutes for cleanup. This is a
+**specified allocation for the stronger four-phase contract**, not a measured
+calibration or statistical upper bound. The historical 900-second failures
+remain failures. Models, fixtures, phase assertions and production review
+caller timeouts are unchanged; this explicitly changes eval latency/cost policy.
+
+The Autoplan chain explicitly enables native `PreToolUse` approval for edits to
+its owned temporary review artifacts. Approval starts with the `/autoplan`
+command and requires the exact parent session, prior successful file history,
+and a current request digest. Other recorder callers remain observational.
+A rejected artifact edit fails the test instead of falling through to terminal
+permission input. Approval itself supplies no edit success or phase credit:
+the native tool result and all four completed review phases are still required.
+
+`resolvePaidShardBudget(files, overrideMs?)` is the canonical per-job resolver.
+Only the exact Autoplan file gets the exception, in its own shard. An explicit
+CLI `--timeout`, `EVALS_SHARD_TIMEOUT_MS`, or API `timeoutMs` still wins, including
+a lower cap. Planner entries and execution results record the effective wall,
+its source and policy identifier. Custom drivers must resolve each job instead
+of passing their ordinary 1800-second default as an explicit Autoplan cap;
+their outer controller/detach wall must also cover the allocated work and cleanup.
+`eval:bg:periodic` already has a 37800-second outer cap. Legacy monolithic
+`eval:bg`/`eval:bg:all` retain their shorter 5400/7200-second caps and do not
+promise two complete Autoplan attempts; use the sharded periodic path for this policy.
+
+Periodic CI plans `--slices 7 --autoplan-slice`: six ordinary slices retain their
+existing limits, while the seventh runs only Autoplan. Its unchanged 200-minute
+job cap leaves 28 minutes around the 172-minute shard for setup and artifacts.
+Reconciliation rejects missing, duplicated or misplaced Autoplan work and absent
+budget records. This does not claim that the growing ordinary census has a
+200-minute worst-case bound. Ordinary paid tiers and their 1800-second shard
+wall remain unchanged; unregistered over-ceiling tests still fail policy checks.
+
 Session timeouts are two-phase: a silent API dies at the startup grace (90s
 local / 300s CI floor, distinct exit reason `timeout_startup`) and the work
 budget arms on the first byte — the total wall never grows

docs/skills.md

@@ -42,7 +42,8 @@ Detailed guides for every gstack skill — philosophy, workflow, and examples.
 | [`/benchmark-models`](#benchmark-models) | **Model Benchmark** | Side-by-side cross-model benchmark for skills (Claude vs GPT vs Gemini). Latency, tokens, cost, optional LLM-judged quality. |
 | | | |
 | **Multi-AI** | | |
-| [`/codex`](#codex) | **Second Opinion** | Independent review from OpenAI Codex CLI. Three modes: code review (pass/fail gate), adversarial challenge, and open consultation with session continuity. Cross-model analysis when both `/review` and `/codex` have run. |
+| [`/codex`](#codex) | **Second Opinion** | OpenAI Codex review, challenge, and consultation. Available outside the Codex harness. |
+| [`/claude-code`](#claude-code) | **Second Opinion** | Claude Code review, challenge, and consultation. Available outside the Claude Code harness; used for automatic outside reviews in Codex. |
 | [`/pair-agent`](#browse) | **Remote Agent Bridge** | Pair a remote AI agent (OpenClaw, Codex, Cursor, Hermes) with gstack's own browser. Scoped tunnel, locked allowlist, session token. Fallback-browser skill; agents driving Aside open their own tabs. |
 | [`/setup-gbrain`](#setup-gbrain) | **Memory Sync** | Set up gbrain for cross-machine session memory sync. One command from zero to live. |
 | [`/sync-gbrain`](#sync-gbrain) | **Keep Brain Current** | Refresh gbrain against this repo's code; teach the agent when to use `gbrain search`/`code-def` over Grep. Idempotent; safe to re-run. |
@@ -1053,7 +1054,7 @@ Claude: Detected: Fly.io (fly.toml found)
 
 This is my **second opinion mode**.
 
-When `/review` catches bugs from Claude's perspective, `/codex` brings a completely different AI — OpenAI's Codex CLI — to review the same diff. Different training, different blind spots, different strengths. The overlap tells you what's definitely real. The unique findings from each are where you find the bugs neither would catch alone.
+`/codex` brings OpenAI Codex CLI to review the same diff independently. It is available on every harness except Codex itself. External harnesses install it as `/gstack-codex`. Compare its findings with the native review to distinguish corroborated findings from issues only one reviewer caught.
 
 gstack-owned Codex calls default to `gpt-6-astra`, including resumed consult
 sessions. Set `GSTACK_CODEX_MODEL=<model>` to change the default, or name a
@@ -1062,11 +1063,11 @@ pass the selection through `-c model=...`, overriding the CLI's configured model
 Native review also sets `-c review_model=...` to that selection, overriding any
 separate review-model pin.
 
-On Codex hosts, the Claude outside-voice skill is `gstack-claude`. Its review,
-challenge, and consult calls, including resumed sessions, use
-`--model "${GSTACK_CLAUDE_MODEL:-claude-fable-5-1}"`; a model named in your
-request takes precedence. Both defaults are known frontier pins maintained
-in gstack releases, with no automatic model discovery.
+On Codex hosts, the Claude outside-voice skill is `gstack-claude-code`. Its
+review, challenge, and consult calls preserve Claude's configured model.
+`GSTACK_CLAUDE_MODEL=<model>` supplies an explicit override, including resumed
+sessions; a model named in your request takes precedence. Harness routing is
+independent of model selection.
 
 ### Three modes
 
@@ -1099,6 +1100,18 @@ Claude: Running independent Codex review...
 
 ---
 
+## `/claude-code`
+
+Claude Code provides the outside reviewer when gstack runs in Codex. Other non-Claude harnesses also expose this skill for explicit requests; Claude Code itself omits it. External harnesses install it as `/gstack-claude-code`.
+
+**Review** supplies the branch diff for a read-only pass/fail review. **Challenge** asks Claude Code to find concrete failure cases in the same diff. **Consult** supports read-only repository exploration and resumes the session saved in `.context/claude-session-id`. Review and challenge receive context from the parent workflow and run without tools; consultation can read and search files.
+
+The Claude Code CLI must be installed and authenticated. Its existing model configuration and `GSTACK_CLAUDE_BIN` / `GSTACK_CLAUDE_BIN_ARGS` executable overrides are honored. Errors, timeouts, and invalid responses report missing outside coverage instead of a clean review. Automatic reviews start fresh; consult session continuity is explicit.
+
+Outside-review routing follows the harness, independently of the configured model. Generic second-opinion requests choose `/claude-code` on Codex and `/codex` elsewhere; explicit provider requests keep that provider. The existing `codex_reviews` setting controls the selected automatic reviewer in workflows that already use that setting. Existing opt-in and skip controls still apply in office hours, design, and spec workflows.
+
+`/claude` was renamed to `/claude-code` without an alias. Run `./setup --host <name>` to migrate managed installations, including installations sharing that checkout. Setup retains a working old installation when replacement generation or installation fails.
+
 ## Safety & Guardrails
 
 Four skills that add safety rails to any Claude Code session. They work via Claude Code's PreToolUse hooks — transparent, session-scoped, no configuration required.