mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-04 18:36:54 +02:00
fix(evals): repair proof-run reds in design-consultation, document-release, design and QA fixtures
- design-consultation Phase 1 asks one brief that confirms context and decides
research; the confirm-only first question scored substance 2.
- document-release defines ship-owned inputs, exact steps and the JSON result,
and drops stale spawned-from-/ship text (judge actionability 3.67 -> 4/4/4).
- plan-design-with-ui accepts the Step 0D focus menu the same way the shared
picker does ("focus on specific ones?").
- plan-design-review plan-mode saves in three Edits instead of one final Write.
- QA functional annotations ask for the full 40-character revision.
- Outside-disabled attribution judges quoted prior-record data by its exact
timestamp or a dated, pre-existing-record sentence; four captured phrasings
replay clean and current claims still fail.
- --case can select autoplan-dual-voice by its literal test name.
This commit is contained in:
1 parent
aba80c8fb6
commit
a111225e78
17 files changed
+180
-92
No files matched your search
@@ -38,7 +38,7 @@ Make factual updates directly; ask about risky or subjective decisions in standa
|
||||
|
||||
## Ship-owned documentation mode
|
||||
|
||||
With a ship candidate, require the actual spawned marker and audit-scope rules below.
|
||||
With a ship candidate, follow audit-scope's inputs, steps and JSON result below.
|
||||
Missing marking/inputs/assets returns `blocked`, never standalone execution. Ship
|
||||
authority overrides generic spawned recommendations and standalone steps.
|
||||
|
||||
@@ -50,8 +50,8 @@ authority overrides generic spawned recommendations and standalone steps.
|
||||
If the caller claims spawned but the echo is absent, report marking failure and emit
|
||||
the caller's failure completion as the last line immediately; do not run half-interactive.
|
||||
Otherwise stay interactive without the marker. Outside ship-owned mode, spawned gates
|
||||
auto-choose the RECOMMENDED option, record it in the completion report, and continue:
|
||||
never call AskUserQuestion or stop for a prose answer. The NEVER-do invariants below do
|
||||
auto-choose the RECOMMENDED option, record it in the completion report, and continue
|
||||
through Step 9: never call AskUserQuestion or stop for a prose answer. The NEVER-do invariants below do
|
||||
not relax: skip any recommendation that rewrites CHANGELOG or changes VERSION and
|
||||
record why. Step 8 and cross-model review refer to this rule; narrower caller scope wins.
|
||||
|
||||
@@ -92,10 +92,10 @@ DOC_DIFF_BASE=$(git merge-base origin/<base> HEAD 2>/dev/null || git merge-base
|
||||
echo "DOC_DIFF_BASE: $DOC_DIFF_BASE"
|
||||
```
|
||||
|
||||
1. Check the current branch. In standalone mode, if on the base branch, **abort**: "You're on the base branch. Run from a feature branch." A ship-owned read-only store audit uses its supplied source scope instead.
|
||||
1. Check the current branch. In standalone mode, if on the base branch, **abort**: "You're on the base branch. Run from a feature branch." Ship-owned mode skips this gate.
|
||||
|
||||
2. Gather the diff. In ship-owned mode, also read `git diff --cached`, `git diff`,
|
||||
and selected new-file content against the supplied base, not HEAD alone.
|
||||
2. Gather the diff. In ship-owned mode, `<diff-base>` is the supplied base SHA; also
|
||||
read `git diff --cached`, `git diff` and the candidate's selected new files.
|
||||
|
||||
```bash
|
||||
git diff <diff-base> HEAD --stat
|
||||
@@ -150,16 +150,16 @@ Use these definitions:
|
||||
- **Tutorial** — learning-oriented: step-by-step walkthrough for newcomers (getting started guides)
|
||||
- **Explanation** — understanding-oriented: "why this works this way" (ARCHITECTURE decisions, design rationale)
|
||||
|
||||
3. **Output the coverage map.** Items with zero coverage are **critical gaps** — flag them for
|
||||
Step 3. Items with reference-only coverage are **common gaps** — note them for the PR body.
|
||||
3. **Output the coverage map.** Items with zero coverage are **critical gaps**; items with
|
||||
reference-only coverage are **common gaps**. Report both as documentation debt.
|
||||
|
||||
4. **Architecture diagram drift detection.** If ARCHITECTURE.md (or any doc) contains ASCII
|
||||
diagrams or Mermaid blocks, extract entity names (modules, services, data flows) from the
|
||||
diagrams. Cross-reference against the diff. Flag any diagram entities that were renamed,
|
||||
split, removed, or moved in the code.
|
||||
|
||||
The coverage map feeds into Steps 2-3 (what to audit and fix) and Step 9 (documentation debt
|
||||
summary in the PR body). Do NOT auto-generate missing documentation pages — flag gaps only.
|
||||
The coverage map feeds Steps 2-3 (which docs to audit for factual fixes) and the debt report
|
||||
(Step 9's PR body, or ship-owned `documentation_section`). Do NOT auto-generate missing documentation pages — flag gaps only.
|
||||
When significant gaps are found, suggest running `/document-generate` to fill them.
|
||||
|
||||
---
|
||||
|
||||
Reference in new issue
Block a user