mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-18 06:04:33 +01:00
Ask each question once and check every handed-over file, in every skill that loads the shared preamble (GST-2756) (#4383)
* Load the never-print-secrets rule in every skill on every host, with the commands it missed (GST-2753) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * Ask each question once and check every handed-over file, in every skill on every host (GST-2756) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * Point the shared CI-wait rule at gstack-pr-wait and name the missed secret-printing commands The Ground Rules section told every skill to wait with gh pr checks --watch, which spends the shared GitHub GraphQL quota gstack moved off; it now names gstack-pr-wait. The banned list also covers ps aux and ps -ef, set -x, git config -l and an export $(...) that expands to a bare export. Size caps raised to the measured +70 bytes. Review-Finding: p1/red-team#1 reader=red-team Review-Finding: p1/red-team#2 reader=red-team Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * Say which skills carry the new rule in its release note Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * Say the new rules reach only skills that load the shared preamble Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * List all four shared Ground Rules in the loadouts guide Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
c5250dedc1
commit
a141e94388
113 files changed
+239
-108
No files matched your search
@@ -7,13 +7,15 @@ import type { TemplateContext } from '../types';
|
||||
* runs, so keep each bullet to one habit and the block at or under
|
||||
* GROUND_RULES_MAX_BYTES; test/ground-rules.test.ts pins that budget.
|
||||
*/
|
||||
export const GROUND_RULES_MAX_BYTES = 850;
|
||||
export const GROUND_RULES_MAX_BYTES = 900;
|
||||
|
||||
export const GROUND_RULES_HEADING = '## Ground Rules';
|
||||
|
||||
export const GROUND_RULES_BULLETS = [
|
||||
'Never print a whole environment, git config or process table; tokens ride in them. Banned: `env`, bare `printenv`, `set` or `export` (or an empty `export $(...)`), `export -p`/`-n`, `declare -p`/`-x`, `typeset -p`, `set -x`, `git config --list`/`-l`, any `ps` with full args (`aux`, `-ef`, `-o args`), `docker top ... args`, `docker inspect` Env. Read one value by name (`git config --get <name>`), check a variable with `[ -n "${NAME:-}" ] && echo set`, list processes by name or pid.',
|
||||
'Wait on CI with one `gstack-pr-wait <n> --until green` call, never a poll loop or `gh pr checks --watch`.',
|
||||
'Ask each question once, after checking what you can yourself; until it is answered, list it as one waiting line in later updates instead of asking again.',
|
||||
'Open every file you hand over and remove placeholders first: TODO, `<fill in>`, lorem ipsum, broken links and images.',
|
||||
] as const;
|
||||
|
||||
export function generateGroundRules(_ctx?: TemplateContext): string {
|
||||
|
||||
Reference in new issue
Block a user