mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-21 23:51:35 +01:00
pregate: gstack declares remote_gate_runs, so a green Free Tests run at the pregate tree clears remote_gate (GST-1024)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
fc292e22f5
commit
a58cf98d01
8 files changed
+223
-23
No files matched your search
+27
-4
@@ -89,7 +89,7 @@ the byte-pinned `/ship` renders in `test/fixtures/golden/`).
|
||||
| `timeout_s` | seconds each runner process may take (the unit-file group, each serial file, each guard without its own `timeout_s`, and the remote gate's deadline) when `--timeout` is not passed; 1 to 3600, default 600. `gstack-ship-preflight` and the `finish` fallback run pregate without `--timeout`, so this is how a repo with long lanes sets theirs |
|
||||
| `remote_gate` | the repo's remote test gate command; under 8 cores the local test tier becomes a `requires-remote` obligation naming it, and `--remote` runs it (see [remote gate](#remote-gate)) |
|
||||
| `run_profiles` | name → `{ workflow, events, jobs, artifact, max_age_hours?, os? }`: the GitHub Actions runs `clear --run` verifies as evidence on the identical tree; a profile named after a lane (`free-tests.yml/macos-named-regressions`) clears that lane (see [run evidence](#run-evidence)). `--from-run` and the main-push reuse job verify runs against them too ([from-run](#from-run), [CI reuse](#ci-reuse)) |
|
||||
| `remote_gate_runs` | `{ profiles, inventory }`: the run profiles that together clear `pregate.json/remote_gate`, and the command that prints the remote gate's test files, one per line, which their runs must cover (see [run evidence](#run-evidence)) |
|
||||
| `remote_gate_runs` | `{ profiles, inventory, skipped? }`: the run profiles that together clear `pregate.json/remote_gate`, the command that prints the remote gate's test files, one per line, which their runs must cover, and an optional command that prints which selected files the gate itself never runs (see [run evidence](#run-evidence)) |
|
||||
| `allowlist` | `[{ finding, paths?, pattern?, reason }]`: benign findings the `secrets` check accepts and names as allowlisted, by gstack-redact finding id or non-secret category, path globs and a pattern anchored at the finding; never `env.value` (see [allowlist](#allowlist)) |
|
||||
|
||||
Only the `origin/<base>` copy or the user-owned file below is honoured, so a
|
||||
@@ -734,6 +734,14 @@ Then, for the lane:
|
||||
while the working tree is pregate.json's tree (checked before and after it
|
||||
runs); an empty or failing inventory refuses, and it runs under `pipefail`,
|
||||
so a pipeline whose first command fails refuses too.
|
||||
- When `remote_gate_runs` declares `skipped`, that command runs the same way,
|
||||
with `PREGATE_FILES_FILE` naming a file of the obligation's selected test
|
||||
files, one per line, and prints the ones the remote gate itself never runs
|
||||
(gstack's gate leaves paid test files to the paid PR gate). Those files need
|
||||
no run, and the receipt counts them as `skipped=<n>`. A file the inventory
|
||||
prints stays required even when `skipped` names it, and a failing `skipped`
|
||||
command refuses (`skipped_failed`). Without `skipped`, every selected file
|
||||
must appear in a run's `files`.
|
||||
- Every run is read once more after the inventory: a run that moved to a new
|
||||
attempt or stopped being a success meanwhile refuses (`run_changed`).
|
||||
|
||||
@@ -745,13 +753,14 @@ verification is named with its own reason (`fork_run`, `event_mismatch`,
|
||||
`os_mismatch`, `api_error`, …); the clear-level codes are `base_mismatch`,
|
||||
`no_verified_run`, `tree_mismatch` (runs on different trees),
|
||||
`tree_not_stamp_only`, `no_tests`, `inventory_failed`, `inventory_empty`,
|
||||
`inventory_uncovered` (the remote gate) and `tests_uncovered` (a lane's own
|
||||
`skipped_failed`, `inventory_uncovered` (the remote gate) and `tests_uncovered` (a lane's own
|
||||
selected tests). A wrong run count, a repeated run or a lane with no
|
||||
profile is a usage error (exit 2), not a REUSE refusal.
|
||||
|
||||
Accepted, `clear` prints `REUSE: accepted <lane> <receipt>`, and the receipt
|
||||
reads `remote-gate tree=<t12> tests=<n> runs=<id>/<attempt>,… profiles=<p>,…
|
||||
heads=<h12> verified=<time>` (with `accepted-for=` and the substitution for a
|
||||
heads=<h12> verified=<time>` (with `skipped=<n>` after `tests=` when the
|
||||
`skipped` command excused selected files, and `accepted-for=` and the substitution for a
|
||||
stamp-only predecessor). A lane with its own profile gets `run tree=… runs=…`
|
||||
the same way; for such a lane `--run-url` is verified as `--run` is, and
|
||||
`--bundle-lane` is refused. A lane with no profile still clears by
|
||||
@@ -796,7 +805,21 @@ every non-matrix job and the `free-tests` aggregate, `os` Linux) and
|
||||
aggregate, `os` Windows). Each accepts `pull_request` and `workflow_dispatch`
|
||||
runs and reads the `tested-tree` artifact, which both aggregates upload only
|
||||
after their strict verification passes. The main-push reuse job and
|
||||
`--from-run` read them. No lane has a profile, so every macOS and Windows lane
|
||||
`--from-run` read them, and `remote_gate_runs` names `ci-reuse/free-tests`,
|
||||
so a green Free Tests run at pregate.json's tree clears
|
||||
`pregate.json/remote_gate` without a Ubicloud VM:
|
||||
|
||||
```bash
|
||||
gstack-pregate clear --remote pregate.json/remote_gate --run <free-tests run id or url> --allow-repo-commands
|
||||
```
|
||||
|
||||
Its `inventory` is `scripts/test-free-shards.ts --list` (the complete free
|
||||
suite, the same set the Free Tests plan shards), and its `skipped` command
|
||||
prints the selected files `test/helpers/paid-test-set.ts` marks paid, the
|
||||
same split `scripts/ubicloud/pregate-remote.sh` makes before it runs. A
|
||||
`pull_request` run counts only when the branch already contains its base
|
||||
(the merge commit's tree is the head's), so a branch behind main still needs
|
||||
the gate or a fresh run. No lane has a profile, so every macOS and Windows lane
|
||||
still clears by `--run-url`, checked for its workflow file and a green
|
||||
conclusion. On main the free tier's Windows smoke lane is
|
||||
`windows-smoke.yml/windows-smoke`, and a `windows-smoke.yml` run clears it.
|
||||
|
||||
Reference in new issue
Block a user