fix: update check preamble exits 1 when up to date — convert all skills to .tmpl

The `[ -n "$_UPD" ] && echo "$_UPD"` line in 5 skills was missing `|| true`,
causing exit code 1 when the update check finds no update (empty $_UPD).

Fix: convert ship/, review/, plan-ceo-review/, plan-eng-review/, retro/ to
.tmpl templates using {{UPDATE_CHECK}} placeholder (same as browse/qa/etc).
All 9 skills now generated from templates — preamble changes propagate everywhere.

Also: regenerates qa/SKILL.md which had drifted from its template, adds 12 tests
validating the update check preamble exits 0 in all skills, removes completed TODO.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

test/skill-validation.test.ts

@@ -152,6 +152,52 @@ describe('Generated SKILL.md freshness', () => {
   });
 });
 
+// --- Update check preamble validation ---
+
+describe('Update check preamble', () => {
+  const skillsWithUpdateCheck = [
+    'SKILL.md', 'browse/SKILL.md', 'qa/SKILL.md',
+    'setup-browser-cookies/SKILL.md',
+    'ship/SKILL.md', 'review/SKILL.md',
+    'plan-ceo-review/SKILL.md', 'plan-eng-review/SKILL.md',
+    'retro/SKILL.md',
+  ];
+
+  for (const skill of skillsWithUpdateCheck) {
+    test(`${skill} update check line ends with || true`, () => {
+      const content = fs.readFileSync(path.join(ROOT, skill), 'utf-8');
+      // The second line of the bash block must end with || true
+      // to avoid exit code 1 when _UPD is empty (up to date)
+      const match = content.match(/\[ -n "\$_UPD" \].*$/m);
+      expect(match).not.toBeNull();
+      expect(match![0]).toContain('|| true');
+    });
+  }
+
+  test('all skills with update check are generated from .tmpl', () => {
+    for (const skill of skillsWithUpdateCheck) {
+      const tmplPath = path.join(ROOT, skill + '.tmpl');
+      expect(fs.existsSync(tmplPath)).toBe(true);
+    }
+  });
+
+  test('update check bash block exits 0 when up to date', () => {
+    // Simulate the exact preamble command from SKILL.md
+    const result = Bun.spawnSync(['bash', '-c',
+      '_UPD=$(echo "" || true); [ -n "$_UPD" ] && echo "$_UPD" || true'
+    ], { stdout: 'pipe', stderr: 'pipe' });
+    expect(result.exitCode).toBe(0);
+  });
+
+  test('update check bash block exits 0 when upgrade available', () => {
+    const result = Bun.spawnSync(['bash', '-c',
+      '_UPD=$(echo "UPGRADE_AVAILABLE 0.3.3 0.4.0" || true); [ -n "$_UPD" ] && echo "$_UPD" || true'
+    ], { stdout: 'pipe', stderr: 'pipe' });
+    expect(result.exitCode).toBe(0);
+    expect(result.stdout.toString().trim()).toBe('UPGRADE_AVAILABLE 0.3.3 0.4.0');
+  });
+});
+
 // --- Part 7: Cross-skill path consistency (A1) ---
 
 describe('Cross-skill path consistency', () => {