mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-15 21:07:20 +01:00
fix: pre-landing review fixes
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
97d562c37f
commit
a681c00a2b
10 files changed
+96
-36
No files matched your search
@@ -37,7 +37,7 @@ commit themes; do not repeat the captions.
|
||||
the failed run, or their request, quoted); the rest say what changes for them. No inventory: BAD "Adds
|
||||
a lint and a CI step." GOOD "'The review loop is too overzealous.' Pass 2 now reads only pass 1's range."
|
||||
6. **`## Blast radius`:** the body template's item, written once, here: what else the change touches and
|
||||
the one fact that makes that safe, with the evidence-ladder rung it reached (`investigate/sections/blast-radius.md`).
|
||||
the one fact that makes that safe, with the evidence-ladder rung it reached (`~/.claude/skills/gstack/investigate/sections/blast-radius.md`, when present).
|
||||
7. **`## Approvals`:** the output of `~/.claude/skills/gstack/bin/gstack-approvals render`, verbatim. It
|
||||
escapes its cells, and the receipt never reads it as an approval citation. On
|
||||
`APPROVAL_RECORD_UNAVAILABLE` keep its text and say so in the READY report. Never type rows by hand.
|
||||
|
||||
@@ -35,7 +35,7 @@ commit themes; do not repeat the captions.
|
||||
the failed run, or their request, quoted); the rest say what changes for them. No inventory: BAD "Adds
|
||||
a lint and a CI step." GOOD "'The review loop is too overzealous.' Pass 2 now reads only pass 1's range."
|
||||
6. **`## Blast radius`:** the body template's item, written once, here: what else the change touches and
|
||||
the one fact that makes that safe, with the evidence-ladder rung it reached (`investigate/sections/blast-radius.md`).
|
||||
the one fact that makes that safe, with the evidence-ladder rung it reached (`~/.claude/skills/gstack/investigate/sections/blast-radius.md`, when present).
|
||||
7. **`## Approvals`:** the output of `~/.claude/skills/gstack/bin/gstack-approvals render`, verbatim. It
|
||||
escapes its cells, and the receipt never reads it as an approval citation. On
|
||||
`APPROVAL_RECORD_UNAVAILABLE` keep its text and say so in the READY report. Never type rows by hand.
|
||||
|
||||
@@ -86,7 +86,7 @@ before the commit and names each line to rewrite.">
|
||||
<One or two sentences: what else the change touches (callers, consumers, generated
|
||||
files, hosts) and the one fact that makes that safe, with the rung of the evidence
|
||||
ladder the fact reached (file:line read, walked failure path, script ran, repro). The
|
||||
ladder is `investigate/sections/blast-radius.md`.>
|
||||
ladder is `~/.claude/skills/gstack/investigate/sections/blast-radius.md`, when present.>
|
||||
|
||||
## Test Coverage
|
||||
<coverage diagram from Step 7, or "All new code paths have test coverage.">
|
||||
@@ -205,7 +205,7 @@ PR_BODY_FILE=$(mktemp "${TMPDIR:-/tmp}/gstack-pr-body.XXXXXX") || { echo "ERROR:
|
||||
BODY_TOP_FILE="$(git rev-parse --show-toplevel 2>/dev/null || pwd)/.gstack/tmp/<body-top-file-name>"
|
||||
BODY_REST_FILE="$(git rev-parse --show-toplevel 2>/dev/null || pwd)/.gstack/tmp/<body-rest-file-name>"
|
||||
[ -s "$BODY_TOP_FILE" ] && [ -s "$BODY_REST_FILE" ] || { echo "Not composed: $BODY_TOP_FILE or $BODY_REST_FILE is empty, so the body was never written. Write both, then rerun." >&2; exit 1; }
|
||||
~/.claude/skills/gstack/bin/gstack-prose-lint "$BODY_TOP_FILE" "$BODY_REST_FILE" --gate || { echo "Not composed: rewrite each PROSE: line above in the drafts (never a verbatim tool section), then rerun." >&2; exit 1; }
|
||||
~/.claude/skills/gstack/bin/gstack-prose-lint "$BODY_TOP_FILE" --sections 'What changed,Why,Summary,Blast radius' --gate || { echo "Not composed: rewrite each PROSE: line above in the draft, then rerun." >&2; exit 1; }
|
||||
{ awk 1 "$BODY_TOP_FILE" && cat -- "$DOCS_SECTION_FILE" && echo && awk 1 "$BODY_REST_FILE"; } > "$PR_BODY_FILE" || exit 1
|
||||
rm -f "$BODY_TOP_FILE" "$BODY_REST_FILE"
|
||||
echo "PR_BODY_FILE: $PR_BODY_FILE"
|
||||
|
||||
@@ -77,7 +77,7 @@ before the commit and names each line to rewrite.">
|
||||
<One or two sentences: what else the change touches (callers, consumers, generated
|
||||
files, hosts) and the one fact that makes that safe, with the rung of the evidence
|
||||
ladder the fact reached (file:line read, walked failure path, script ran, repro). The
|
||||
ladder is `investigate/sections/blast-radius.md`.>
|
||||
ladder is `~/.claude/skills/gstack/investigate/sections/blast-radius.md`, when present.>
|
||||
|
||||
## Test Coverage
|
||||
<coverage diagram from Step 7, or "All new code paths have test coverage.">
|
||||
@@ -188,7 +188,7 @@ PR_BODY_FILE=$(mktemp "${TMPDIR:-/tmp}/gstack-pr-body.XXXXXX") || { echo "ERROR:
|
||||
BODY_TOP_FILE="$(git rev-parse --show-toplevel 2>/dev/null || pwd)/.gstack/tmp/<body-top-file-name>"
|
||||
BODY_REST_FILE="$(git rev-parse --show-toplevel 2>/dev/null || pwd)/.gstack/tmp/<body-rest-file-name>"
|
||||
[ -s "$BODY_TOP_FILE" ] && [ -s "$BODY_REST_FILE" ] || { echo "Not composed: $BODY_TOP_FILE or $BODY_REST_FILE is empty, so the body was never written. Write both, then rerun." >&2; exit 1; }
|
||||
~/.claude/skills/gstack/bin/gstack-prose-lint "$BODY_TOP_FILE" "$BODY_REST_FILE" --gate || { echo "Not composed: rewrite each PROSE: line above in the drafts (never a verbatim tool section), then rerun." >&2; exit 1; }
|
||||
~/.claude/skills/gstack/bin/gstack-prose-lint "$BODY_TOP_FILE" --sections 'What changed,Why,Summary,Blast radius' --gate || { echo "Not composed: rewrite each PROSE: line above in the draft, then rerun." >&2; exit 1; }
|
||||
{ awk 1 "$BODY_TOP_FILE" && cat -- "$DOCS_SECTION_FILE" && echo && awk 1 "$BODY_REST_FILE"; } > "$PR_BODY_FILE" || exit 1
|
||||
rm -f "$BODY_TOP_FILE" "$BODY_REST_FILE"
|
||||
echo "PR_BODY_FILE: $PR_BODY_FILE"
|
||||
|
||||
Reference in new issue
Block a user