v1.48.0.0 feat: AskUserQuestion split rule + runtime AUTO_DECIDE carve-out (#1740)

* feat(preamble): add "Handling 5+ options — split, never drop" rule

Agents repeatedly hit Conductor's 4-option AskUserQuestion cap and
silently drop one option to fit, shrinking the user's decision space.
This rule names the bug and gives two compliant shapes: batch into
≤4-groups (for coherent alternatives) or split into N sequential
per-option calls (for independent scope items, default).

Inline preamble subsection is ~15 lines (rule + buckets + pointer).
Full reference with worked examples, Hold/dependency semantics, and
final-summary validation lives in docs/askuserquestion-split.md.
The agent loads the docs file on demand when N>4.

Per-option call shape: D<N>.k header, ELI10, Recommendation, kind-note
(no completeness score — decision actions, not coverage), Include /
Defer / Cut / Hold buckets. Hold stops the chain immediately; the
final D<N>.final call validates dependencies and confirms the
assembled scope.

question_ids: <skill>-split-<option-slug> (kebab-case ASCII, ≤64
chars). Also fixes orphan "12. " prefix on the existing CJK rule.

Tier-2+ skills inherit via the existing resolver. SKILL.md regenerated
for all 41 affected skills + 3 golden fixtures. Net diff per SKILL.md:
~34 lines (vs ~110 for the full inline version).

6 tests pin the inline contract (4-option cap, buckets, D-numbering,
docs pointer, runtime AUTO_DECIDE gate reference, orphan 12 regression).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(question-pref): runtime AUTO_DECIDE carve-out for *-split-* ids

Split chains (per-option AskUserQuestion calls emitted by the new
"Handling 5+ options" rule) must never be silently auto-approved
via /plan-tune preferences. The user's option set is sacred.

Layer 1 (mechanism): unique <skill>-split-<option-slug> ids prevent
cross-option preference leakage. Layer 2 (this commit): the runtime
checker `gstack-question-preference --check` detects any id matching
*-split-* and forces ASK_NORMALLY even when never-ask or
ask-only-for-one-way preferences exist for that exact id. An
explanatory note tells the user their preference was bypassed and why.

7 tests pin the carve-out: no-pref baseline, never-ask override,
explanatory note text, ask-only-for-one-way override, always-ask
(no note), non-split id containing "split" word (negative case for
regex specificity), multi-skill split id formats.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(e2e): split-overflow regression for /plan-ceo-review

Periodic-tier E2E test that catches the original failure mode the
user complained about: 5+ options for ONE decision must split into
N sequential AskUserQuestion calls, not drop one to fit Conductor's
4-option cap.

Fixture: 5 independent chat-platform integration candidates
(Slack/Discord/Teams/Telegram/Mattermost), each carrying its own
include/defer/cut decision. Floor = 4 review-phase AUQs (standard
[N-1] tolerance band). Pre-fix "drop to 4 + 1 dropped" fails this
floor.

Wired into test/helpers/touchfiles.ts: tier periodic, depends on
plan-ceo-review/**, the new preamble subsection, the question-pref
binary (for the carve-out), and the runner helper. touchfiles.test.ts
expected count bumped 21 → 22 to account for the new entry.

Cost: ~$0.30/run when EVALS_TIER=periodic. Skips silently otherwise.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: post-merge regen + rebase size-budget baseline to v1.47.0.0

After merging origin/main (v1.45 → v1.47), three things needed cleanup:

1. spec/SKILL.md (main's new skill) regenerated to include our split-vs-drop
   preamble subsection — same mechanical regen as the other 41 tier-2+ skills.
2. Three golden ship fixtures refreshed to capture main's GSTACK_PLAN_MODE
   block + /spec routing entry + jargon-list.json refactor.
3. docs/skills.md — added /spec table row that main's PR (#1698/#1733) shipped
   without. Pre-existing failure on main; this PR catches and fixes.

Also rebased test/skill-size-budget.test.ts from v1.44.1 → v1.47.0.0 baseline.
Main's v1.46 (catalog tokens trim) + v1.47 (/spec skill) pushed the v1.44.1
anchor past the 5% ratchet to ×1.059 — pre-existing failure on main. This
PR captures a fresh parity-baseline-v1.47.0.0.json and re-anchors the test
there. Historical v1.44.1.json and v1.46.0.0.json retained in test/fixtures/
for reference. Our subsection contributes ~0.1% of the post-rebase corpus.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: bump version and changelog (v1.48.0.0)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-05-26 23:43:07 -07:00
committed by GitHub
parent f8bb59094d
commit a6fb31726c
60 changed files with 2902 additions and 62 deletions
+59
View File
@@ -103,6 +103,65 @@ describe('--check with preferences set', () => {
});
});
// Split-chain carve-out: question_ids matching <skill>-split-<option-slug>
// must always ASK_NORMALLY regardless of stored preferences.
// See scripts/resolvers/preamble/generate-ask-user-format.ts
// "Handling 5+ options — split, never drop" for the surrounding mechanism.
describe('--check split-chain carve-out (*-split-* always ASK_NORMALLY)', () => {
function setPref(id: string, pref: string) {
return run('--write', JSON.stringify({ question_id: id, preference: pref, source: 'plan-tune' }));
}
test('split-id without preference → ASK_NORMALLY', () => {
const r = run('--check', 'plan-ceo-review-split-e4-detect-mappings');
expect(r.stdout.trim()).toContain('ASK_NORMALLY');
});
test('split-id + never-ask → ASK_NORMALLY (carve-out overrides preference)', () => {
setPref('plan-ceo-review-split-e4-detect-mappings', 'never-ask');
const r = run('--check', 'plan-ceo-review-split-e4-detect-mappings');
expect(r.stdout).toContain('ASK_NORMALLY');
expect(r.stdout).not.toContain('AUTO_DECIDE');
});
test('split-id + never-ask → emits explanatory note', () => {
setPref('plan-ceo-review-split-e4-detect-mappings', 'never-ask');
const r = run('--check', 'plan-ceo-review-split-e4-detect-mappings');
expect(r.stdout).toContain('split-chain per-option calls always ASK_NORMALLY');
expect(r.stdout).toContain('never-ask');
});
test('split-id + ask-only-for-one-way → ASK_NORMALLY (carve-out overrides preference)', () => {
setPref('ship-split-version-bump', 'ask-only-for-one-way');
const r = run('--check', 'ship-split-version-bump');
expect(r.stdout).toContain('ASK_NORMALLY');
expect(r.stdout).not.toContain('AUTO_DECIDE');
});
test('split-id + always-ask → ASK_NORMALLY (no note since preference agrees)', () => {
setPref('plan-eng-review-split-add-test', 'always-ask');
const r = run('--check', 'plan-eng-review-split-add-test');
expect(r.stdout.trim()).toContain('ASK_NORMALLY');
expect(r.stdout).not.toContain('does not apply');
});
test('non-split id that just happens to contain "split" word is NOT carved out', () => {
// The carve-out matches `-split-` (kebab-cased), not the substring "split".
// A question id like `qa-splitscreen-test` (hypothetical) would not match.
// Verify by using a never-ask pref that should fire AUTO_DECIDE.
setPref('qa-splitscreen-test', 'never-ask');
const r = run('--check', 'qa-splitscreen-test');
expect(r.stdout.trim()).toContain('AUTO_DECIDE');
});
test('multiple split-id formats: skill-split-anything matches', () => {
setPref('autoplan-split-ceo-finding-7', 'never-ask');
const r = run('--check', 'autoplan-split-ceo-finding-7');
expect(r.stdout).toContain('ASK_NORMALLY');
expect(r.stdout).not.toContain('AUTO_DECIDE');
});
});
// -----------------------------------------------------------------------
// --write
// -----------------------------------------------------------------------