CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-05-08 06:26:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(preamble): emit EXPLAIN_LEVEL + QUESTION_TUNING bash echoes

Browse Source 
Features referenced these echoes at runtime but the preamble bash generator
never produced them. Added two config reads in generate-preamble-bash.ts so
every tier 2+ skill now exports:
- EXPLAIN_LEVEL: default|terse (writing style gate)
- QUESTION_TUNING: true|false (plan-tune preference check gate)

Also updates skill-validation tests:
- ALLOWED_SUBSTEPS adds 15.0 + 15.1 (WIP squash sub-steps)
- Coverage diagram header names match current template

Golden fixtures regenerated. 6 pre-existing test failures now pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-04-20 07:05:43 +08:00
parent 34876e9337
commit ac41d9fffd
40 changed files with 240 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/skill-validation.test.ts
+6 -5
View File
@@ -1103,7 +1103,7 @@ describe('Step 3.4 test coverage audit', () => {
test('ship/SKILL.md contains Step 7', () => {
const content = fs.readFileSync(path.join(ROOT, 'ship', 'SKILL.md'), 'utf-8');
expect(content).toContain('Step 7: Test Coverage Audit');
expect(content).toContain('CODE PATH COVERAGE');
expect(content).toContain('CODE PATHS');
});
test('Step 3.4 includes quality scoring rubric', () => {
@@ -1153,9 +1153,9 @@ describe('Step 3.4 test coverage audit', () => {
expect(content).toContain('Empty/zero/boundary states');
});
test('Step 3.4 diagram includes USER FLOW COVERAGE section', () => {
test('Step 3.4 diagram includes USER FLOWS section', () => {
const content = fs.readFileSync(path.join(ROOT, 'ship', 'SKILL.md'), 'utf-8');
expect(content).toContain('USER FLOW COVERAGE');
expect(content).toContain('USER FLOWS');
expect(content).toContain('Code paths:');
expect(content).toContain('User flows:');
});
@@ -1165,8 +1165,9 @@ describe('Step 3.4 test coverage audit', () => {
describe('ship step numbering', () => {
// Allowed sub-steps that are resolver-generated and intentionally nested:
// 8.1 (Plan Verification), 8.2 (Scope Drift), 9.1 (Review Army), 9.2 (Findings Merge), 9.3 (Cross-review dedup)
const ALLOWED_SUBSTEPS = new Set(['8.1', '8.2', '9.1', '9.2', '9.3']);
// 8.1 (Plan Verification), 8.2 (Scope Drift), 9.1 (Review Army), 9.2 (Findings Merge), 9.3 (Cross-review dedup),
// 15.0 (WIP Commit Squash), 15.1 (Bisectable Commits)
const ALLOWED_SUBSTEPS = new Set(['8.1', '8.2', '9.1', '9.2', '9.3', '15.0', '15.1']);
test('ship/SKILL.md.tmpl contains no unexpected fractional step numbers', () => {
const tmpl = fs.readFileSync(path.join(ROOT, 'ship', 'SKILL.md.tmpl'), 'utf-8');