v1.12.1.0 fix: remove vestigial plan-mode handshake (#1185)

* refactor: remove vestigial plan-mode handshake resolver

Delete scripts/resolvers/preamble/generate-plan-mode-handshake.ts and
its four question-registry entries. Split the authoritative
"Plan Mode Safe Operations" and "Skill Invocation During Plan Mode"
sections out of generate-completion-status.ts into a sibling
generatePlanModeInfo() export in the same module, wired at preamble
position 1 where the handshake used to live. Same text, new position.

The vestigial handshake told interactive review skills to emit an
A=exit-and-rerun / C=cancel AskUserQuestion before running their
interactive STOP-Ask workflow. That contradicted the authoritative
rule at the tail of completion-status.ts saying AskUserQuestion
satisfies plan mode's end-of-turn requirement. Skills now run
directly when invoked in plan mode, with each finding gated by
AskUserQuestion just like outside plan mode.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test: rename plan-mode-handshake-helpers to plan-mode-helpers, strengthen smokes

Rename test/helpers/plan-mode-handshake-helpers.ts to
test/helpers/plan-mode-helpers.ts. Keep the write-guard helper that
asserts no Write/Edit tool call before the first AskUserQuestion
(this is what catches silent-bypass regressions the textual smoke
can't see). Rename the API: runPlanModeHandshakeTest to
runPlanModeSkillTest, assertHandshakeShape to assertNotHandshakeShape.
Extend the capture struct with exitPlanModeBeforeAsk.

Rewrite the four per-skill E2E tests (plan-ceo, plan-eng, plan-design,
plan-devex) as smoke tests that assert the skill's Step 0 question
fires first, not an A/C handshake. Each test picks a cheap first
answer (HOLD, TRIAGE, numeric score) so the run terminates quickly.

Keep test/skill-e2e-plan-mode-no-op.test.ts as the outside-plan-mode
non-interference regression, per codex outside-voice review: deleting
it would lose coverage for "the hoisted section stays quiet when plan
mode is absent."

Replace the gen-skill-docs.test.ts handshake describe block (lines
2778+) with a plan-mode-info describe block that:
- scans every generated SKILL.md under the repo root + every host
  subdir (.agents, .openclaw, .opencode, .factory, .hermes, .kiro,
  .cursor, .slate) and asserts "## Plan Mode Handshake" is absent
- asserts "## Skill Invocation During Plan Mode" lands in the first
  15KB of each of the four review skills' generated SKILL.md

Both assertions run on every bun test. A PR that re-introduces the
handshake resolver fails CI immediately.

Update test/e2e-harness-audit.test.ts to reference the renamed
runPlanModeSkillTest. Update test/helpers/touchfiles.ts entries to
point at the new resolver owner (generate-completion-status.ts) and
the renamed helper, and align per-skill touchfile keys.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: regenerate SKILL.md across all hosts + refresh golden fixtures

Run bun run gen:skill-docs for every host to flush the vestigial
"## Plan Mode Handshake" section from every generated SKILL.md and
emit the hoisted "## Skill Invocation During Plan Mode" section at
preamble position 1 instead. Refresh the three golden-fixture
snapshots (claude, codex, factory) to match the new position.

No behavior change beyond the resolver swap in the prior commit.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: bump version and changelog (v1.12.1.0)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

scripts/question-registry.ts

@@ -261,45 +261,6 @@ export const QUESTIONS = {
     description: "Approve the design doc, revise sections, or start over?",
   },
 
-  // -----------------------------------------------------------------------
-  // Plan-mode handshake — fires at the top of any interactive review skill
-  // when the user is in plan mode. Safety-critical, always asked regardless
-  // of user's tuning preferences. See scripts/resolvers/preamble/generate-
-  // plan-mode-handshake.ts.
-  // -----------------------------------------------------------------------
-  'plan-ceo-review-plan-mode-handshake': {
-    id: 'plan-ceo-review-plan-mode-handshake',
-    skill: 'plan-ceo-review',
-    category: 'routing',
-    door_type: 'one-way',
-    options: ['exit-and-rerun', 'cancel'],
-    description: "Plan mode detected — exit and rerun interactively, or cancel?",
-  },
-  'plan-eng-review-plan-mode-handshake': {
-    id: 'plan-eng-review-plan-mode-handshake',
-    skill: 'plan-eng-review',
-    category: 'routing',
-    door_type: 'one-way',
-    options: ['exit-and-rerun', 'cancel'],
-    description: "Plan mode detected — exit and rerun interactively, or cancel?",
-  },
-  'plan-design-review-plan-mode-handshake': {
-    id: 'plan-design-review-plan-mode-handshake',
-    skill: 'plan-design-review',
-    category: 'routing',
-    door_type: 'one-way',
-    options: ['exit-and-rerun', 'cancel'],
-    description: "Plan mode detected — exit and rerun interactively, or cancel?",
-  },
-  'plan-devex-review-plan-mode-handshake': {
-    id: 'plan-devex-review-plan-mode-handshake',
-    skill: 'plan-devex-review',
-    category: 'routing',
-    door_type: 'one-way',
-    options: ['exit-and-rerun', 'cancel'],
-    description: "Plan mode detected — exit and rerun interactively, or cancel?",
-  },
-
   // -----------------------------------------------------------------------
   // /plan-ceo-review — scope & strategy
   // -----------------------------------------------------------------------