mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-17 05:41:50 +01:00
fix: pre-landing review fixes
Review-Finding: p1/red-team#1 reader=red-team Review-Finding: p1/specialist-batched#1 reader=security Review-Finding: p1/specialist-batched#2 reader=testing Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
7e7b248d37
commit
b0d38491b4
5 files changed
+23
-11
No files matched your search
+2
-2
@@ -1858,8 +1858,8 @@ reader, when all of these hold:
|
||||
canonical (no leading `a` digit unless it is `a`), at most 13 digits and at
|
||||
most 2^63−1 (`d4n4ub6itg400`);
|
||||
- neither it nor its sibling matches the base policy's
|
||||
[`review_exclude_paths`](#review-exclude-paths), since no reader saw an
|
||||
excluded script.
|
||||
[`review_exclude_paths`](#review-exclude-paths) or `readers.forbid_paths`,
|
||||
since no reader saw an excluded script.
|
||||
|
||||
Each proven sidecar prints `UID_SIDECAR: <path> (beside <sibling>)`. Any other
|
||||
`.uid` keeps its old route, usually behavior, and `finish` prints
|
||||
|
||||
@@ -3209,7 +3209,7 @@ range added or modified or the review-loop exception accepted`, `has no
|
||||
sibling <path> at the current tree`, `existed at the reviewed tree or the
|
||||
current base`, `is not a regular non-executable file (mode <mode>)`, `is not
|
||||
exactly one Godot uid://<id> line`, or `or its sibling matches the base
|
||||
policy's review_exclude_paths`.
|
||||
policy's review_exclude_paths or readers.forbid_paths`.
|
||||
|
||||
**Fix.** Commit the sidecar exactly as Godot wrote it, beside a script this PR
|
||||
added or changed: one `uid://<id>` line, a regular file, no symlink. Keep a
|
||||
|
||||
Reference in new issue
Block a user