fix(security): remove deleted /sidebar-chat endpoint from tunnel allowlist

mirror of https://github.com/garrytan/gstack.git synced 2026-09-17 02:15:31 +02:00

TUNNEL_PATHS is the audited tunnel attack surface — its own comment says every
addition widens it. '/sidebar-chat' stayed in the set after the endpoint was
deleted with the chat-queue path, meaning any future route matching that path
would have been silently tunnel-exposed. The set is now exactly the pair
ceremony (/connect) and the scoped command endpoint (/command), and the
dual-listener closed-set pin enforces that.

Also repairs a pre-existing red pin in dual-listener.test.ts: v1.63.0.0 made
the tunnel allowlist args-aware (canDispatchOverTunnel gained a second param)
without updating the test — red on main since then, invisible because the free
suite had no CI job.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

This commit is contained in:

Garry Tan

2026-08-14 21:00:17 -07:00

co-authored by

Claude Fable 5

parent a646a32b41

commit b241a79ee5

2 changed files with 9 additions and 4 deletions

									
										browse/src/server.ts
									
		-1
	
												View File
												
				@@ -303,7 +303,6 @@ export function resolveConfigFromEnv(): Omit<ServerConfig, 'browserManager' | 's

				const TUNNEL_PATHS = new Set<string>([

				  '/connect',

				  '/command',

				  '/sidebar-chat',

				]);

				/**