Ubicloud pack no longer fails while git rewrites a ref, and the HOLD SCOPE eval stops requiring the mode name (#4447)

Packing a checkout for a Ubicloud run no longer fails when git running
beside it is rewriting a ref, and the /plan-ceo-review HOLD SCOPE eval
no longer fails a review whose follow-up question doesn't repeat the
mode name.

Why: both made tests fail at random. The pack race failed Free Tests
twice on 2026-11-17, and the HOLD check failed the weekly eval census on
main.

Nothing to do.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
Garry Tanandcapy-ai[bot] authored and GitHub committed 2026-11-17 14:45:34 +00:00
1 parent f000b6e0e3
commit b49ed6a0d9
5 files changed
+33 -3

No files matched your search

+5 -1
View File
@@ -1703,7 +1703,11 @@ cmd_pack() {
trap "rm -rf $(printf %q "$tmp")" EXIT
# No template hooks from a global init.templateDir, and no auto-gc under the tar.
git -c gc.auto=0 init -q --bare --template= "$tmp/.git"
git -C "$tmp/.git" -c gc.auto=0 fetch -q --no-tags --update-shallow "$src" '+refs/*:refs/*' \
# Fetch the object ids one for-each-ref read, not upload-pack's own ref list: a ref that git running beside pack is
# deleting is advertised with a null id that no fetch can want, while for-each-ref skips it as broken.
git -C "$src" for-each-ref --format='+%(objectname):%(refname)' refs/ \
| git -C "$tmp/.git" -c gc.auto=0 fetch -q --no-tags --update-shallow --stdin \
--upload-pack='git -c uploadpack.allowAnySHA1InWant=true upload-pack' "$src" \
|| die "pack: could not snapshot the refs of $src"
if [ -z "$branch" ]; then
branch="detached-${head:0:12}"