CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-05-30 06:49:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: write ALL feedback to disk so agent can poll in background mode

Browse Source 
The agent backgrounds $D serve (Claude Code can't block on a subprocess
and do other work simultaneously). With stdout-only feedback delivery,
the agent never sees regenerate/remix feedback.

Fix: write feedback-pending.json (regenerate/remix) and feedback.json
(submit) to disk next to the board HTML. Agent polls the filesystem
instead of reading stdout. Both channels (stdout + disk) are always
active so foreground mode still works.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-03-27 09:52:46 -06:00
parent 229db44b8f
commit b57de95a7f
2 changed files with 29 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
design/src/serve.ts
+16 -6
View File
@@ -21,7 +21,14 @@
* │
* └──(timeout)──► exit 1
*
* Stdout: feedback JSON only (one line per feedback event)
* Feedback delivery (two channels, both always active):
* Stdout: feedback JSON (one line per event) — for foreground mode
* Disk: feedback-pending.json (regenerate/remix) or feedback.json (submit)
* written next to the HTML file — for background mode polling
*
* The agent typically backgrounds $D serve and polls for feedback-pending.json.
* When found: read it, delete it, generate new variants, POST /api/reload.
*
* Stderr: structured telemetry (SERVE_STARTED, SERVE_FEEDBACK_RECEIVED, etc.)
*/
@@ -120,14 +127,17 @@ export async function serve(options: ServeOptions): Promise<void> {
console.error(`SERVE_FEEDBACK_RECEIVED: type=${action}`);
// Print feedback JSON to stdout (agent reads this)
// Print feedback JSON to stdout (for foreground mode)
console.log(JSON.stringify(body));
if (isSubmit) {
// Write feedback.json next to the HTML file
const feedbackPath = path.join(path.dirname(html), "feedback.json");
fs.writeFileSync(feedbackPath, JSON.stringify(body, null, 2));
// ALWAYS write feedback to disk so the agent can poll for it
// (agent typically backgrounds $D serve, can't read stdout)
const feedbackDir = path.dirname(html);
const feedbackFile = isSubmit ? "feedback.json" : "feedback-pending.json";
const feedbackPath = path.join(feedbackDir, feedbackFile);
fs.writeFileSync(feedbackPath, JSON.stringify(body, null, 2));
if (isSubmit) {
state = "done";
if (timeoutTimer) clearTimeout(timeoutTimer);