CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-07-09 17:38:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: write ALL feedback to disk so agent can poll in background mode

Browse Source 
The agent backgrounds $D serve (Claude Code can't block on a subprocess
and do other work simultaneously). With stdout-only feedback delivery,
the agent never sees regenerate/remix feedback.

Fix: write feedback-pending.json (regenerate/remix) and feedback.json
(submit) to disk next to the board HTML. Agent polls the filesystem
instead of reading stdout. Both channels (stdout + disk) are always
active so foreground mode still works.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-03-27 09:52:46 -06:00
parent 229db44b8f
commit b57de95a7f
2 changed files with 29 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
design/test/serve.test.ts
+13 -3
View File
@@ -84,10 +84,10 @@ describe('Serve HTTP endpoints', () => {
try { body = await req.json(); } catch { return Response.json({ error: 'Invalid JSON' }, { status: 400 }); }
if (typeof body !== 'object' || body === null) return Response.json({ error: 'Expected JSON object' }, { status: 400 });
const isSubmit = body.regenerated === false;
const feedbackFile = isSubmit ? 'feedback.json' : 'feedback-pending.json';
fs.writeFileSync(path.join(tmpDir, feedbackFile), JSON.stringify(body, null, 2));
if (isSubmit) {
state = 'done';
const feedbackPath = path.join(tmpDir, 'feedback.json');
fs.writeFileSync(feedbackPath, JSON.stringify(body, null, 2));
return Response.json({ received: true, action: 'submitted' });
}
state = 'regenerating';
@@ -160,8 +160,12 @@ describe('Serve HTTP endpoints', () => {
expect(written.ratings.A).toBe(4);
});
test('POST /api/feedback with regenerate sets state to regenerating', async () => {
test('POST /api/feedback with regenerate sets state and writes feedback-pending.json', async () => {
state = 'serving';
// Clean up any prior pending file
const pendingPath = path.join(tmpDir, 'feedback-pending.json');
if (fs.existsSync(pendingPath)) fs.unlinkSync(pendingPath);
const feedback = {
preferred: 'B',
ratings: { A: 3, B: 5, C: 2 },
@@ -185,6 +189,12 @@ describe('Serve HTTP endpoints', () => {
const progress = await fetch(`${baseUrl}/api/progress`);
const pd = await progress.json();
expect(pd.status).toBe('regenerating');
// Agent can poll for feedback-pending.json
expect(fs.existsSync(pendingPath)).toBe(true);
const pending = JSON.parse(fs.readFileSync(pendingPath, 'utf-8'));
expect(pending.regenerated).toBe(true);
expect(pending.regenerateAction).toBe('different');
});
test('POST /api/feedback with remix contains remixSpec', async () => {