From b746d50dc516986d3d68994aeac16b2c9524f301 Mon Sep 17 00:00:00 2001 From: garrytan Date: Mon, 9 Nov 2026 14:25:54 +0000 Subject: [PATCH] Re-ask autoplan gate replies that leave an approval pending (#4181) Now that the /autoplan Phase 4 gate renders, its reply mapping is reachable. gstack-gate parse accepts p1a while a User Challenge is still pending, and treats all as rec, which takes plan-changing recommendations, yet the skill sent both straight to A (approve as written). Re-present a reply that leaves an approval item pending, and send a plan change chosen on a d or uc item, all included, to B or B2. The paragraph is 3 characters shorter, so the 12 autoplan size pins drop by 3. Review-Finding: p1/outside-voice#1 reader=outside-voice Review-Finding: p1/adversarial-native#1 reader=adversarial-native Review-Finding: p1/adversarial-native#2 reader=adversarial-native Review-Finding: p1/red-team#1 reader=red-team Review-Finding: p1/red-team#2 reader=red-team Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- autoplan/SKILL.md | 4 ++-- autoplan/SKILL.md.tmpl | 4 ++-- test/fixtures/skill-md-size-allowlist.json | 24 +++++++++++----------- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/autoplan/SKILL.md b/autoplan/SKILL.md index e8899e09e..bd628b298 100644 --- a/autoplan/SKILL.md +++ b/autoplan/SKILL.md @@ -663,8 +663,8 @@ verbatim (URGENT block, plain summary, numbered decisions seven per page with ea auto default, review-record path; `--page N` for later pages), never the full review. Parse the reply: `~/.claude/skills/gstack/bin/gstack-gate parse $_AP/gate.json --reply "" --gate-rev `; -unparsed or stale replies are re-presented (`gate_rev`+1), never guessed. `all` or `p1a` -without overrides = A; `d` overrides = B; `uc` overrides = B2; `p1c`/`p1d`/`p1e` +unparsed, stale or `pending` replies are re-presented (`gate_rev`+1), never guessed. `p1a` +with no change = A; a `d`/`uc` change (`all` too) = B/B2; `p1c`/`p1d`/`p1e` = C/D/E. Under `SESSION_KIND: unattended` Read `sections/unattended.md`, end here with its `GSTACK_RESULT` line and never approve. diff --git a/autoplan/SKILL.md.tmpl b/autoplan/SKILL.md.tmpl index c5f48565f..c7f049c11 100644 --- a/autoplan/SKILL.md.tmpl +++ b/autoplan/SKILL.md.tmpl @@ -398,8 +398,8 @@ verbatim (URGENT block, plain summary, numbered decisions seven per page with ea auto default, review-record path; `--page N` for later pages), never the full review. Parse the reply: `~/.claude/skills/gstack/bin/gstack-gate parse $_AP/gate.json --reply "" --gate-rev `; -unparsed or stale replies are re-presented (`gate_rev`+1), never guessed. `all` or `p1a` -without overrides = A; `d` overrides = B; `uc` overrides = B2; `p1c`/`p1d`/`p1e` +unparsed, stale or `pending` replies are re-presented (`gate_rev`+1), never guessed. `p1a` +with no change = A; a `d`/`uc` change (`all` too) = B/B2; `p1c`/`p1d`/`p1e` = C/D/E. Under `SESSION_KIND: unattended` Read `sections/unattended.md`, end here with its `GSTACK_RESULT` line and never approve. diff --git a/test/fixtures/skill-md-size-allowlist.json b/test/fixtures/skill-md-size-allowlist.json index 5bd4e25fd..22cb4ddff 100644 --- a/test/fixtures/skill-md-size-allowlist.json +++ b/test/fixtures/skill-md-size-allowlist.json @@ -2,53 +2,53 @@ "_comment": "Generated SKILL.md files over the limit, pinned at their exact character count (#3199). test/skill-md-size-guard.test.ts fails when a pinned skill grows past its pin or shrinks below it: lower the pin when a skill shrinks and delete it once the skill is within the limit. Raising a pin is an owner decision. The shared-preamble hoist (GSTA-96) moved every tier 2+ skill's shared preamble into sections/preamble.md; the pins below are what remains.", "limit": 100000, "pins": { - "agy/gstack-autoplan": 109575, + "agy/gstack-autoplan": 109572, "agy/gstack-plan-design-review": 109096, "agy/gstack-plan-devex-review": 114924, "agy/gstack-plan-eng-review": 143580, "agy/gstack-review": 104735, - "codex/gstack-autoplan": 108318, + "codex/gstack-autoplan": 108315, "codex/gstack-plan-design-review": 110453, "codex/gstack-plan-devex-review": 116432, "codex/gstack-plan-eng-review": 144745, "codex/gstack-review": 104119, - "copilot/gstack-autoplan": 109018, + "copilot/gstack-autoplan": 109015, "copilot/gstack-plan-design-review": 109362, "copilot/gstack-plan-devex-review": 114386, "copilot/gstack-plan-eng-review": 143745, "copilot/gstack-review": 104316, - "cursor/gstack-autoplan": 108250, + "cursor/gstack-autoplan": 108247, "cursor/gstack-plan-design-review": 107904, "cursor/gstack-plan-devex-review": 113656, "cursor/gstack-plan-eng-review": 142335, "cursor/gstack-review": 122788, - "factory/gstack-autoplan": 110528, + "factory/gstack-autoplan": 110525, "factory/gstack-plan-design-review": 111002, "factory/gstack-plan-devex-review": 117019, "factory/gstack-plan-eng-review": 145443, "factory/gstack-review": 126561, - "gbrain/gstack-autoplan": 108657, + "gbrain/gstack-autoplan": 108654, "gbrain/gstack-plan-eng-review": 124963, - "gemini/gstack-autoplan": 108808, + "gemini/gstack-autoplan": 108805, "gemini/gstack-plan-design-review": 109190, "gemini/gstack-plan-devex-review": 114214, "gemini/gstack-plan-eng-review": 143578, "gemini/gstack-review": 104138, - "hermes/gstack-autoplan": 108611, + "hermes/gstack-autoplan": 108608, "hermes/gstack-plan-eng-review": 124999, - "kiro/gstack-autoplan": 108024, + "kiro/gstack-autoplan": 108021, "kiro/gstack-plan-design-review": 107750, "kiro/gstack-plan-devex-review": 113508, "kiro/gstack-plan-eng-review": 142197, "kiro/gstack-review": 122612, - "openclaw/gstack-autoplan": 108480, + "openclaw/gstack-autoplan": 108477, "openclaw/gstack-plan-eng-review": 123478, - "opencode/gstack-autoplan": 108999, + "opencode/gstack-autoplan": 108996, "opencode/gstack-plan-design-review": 109218, "opencode/gstack-plan-devex-review": 114264, "opencode/gstack-plan-eng-review": 143604, "opencode/gstack-review": 123410, - "slate/gstack-autoplan": 108137, + "slate/gstack-autoplan": 108134, "slate/gstack-plan-design-review": 107827, "slate/gstack-plan-devex-review": 113582, "slate/gstack-plan-eng-review": 142266,