From b8790f0e095adc75ce8e4deecf70913aedc8d960 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Tue, 17 Mar 2026 22:15:17 -0700 Subject: [PATCH] fix: remove remaining Rails-isms from retro and review templates MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - retro: app/services/ → src/services/ in examples and JSON schema - review: app/models/post.rb → src/models/post.ts in example output Co-Authored-By: Claude Opus 4.6 (1M context) --- retro/SKILL.md | 6 +++--- retro/SKILL.md.tmpl | 6 +++--- review/SKILL.md | 4 ++-- review/SKILL.md.tmpl | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/retro/SKILL.md b/retro/SKILL.md index 71eab988..36c7af17 100644 --- a/retro/SKILL.md +++ b/retro/SKILL.md @@ -240,7 +240,7 @@ Then show a **per-author leaderboard** immediately below: ``` Contributor Commits +/- Top area You (garry) 32 +2400/-300 browse/ -alice 12 +800/-150 app/services/ +alice 12 +800/-150 src/services/ bob 3 +120/-40 tests/ ``` @@ -325,7 +325,7 @@ From commit diffs, estimate PR sizes and bucket them: ### Step 8: Focus Score + Ship of the Week -**Focus score:** Calculate the percentage of commits touching the single most-changed top-level directory (e.g., `app/services/`, `app/views/`). Higher score = deeper focused work. Lower score = scattered context-switching. Report as: "Focus score: 62% (app/services/)" +**Focus score:** Calculate the percentage of commits touching the single most-changed top-level directory (e.g., `src/`, `lib/`, `components/`). Higher score = deeper focused work. Lower score = scattered context-switching. Report as: "Focus score: 62% (src/services/)" **Ship of the week:** Auto-identify the single highest-LOC PR in the window. Highlight it: - PR number and title @@ -443,7 +443,7 @@ Use the Write tool to save the JSON file with this schema: }, "authors": { "Garry Tan": { "commits": 32, "insertions": 2400, "deletions": 300, "test_ratio": 0.41, "top_area": "browse/" }, - "Alice": { "commits": 12, "insertions": 800, "deletions": 150, "test_ratio": 0.35, "top_area": "app/services/" } + "Alice": { "commits": 12, "insertions": 800, "deletions": 150, "test_ratio": 0.35, "top_area": "src/services/" } }, "version_range": ["1.16.0.0", "1.16.1.0"], "streak_days": 47, diff --git a/retro/SKILL.md.tmpl b/retro/SKILL.md.tmpl index bfbc2003..487a8ac8 100644 --- a/retro/SKILL.md.tmpl +++ b/retro/SKILL.md.tmpl @@ -136,7 +136,7 @@ Then show a **per-author leaderboard** immediately below: ``` Contributor Commits +/- Top area You (garry) 32 +2400/-300 browse/ -alice 12 +800/-150 app/services/ +alice 12 +800/-150 src/services/ bob 3 +120/-40 tests/ ``` @@ -221,7 +221,7 @@ From commit diffs, estimate PR sizes and bucket them: ### Step 8: Focus Score + Ship of the Week -**Focus score:** Calculate the percentage of commits touching the single most-changed top-level directory (e.g., `app/services/`, `app/views/`). Higher score = deeper focused work. Lower score = scattered context-switching. Report as: "Focus score: 62% (app/services/)" +**Focus score:** Calculate the percentage of commits touching the single most-changed top-level directory (e.g., `src/`, `lib/`, `components/`). Higher score = deeper focused work. Lower score = scattered context-switching. Report as: "Focus score: 62% (src/services/)" **Ship of the week:** Auto-identify the single highest-LOC PR in the window. Highlight it: - PR number and title @@ -339,7 +339,7 @@ Use the Write tool to save the JSON file with this schema: }, "authors": { "Garry Tan": { "commits": 32, "insertions": 2400, "deletions": 300, "test_ratio": 0.41, "top_area": "browse/" }, - "Alice": { "commits": 12, "insertions": 800, "deletions": 150, "test_ratio": 0.35, "top_area": "app/services/" } + "Alice": { "commits": 12, "insertions": 800, "deletions": 150, "test_ratio": 0.35, "top_area": "src/services/" } }, "version_range": ["1.16.0.0", "1.16.1.0"], "streak_days": 47, diff --git a/review/SKILL.md b/review/SKILL.md index d1f42e87..31a44f96 100644 --- a/review/SKILL.md +++ b/review/SKILL.md @@ -264,11 +264,11 @@ Example format: ``` I auto-fixed 5 issues. 2 need your input: -1. [CRITICAL] app/models/post.rb:42 — Race condition in status transition +1. [CRITICAL] src/models/post.ts:42 — Race condition in status transition Fix: Add `WHERE status = 'draft'` to the UPDATE → A) Fix B) Skip -2. [INFORMATIONAL] app/services/generator.rb:88 — LLM output not type-checked before DB write +2. [INFORMATIONAL] src/services/generator.py:88 — LLM output not type-checked before DB write Fix: Add JSON schema validation → A) Fix B) Skip diff --git a/review/SKILL.md.tmpl b/review/SKILL.md.tmpl index c1d3fae6..07063bb4 100644 --- a/review/SKILL.md.tmpl +++ b/review/SKILL.md.tmpl @@ -112,11 +112,11 @@ Example format: ``` I auto-fixed 5 issues. 2 need your input: -1. [CRITICAL] app/models/post.rb:42 — Race condition in status transition +1. [CRITICAL] src/models/post.ts:42 — Race condition in status transition Fix: Add `WHERE status = 'draft'` to the UPDATE → A) Fix B) Skip -2. [INFORMATIONAL] app/services/generator.rb:88 — LLM output not type-checked before DB write +2. [INFORMATIONAL] src/services/generator.py:88 — LLM output not type-checked before DB write Fix: Add JSON schema validation → A) Fix B) Skip