From b9d734ad91760629bb74f2ca5c839f3dd9ffdffb Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Wed, 18 Mar 2026 11:09:04 -0700 Subject: [PATCH] feat: add /debug recommendation to /review (Step 5.7) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When /review finds what appears to be a pre-existing bug in the base branch (not introduced by the PR's diff), it now classifies it as INFORMATIONAL and recommends running /debug for systematic root-cause investigation. No Agent spawning — /review's scope stays on the diff. Co-Authored-By: Claude Opus 4.6 (1M context) --- review/SKILL.md | 12 ++++++++++++ review/SKILL.md.tmpl | 12 ++++++++++++ 2 files changed, 24 insertions(+) diff --git a/review/SKILL.md b/review/SKILL.md index 354e715b..cbb24812 100644 --- a/review/SKILL.md +++ b/review/SKILL.md @@ -409,6 +409,18 @@ If no documentation files exist, skip this step silently. --- +## Step 5.7: Pre-existing bug detection + +If during the two-pass review you identified findings that appear to be bugs in the **base branch** (not introduced by this PR's diff): + +1. Classify them as INFORMATIONAL in your output +2. Note: "This appears to be a pre-existing issue, not introduced by this PR." +3. Recommend: "Run `/debug` to investigate this systematically — it traces root cause before applying fixes." + +Do not spawn agents or investigate further — /review's scope is the diff. Pre-existing bugs are out of scope for this review. + +--- + ## Important Rules - **Read the FULL diff before commenting.** Do not flag issues already addressed in the diff. diff --git a/review/SKILL.md.tmpl b/review/SKILL.md.tmpl index 7094a156..8361b68b 100644 --- a/review/SKILL.md.tmpl +++ b/review/SKILL.md.tmpl @@ -230,6 +230,18 @@ If no documentation files exist, skip this step silently. --- +## Step 5.7: Pre-existing bug detection + +If during the two-pass review you identified findings that appear to be bugs in the **base branch** (not introduced by this PR's diff): + +1. Classify them as INFORMATIONAL in your output +2. Note: "This appears to be a pre-existing issue, not introduced by this PR." +3. Recommend: "Run `/debug` to investigate this systematically — it traces root cause before applying fixes." + +Do not spawn agents or investigate further — /review's scope is the diff. Pre-existing bugs are out of scope for this review. + +--- + ## Important Rules - **Read the FULL diff before commenting.** Do not flag issues already addressed in the diff.