fix(qa-callers): exploratory preflight says the scope/method Reads come after exploratory.md; design-review scan check credits an executed scan proven by one engine run over the changed files

This commit is contained in:
garrytan committed 2026-10-03 10:19:05 +00:00
1 parent 6fb8ea3d10
commit ba00f010c1
6 files changed
+55 -5

No files matched your search

+2 -1
View File
@@ -231,6 +231,7 @@ export function generateQAReviewPreflight(ctx: TemplateContext): string {
return `> **STOP.** Before any probe, including plan checks, complete the ordered scope/method Reads below and await them. Templates cannot replace them.
${ctx.skillName === 'review' ? 'Step 4 is read-only: defer charters, setup and probes to Step 4.7.\n' : ''}
{{QA_RESOURCE:exploratory}}
Reading exploratory.md does not complete them: when it returns, Read the scope section and selected surface methods it lists, in order, and await them.
Resolve QA's \`sections/...\` and \`templates/...\` paths from that installed QA SKILL.md directory, not the caller or product directory.`;
}
@@ -246,7 +247,7 @@ Never overwrite another run's reports. Batch only independent Reads.
${ship ? `**1. Load methods before any QA or explicit-verification probe.**
${generateQAReviewPreflight(ctx)}` : `**1. Set the charter and isolation.**
Reuse Step 4's surfaces and completed Reads. Finish missing methods before charters; do not repeat completed Reads.
Reuse Step 4's surfaces and completed Reads. Finish any missing scope/method Reads before charters, setup or probes; do not repeat completed Reads.
Write the Charter and complete the shared isolation/permission preflight before setup.`}
**2. ${ship ? 'List required checks.' : 'Check readiness and list required checks.'}**