From bb57306d98c97011b0919c6132705a15b1579781 Mon Sep 17 00:00:00 2001 From: t Date: Tue, 14 Jul 2026 11:10:38 -0700 Subject: [PATCH] plan-eng-review: verify server-gated UI outcomes Reconstructs PR #1874 from its source template and generated section. --- plan-eng-review/sections/review-sections.md | 1 + plan-eng-review/sections/review-sections.md.tmpl | 1 + 2 files changed, 2 insertions(+) diff --git a/plan-eng-review/sections/review-sections.md b/plan-eng-review/sections/review-sections.md index 7592f0a70..bedb9f54e 100644 --- a/plan-eng-review/sections/review-sections.md +++ b/plan-eng-review/sections/review-sections.md @@ -126,6 +126,7 @@ Evaluate: * Code organization and module structure. * DRY violations—be aggressive here. * Error handling patterns and missing edge cases (call these out explicitly). +* Server-gated or actuated actions with optimistic UI—does the client await and surface the real result, or assume success? A swallowed rejection (auth/permission/validation) renders as false success; verify the effect landed, not the toast. * Technical debt hotspots. * Areas that are over-engineered or under-engineered relative to my preferences. * Existing ASCII diagrams in touched files — are they still accurate after this change? diff --git a/plan-eng-review/sections/review-sections.md.tmpl b/plan-eng-review/sections/review-sections.md.tmpl index 9dc6e6f49..64562a6b1 100644 --- a/plan-eng-review/sections/review-sections.md.tmpl +++ b/plan-eng-review/sections/review-sections.md.tmpl @@ -28,6 +28,7 @@ Evaluate: * Code organization and module structure. * DRY violations—be aggressive here. * Error handling patterns and missing edge cases (call these out explicitly). +* Server-gated or actuated actions with optimistic UI—does the client await and surface the real result, or assume success? A swallowed rejection (auth/permission/validation) renders as false success; verify the effect landed, not the toast. * Technical debt hotspots. * Areas that are over-engineered or under-engineered relative to my preferences. * Existing ASCII diagrams in touched files — are they still accurate after this change?