mirror of
https://github.com/garrytan/gstack.git
synced 2026-06-19 08:10:08 +02:00
feat(spec): expansions — flags, archive, quality gate, plan-mode-aware Phase 5, /ship integration, tests
Builds on the @jayzalowitz foundation (commit a4e6ee38) with the full
expansion set from CEO + Eng + DX review (24 user decisions + 23 of 28
codex adversarial findings).
spec/SKILL.md.tmpl additions:
- Flag reference table (--dedupe / --no-gate / --audit / --execute /
--no-execute / --file-only / --plan-file / --sync-archive).
- Phase 1b --dedupe (default ON): gh issue list --search with graceful
skip on gh-not-installed / unauthed / rate-limited / other errors.
AskUserQuestion when matches found (merge / file-new / cancel).
- Phase 3 HARD requirement: agent MUST grep/read at least one piece of
evidence before asking. Project-level fallback prose for prompts with
no concrete file mapping. Greenfield escape clause.
- Phase 4.5 quality gate (default ON): codex adversarial dispatch with
fail-closed redaction (AWS/GitHub/Anthropic/OpenAI/private-key regex),
hard <<<USER_SPEC>>> delimiters + instruction boundary (prompt-injection
defense), score 0-10 with <7 block, up to 3 iterations, AskUserQuestion
escape on persistent <7 (ship anyway / save draft / one more try).
- Phase 5 plan-mode-aware dispatch: reads GSTACK_PLAN_MODE env. Active
→ file-only + load into plan file. Inactive → file + --execute spawn
by default. CLI overrides for explicit control.
- Archive block via eval $(gstack-paths) → $GSTACK_STATE_ROOT/projects/
$SLUG/specs/<datetime>-<pid>-<slug>.md. Atomic .tmp/mv write. Sync
excluded by default; --sync-archive to opt in.
- --execute path: dirty-worktree gate (porcelain check + 3-option AUQ
continue/stash/cancel), TOCTOU re-check after AUQ answer, SHA pin
via git rev-parse HEAD, unique branch spec/<slug>-$$ + PID-suffixed
worktree, mandatory final-confirm gate, stash policy with restore
safety (preserve ref, never auto-drop).
- TTHW timestamps captured at Phase 1 / first citation / file-or-spawn,
emitted as ttfc_ms + tthw_ms in preamble telemetry envelope.
Cross-system plumbing:
- scripts/resolvers/preamble/generate-preamble-bash.ts: emit
GSTACK_PLAN_MODE=active|inactive based on CLAUDE_PLAN_FILE presence.
- scripts/resolvers/preamble/generate-routing-injection.ts: add /spec
to the routing block injected into project CLAUDE.md.
- ship/SKILL.md.tmpl: new "Linked Spec" PR-body section. Reads archive
frontmatter spec_issue_number and adds Closes #N when full delivery
confirmed by existing plan-completion gate (codex F4 — conditional).
Branch-name inference NOT used (codex F3 — fragile under rebase).
Tests (W7):
- test/spec-template-invariants.test.ts: 35 deterministic assertions
covering Phase 1 hard gate, Phase 3 hard-grep mandate, --dedupe
graceful-skip paths, --execute race + security hardening (TOCTOU,
SHA pin, unique branch), quality-gate redaction + BLOCKED path,
archive atomic write + sync exclusion, plan-mode-aware Phase 5.
- test/spec-template-sync.test.ts: regen + byte-identical check.
- test/skill-e2e-spec-execute.test.ts (periodic-tier scaffold).
- test/skill-llm-eval-spec.test.ts (periodic-tier scaffold).
- test/helpers/touchfiles.ts: register both periodics in E2E_TIERS +
LLM_JUDGE_TOUCHFILES.
37/37 /spec tests pass. Full bun test exit 0 (pre-existing
url-validation timeout unrelated to /spec).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -373,6 +373,10 @@ export const E2E_TOUCHFILES: Record<string, string[]> = {
|
||||
// Real-device path — only runs with GSTACK_HAS_IOS_DEVICE=1 + a paired
|
||||
// iPhone. Validates the CoreDevice agent + iOS SDK toolchain. Periodic-tier.
|
||||
'ios-qa-device': ['ios-qa/templates/**', 'test/fixtures/ios-qa/FixtureApp/**', 'test/skill-e2e-ios-device.test.ts'],
|
||||
|
||||
// /spec end-to-end via PTY — exercises the full Phase 1→5 pipeline
|
||||
// including --execute spawn. Periodic-tier — paid + non-deterministic.
|
||||
'spec-execute': ['spec/**', 'test/skill-e2e-spec-execute.test.ts'],
|
||||
};
|
||||
|
||||
/**
|
||||
@@ -647,6 +651,8 @@ export const E2E_TIERS: Record<string, 'gate' | 'periodic'> = {
|
||||
'ios-qa-swift-build': 'periodic',
|
||||
// Requires a real connected + paired iPhone. Manual-trigger only.
|
||||
'ios-qa-device': 'periodic',
|
||||
// /spec end-to-end PTY pipeline (paid, non-deterministic — periodic-tier).
|
||||
'spec-execute': 'periodic',
|
||||
};
|
||||
|
||||
/**
|
||||
@@ -671,6 +677,9 @@ export const LLM_JUDGE_TOUCHFILES: Record<string, string[]> = {
|
||||
// Plan Reviews
|
||||
'plan-ceo-review/SKILL.md modes': ['plan-ceo-review/SKILL.md', 'plan-ceo-review/SKILL.md.tmpl'],
|
||||
'plan-eng-review/SKILL.md sections': ['plan-eng-review/SKILL.md', 'plan-eng-review/SKILL.md.tmpl'],
|
||||
|
||||
// /spec authored-spec quality (paid LLM-judge — periodic-tier).
|
||||
'spec authored quality': ['spec/SKILL.md', 'spec/SKILL.md.tmpl', 'test/fixtures/spec/**'],
|
||||
'plan-design-review/SKILL.md passes': ['plan-design-review/SKILL.md', 'plan-design-review/SKILL.md.tmpl'],
|
||||
|
||||
// Design skills
|
||||
|
||||
Reference in New Issue
Block a user