Make gstack's shell locks hold when mkdir reports a race it lost (GST-2247) (#4262)

* Make gstack's shell locks hold when mkdir reports a race it lost (GST-2247)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Fix lock tests and fixtures for gstack_lock_take; trim setup-gbrain lock prose

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Ship the lock helper with every copied runtime and fixture that runs a lock

The Claude Code wrapper's copied runtime now includes bin/gstack-lock.sh, and
bin/gstack-render-claude.sh sources it beside itself, so gstack-config set
works in a copied runtime and the render lock is taken by every caller.
Test fixtures that copy single bin scripts now copy the helper too, and the
mkdir lock guard is registered as a repo-wide docs reader.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Release a lock whose owner file could not be fully written

gstack_lock_take created the owner file with a noclobber redirect and, when
that redirect failed, treated an existing file as a competing holder. If the
file was created but the write then failed (disk full, quota, ulimit -f), the
helper found its own empty file, returned 1 and left a lock nobody held;
freeze's state lock has no stale recovery, so it stayed busy until removed by
hand. The helper now tells "opened but write failed" from "already held",
removes its own file and directory, and returns 3. The inline copy in
gstack-ff-update is updated byte for byte, and a new test under ulimit -f 0
fails on the old helper.

Review-Finding: s11/outside-voice#1 reader=outside-voice
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Describe the lease lock as gstack_lock_take's O_EXCL owner file

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
Garry Tanandcapy-ai[bot] authored and GitHub committed 2026-11-17 09:05:25 +00:00
1 parent 76fad3edd9
commit bcece3fbcd
50 files changed
+621 -154

No files matched your search

+6 -5
View File
@@ -801,9 +801,9 @@ invocation.
ours.
- **STOP points are hard.** Gbrain doctor not healthy, installer PATH shadow,
migrate timeout, smoke test failure — each is a STOP. Do not paper over.
- **Concurrent-run lock.** At skill start, create the parent before acquiring
the lock atomically. Keep mkdir's error output; missing parents and filesystem
failures are not evidence of a competing run:
- **Concurrent-run lock.** Create the parent, then take the lock with
`gstack_lock_take` (O_EXCL; mkdir's status is no lock). A missing parent
is not a competing run:
```bash
GSTACK_STATE_ROOT=$(~/.claude/skills/gstack/bin/gstack-paths --get GSTACK_STATE_ROOT); : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
@@ -811,7 +811,8 @@ invocation.
echo "ERROR: Cannot create setup-gbrain lock parent $GSTACK_STATE_ROOT." >&2
exit 1
fi
if ! mkdir "$GSTACK_STATE_ROOT"/.setup-gbrain.lock.d; then
. ~/.claude/skills/gstack/bin/gstack-lock.sh || exit 1
if ! gstack_lock_take "$GSTACK_STATE_ROOT"/.setup-gbrain.lock.d; then
if [ -d "$GSTACK_STATE_ROOT"/.setup-gbrain.lock.d ]; then
echo "Another /setup-gbrain instance is running. Wait for it, or remove $GSTACK_STATE_ROOT/.setup-gbrain.lock.d only if you are sure it is stale." >&2
else
@@ -821,6 +822,6 @@ invocation.
fi
```
Release the acquired lock on normal exit AND in the SIGINT trap.
Release it (`rm -rf`, not rmdir) on normal exit AND in the SIGINT trap.
- **CLAUDE.md is the audit trail.** Always update it in Step 8 after a
successful setup.
+6 -5
View File
@@ -714,9 +714,9 @@ invocation.
ours.
- **STOP points are hard.** Gbrain doctor not healthy, installer PATH shadow,
migrate timeout, smoke test failure — each is a STOP. Do not paper over.
- **Concurrent-run lock.** At skill start, create the parent before acquiring
the lock atomically. Keep mkdir's error output; missing parents and filesystem
failures are not evidence of a competing run:
- **Concurrent-run lock.** Create the parent, then take the lock with
`gstack_lock_take` (O_EXCL; mkdir's status is no lock). A missing parent
is not a competing run:
```bash
GSTACK_STATE_ROOT=$(~/.claude/skills/gstack/bin/gstack-paths --get GSTACK_STATE_ROOT); : "${GSTACK_STATE_ROOT:?gstack-paths failed; reinstall with ./setup or /gstack-upgrade}"
@@ -724,7 +724,8 @@ invocation.
echo "ERROR: Cannot create setup-gbrain lock parent $GSTACK_STATE_ROOT." >&2
exit 1
fi
if ! mkdir "$GSTACK_STATE_ROOT"/.setup-gbrain.lock.d; then
. ~/.claude/skills/gstack/bin/gstack-lock.sh || exit 1
if ! gstack_lock_take "$GSTACK_STATE_ROOT"/.setup-gbrain.lock.d; then
if [ -d "$GSTACK_STATE_ROOT"/.setup-gbrain.lock.d ]; then
echo "Another /setup-gbrain instance is running. Wait for it, or remove $GSTACK_STATE_ROOT/.setup-gbrain.lock.d only if you are sure it is stale." >&2
else
@@ -734,6 +735,6 @@ invocation.
fi
```
Release the acquired lock on normal exit AND in the SIGINT trap.
Release it (`rm -rf`, not rmdir) on normal exit AND in the SIGINT trap.
- **CLAUDE.md is the audit trail.** Always update it in Step 8 after a
successful setup.