Merge remote-tracking branch 'origin/main' into cso-precision-incidental

This commit is contained in:
garrytan committed 2026-10-17 17:20:11 +00:00
commit be591da3e9
38 files changed
+2651 -1969

No files matched your search

+14
View File
@@ -77,10 +77,24 @@ console.log(` Queue (${claimed.length} open PRs claiming versions):`);
if (claimedList) console.log(claimedList);
console.log("::endgroup::");
// Dependabot never edits VERSION, so hard rule 1 would fail every dependency
// PR it opens. Exempt it only when the author is dependabot and every changed
// file is a dependency manifest, a lockfile or the dependabot config. The
// workflow passes the author and the file list; an empty list (the lookup
// failed) keeps the rule.
const DEPENDENCY_FILE = /(?:^|\/)(?:package\.json|bun\.lockb?)$|^\.github\/dependabot\.yml$/;
const changedFiles = (process.env.PR_CHANGED_FILES ?? "").split("\n").map((f) => f.trim()).filter(Boolean);
const dependabotManifestOnly =
process.env.PR_AUTHOR === "dependabot[bot]" && changedFiles.length > 0 && changedFiles.every((f) => DEPENDENCY_FILE.test(f));
// Hard rule 1: this PR's VERSION must be strictly greater than the base
// version, otherwise we're not actually bumping.
const pBase = parseV((parsed.base_version ?? "").trim());
if (pBase && cmp(pPR, pBase) <= 0) {
if (dependabotManifestOnly) {
console.log(`::notice::${tag} is a dependabot dependency update (${changedFiles.join(", ")}); VERSION bump not required.`);
process.exit(0);
}
console.log(`::error::VERSION not bumped: ${tag} claims v${prVersion} but base is v${parsed.base_version}.`);
process.exit(1);
}
File diff suppressed because it is too large. Load diff
File diff suppressed because it is too large. Load diff
+1 -2
View File
@@ -3,7 +3,6 @@
{"file": "test/host-conformance.test.ts", "reason": "real ./setup per host and layout; the time is setup's own skill-linking loop, not fixture copies (shared fixture landed in W6c)"},
{"file": "test/shared-libs-stage-actor.test.ts", "reason": "re-runs the paid shared-libs runner body against git fixture repos per test; owned by the paid-harness value-bar review"},
{"file": "test/setup-install-registry.test.ts", "reason": "82s in the 2026-10-15 recording (58s on 2026-10-04): 11 cases each run the real ./setup, gstack-relink, gstack-config and gstack-uninstall against throwaway checkouts", "todo": "split by describe block so the packer can balance it, then rerun bun run test:ubicloud --record-durations (TODOS.md, fix wave 2 follow-ups)"},
{"file": "test/host-renders-prune.test.ts", "reason": "64s in the 2026-10-15 recording (unseeded before): every case runs a real ./setup or the gstack-upgrade migration over host render dirs", "todo": "split by describe block so the packer can balance it, then rerun bun run test:ubicloud --record-durations (TODOS.md, fix wave 2 follow-ups)"},
{"file": "test/setup-codex-scope.test.ts", "reason": "60.4s in the 2026-10-15 recording (48s on 2026-10-04): Codex install scope through the real ./setup", "todo": "split by describe block so the packer can balance it, then rerun bun run test:ubicloud --record-durations (TODOS.md, fix wave 2 follow-ups)"}
{"file": "test/host-renders-prune.test.ts", "reason": "64s in the 2026-10-15 recording (unseeded before): every case runs a real ./setup or the gstack-upgrade migration over host render dirs", "todo": "split by describe block so the packer can balance it, then rerun bun run test:ubicloud --record-durations (TODOS.md, fix wave 2 follow-ups)"}
]
}
+11 -3
View File
@@ -1707,13 +1707,21 @@ export function exitCodeFor(status: FreeShardStatus): number {
return status === 'timed-out' ? 124 : 1;
}
/** Per-file deadline for `--record-durations`: an explicit --wall-timeout, else the one-file default. */
export function recordingWallTimeoutMs(options: Pick<CliOptions, 'wallTimeoutExplicit' | 'wallTimeoutMs'>): number {
return options.wallTimeoutExplicit ? options.wallTimeoutMs : wallTimeoutForShard(1);
}
/**
* `--record-durations`: time every file in its own child (exact per-file wall,
* immune to bun's stream buffering) and write the committed seed atomically.
* Uses the same isolated, strictly classified children as a normal run.
* Run against an immutable checkout; never time while editing its inputs.
* An explicit --wall-timeout sets the per-file deadline, so a file slower than
* the default deadline is timed in full instead of being killed and recorded
* at the deadline.
*/
async function recordFreeTestDurations(files: string[], jobs: number): Promise<number> {
async function recordFreeTestDurations(files: string[], jobs: number, wallTimeoutMs: number): Promise<number> {
const durations: Record<string, number> = {};
const failed: string[] = [];
const expectedCount = files.length;
@@ -1722,7 +1730,7 @@ async function recordFreeTestDurations(files: string[], jobs: number): Promise<n
// As in full-suite mode, finish parallel work before exclusive host-state fixtures.
await forEachFileAlone(files.filter(file => !(file in TREE_MUTATING)), files.filter(file => file in TREE_MUTATING), jobs, async (file, index) => {
const outcome = await runFreeShard([file], index + 1, files.length, {
wallTimeoutMs: wallTimeoutForShard(1), quiet: true, homeGuard: sharedFreeHome,
wallTimeoutMs, quiet: true, homeGuard: sharedFreeHome,
});
durations[normalizeRelativePath(file)] = outcome.elapsedMs;
if (outcome.status !== 'passed') failed.push(file);
@@ -1907,7 +1915,7 @@ async function main(): Promise<number> {
}
if (options.recordDurations) {
return recordFreeTestDurations(files, fullSuiteJobs());
return recordFreeTestDurations(files, fullSuiteJobs(), recordingWallTimeoutMs(options));
}
if (options.attributeHome) return attributeFreeHomeWriters(files.filter(file => !(file in TREE_MUTATING)), files.filter(file => file in TREE_MUTATING),
fullSuiteJobs(), (file, index, homeGuard) => runFreeShard([file], index + 1, files.length, { wallTimeoutMs: wallTimeoutForShard(1), quiet: true, log: () => {}, homeGuard }));
-18
View File
@@ -90,13 +90,7 @@
"test/ceo-count-ad-v2.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type '({ answered: boolean; answeredAt: string; answers: { ...; }; failed: boolean; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; sessionId: string; toolUseId: string; unansweredQuestionIndices: never[]; } | { ...; } | { ...; } | { ...; } | { ...' is not assignable to parameter of type 'NativePlanQuestionCall[]'. Type '({ answered: boolean; answeredAt: string; answers: { ...; }; failed: boolean; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; sessionId: string; toolUseId: string; unansweredQuestionIndices: never[]; } | { ...; } | { ...; } | { ...; } | { ...' is not assignable to type 'NativePlanQuestionCall[]'. Type '{ answered: boolean; answeredAt: string; answers: { ...; }; failed: boolean; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; sessionId: string; toolUseId: string; unansweredQuestionIndices: never[]; } | { ...; } | { ...; } | { ...; } | { ....' is not assignable to type 'NativePlanQuestionCall'. Type '{ sessionId: string; toolUseId: string; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; answered: boolean; failed: boolean; answers: { \"D0 \\u2014 Add gstack skill routing rules to this project's CLAUDE.md?\\nProject/branch/task: plan-count ...' is not assignable to type 'NativePlanQuestionCall'. Types of property 'answers' are incompatible. Type '{ \"D0 \\u2014 Add gstack skill routing rules to this project's CLAUDE.md?\\nProject/branch/task: plan-count fixture on main, reviewing PLAN.md (Stripe payment webhook handler) in HOLD SCOPE mode.\\nELI10: gstack works best when your project's CLAUDE.md includes skill routing rules, so future requests like \\\"review this...' is not assignable to type 'Record<string, string>'. Property '\"D1 \\u2014 Enable cross-project learnings search?\\nProject/branch/task: plan-count fixture on main, reviewing the Stripe payment webhook plan in HOLD SCOPE mode.\\nELI10: gstack can search learnings saved from your other projects on this machine to find patterns that might apply here. Everything stays local; no data leaves the machine. It helps solo developers most. Skip it if you work on multiple client codebases where mixing lessons between them would be a concern.\\nStakes if we pick wrong: Enabling on a multi-client machine could surface one client's quirks in another's review; disabling loses reusable patterns.\\nRecommendation: A because this is a local-only lookup and more prior context makes the review sharper.\\nNote: options differ in kind, not coverage \\u2014 no completeness score.\\nNet: broader recall versus strict per-project isolation.\"' is incompatible with index signature. Type 'undefined' is not assignable to type 'string'.": 1,
"test/ceo-expansion-auq.test.ts\tTS2339\tProperty 'is_error' does not exist on type '{ text: string; type: string; } | { caller: { ...; }; id: string; input: { questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; }; name: string; type: string; } | { ...; } | { ...; }'. Property 'is_error' does not exist on type '{ text: string; type: string; }'.": 1,
"test/ceo-expansion-auq.test.ts\tTS7053\tElement implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ toolu_014Q5SA47BqSvstMA1QpQzds: { reply: string; request: string; }; toolu_01GSNy9VjrqLscsjp6sceiV2: { reply: string; request: string; }; }'. No index signature with a parameter of type 'string' was found on type '{ toolu_014Q5SA47BqSvstMA1QpQzds: { reply: string; request: string; }; toolu_01GSNy9VjrqLscsjp6sceiV2: { reply: string; request: string; }; }'.": 5,
"test/ceo-finding-fixture.test.ts\tTS2322\tType 'string | number | string[]' is not assignable to type 'string'. Type 'number' is not assignable to type 'string'.": 1,
"test/ceo-finding-fixture.test.ts\tTS2339\tProperty 'map' does not exist on type 'string | number | string[] | readonly [\"Run /office-hours first\", \"\\\"Skip — standard review\\\"\"] | readonly [\"Run /office-hours first\", \"Skip\"] | readonly [\"Run /office-hours first\", \"Skip security review\"] | ... 4 more ... | readonly [...]'. Property 'map' does not exist on type 'string'.": 1,
"test/ceo-finding-fixture.test.ts\tTS2345\tArgument of type '(question: string | number | string[], labels: string | number | string[] | readonly [\"Run /office-hours first\", \"\\\"Skip — standard review\\\"\"] | readonly [\"Run /office-hours first\", \"Skip\"] | readonly [\"Run /office-hours first\", \"Skip security review\"] | ... 4 more ... | readonly [...], expected: string | ... 1 mo...' is not assignable to parameter of type '(...args: (string | number | string[])[] | [\"D1 — Discuss /office-hours in our documentation?\", string[], 1] | [\"D1 — No design doc found: run /office-hours before the review?\", readonly [...], 2] | ... 8 more ... | [...]) => void | Promise<...>'. Types of parameters 'question' and 'args' are incompatible. Type '(string | number | string[])[] | [\"D1 — Discuss /office-hours in our documentation?\", string[], 1] | [\"D1 — No design doc found: run /office-hours before the review?\", readonly [...], 2] | ... 8 more ... | [...]' is not assignable to type '[question: string | number | string[], labels: string | number | string[] | readonly [\"Run /office-hours first\", \"\\\"Skip — standard review\\\"\"] | readonly [\"Run /office-hours first\", \"Skip\"] | readonly [\"Run /office-hours first\", \"Skip security review\"] | ... 4 more ... | readonly [...], expected: string | ... 1 mo...'. Type '(string | number | string[])[]' is not assignable to type '[question: string | number | string[], labels: string | number | string[] | readonly [\"Run /office-hours first\", \"\\\"Skip — standard review\\\"\"] | readonly [\"Run /office-hours first\", \"Skip\"] | readonly [\"Run /office-hours first\", \"Skip security review\"] | ... 4 more ... | readonly [...], expected: string | ... 1 mo...'. Target requires 3 element(s) but source may have fewer.": 1,
"test/ceo-finding-fixture.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type 'string | number | string[]' is not assignable to parameter of type 'number'. Type 'string' is not assignable to type 'number'.": 1,
"test/ceo-finding-fixture.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type '{ kind: \"committed\" | \"failed\" | \"forbidden\" | \"unregistered-event\"; status: 200 | 403 | 503; }' is not assignable to parameter of type 'RequestOutcome'. Type '{ kind: \"committed\" | \"failed\" | \"forbidden\" | \"unregistered-event\"; status: 200 | 403 | 503; }' is not assignable to type '{ kind: \"failed\" | \"unregistered-event\"; status: 503; }'. Types of property 'status' are incompatible. Type '200 | 403 | 503' is not assignable to type '503'. Type '200' is not assignable to type '503'.": 1,
"test/ceo-finding-fixture.test.ts\tTS7006\tParameter 'i' implicitly has an 'any' type.": 1,
"test/ceo-finding-fixture.test.ts\tTS7006\tParameter 'label' implicitly has an 'any' type.": 1,
"test/ceo-hold-posture-review.test.ts\tTS2339\tProperty 'filePath' does not exist on type '{}'.": 4,
"test/ceo-hold-posture-review.test.ts\tTS2339\tProperty 'questions' does not exist on type 'AskUserQuestionFingerprint'.": 4,
"test/ceo-hold-posture-review.test.ts\tTS2339\tProperty 'selectedOptions' does not exist on type 'AskUserQuestionFingerprint'.": 1,
@@ -140,8 +134,6 @@
"test/cso-ntfs-fixture.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type 'bigint | undefined' is not assignable to parameter of type 'bigint'. Type 'undefined' is not assignable to type 'bigint'.": 1,
"test/cso-preparation-executor.test.ts\tTS2339\tProperty 'sidecar' does not exist on type 'PreparedDatabaseContract'. Property 'sidecar' does not exist on type '{ adapter: \"sqlite\"; connections: string[]; }'.": 1,
"test/cso-public-ghcr.test.ts\tTS2352\tConversion of type '() => Promise<Response>' to type 'typeof fetch' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first. Property 'preconnect' is missing in type '() => Promise<Response>' but required in type 'typeof fetch'.": 1,
"test/cso-scanner-executor.test.ts\tTS2345\tArgument of type 'unknown' is not assignable to parameter of type '\"gitleaks\" | \"osv\" | \"schemathesis\" | \"semgrep\" | \"trivy\" | \"zizmor\"'.": 9,
"test/cso-scanner-executor.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. The type 'readonly [\"gitleaks\", \"osv\", \"semgrep\", \"zizmor\", \"trivy\", \"schemathesis\"]' is 'readonly' and cannot be assigned to the mutable type 'unknown[]'.": 2,
"test/design-catalog.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type 'string' is not assignable to parameter of type '\"quality\" | \"slop\"'.": 1,
"test/design-completion-handoff-scored.test.ts\tTS2352\tConversion of type '({ answered: boolean; answeredAt: string; answers: { ...; }; failed: boolean; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; sessionId: string; toolUseId: string; unansweredQuestionIndices: never[]; } | ... 10 more ... | { ...; })[]' to type 'NativePlanQuestionCall[]' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first. Type '{ answered: boolean; answeredAt: string; answers: { ...; }; failed: boolean; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; sessionId: string; toolUseId: string; unansweredQuestionIndices: never[]; } | ... 10 more ... | { ...; }' is not comparable to type 'NativePlanQuestionCall'. Type '{ sessionId: string; toolUseId: string; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; answered: boolean; failed: boolean; answers: { \"Pass 1 (Info Architecture) \\u2014 7/10. The plan has DOM order and heading structure, but no scan path ...' is not comparable to type 'NativePlanQuestionCall'. Types of property 'answers' are incompatible. Type '{ \"Pass 1 (Info Architecture) \\u2014 7/10. The plan has DOM order and heading structure, but no scan path specification: what does the user's eye land on first, second, third? The Visual Hierarchy gap identifies that Save is indistinguishable from other buttons, but names it as a styling problem rather than an IA pr...' is not comparable to type 'Record<string, string>'. Property '\"Pass 1 (Info Architecture) \\u2014 7/10. The plan has DOM order and heading structure, but no scan path specification: what does the user's eye land on first, second, third? The Visual Hierarchy gap identifies that Save is indistinguishable from other buttons, but names it as a styling problem rather than an IA problem \\u2014 the primary action is missing from the visual hierarchy. Should I add a scan path description to the plan? <gstack-qid:plan-design-review-ia-scan-path>\"' is incompatible with index signature. Type 'undefined' is not comparable to type 'string'.": 1,
"test/design-completion-handoff-scored.test.ts\tTS2352\tConversion of type '({ answered: boolean; answeredAt: string; answers: { ...; }; failed: boolean; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; sessionId: string; toolUseId: string; unansweredQuestionIndices: never[]; } | ... 4 more ... | { ...; })[]' to type 'NativePlanQuestionCall[]' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first. Type '{ answered: boolean; answeredAt: string; answers: { ...; }; failed: boolean; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; sessionId: string; toolUseId: string; unansweredQuestionIndices: never[]; } | ... 4 more ... | { ...; }' is not comparable to type 'NativePlanQuestionCall'. Type '{ sessionId: string; toolUseId: string; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; answered: boolean; failed: boolean; answers: { \"Pass 1 \\u2014 Visual Hierarchy: The plan lists this gap but has no fix. The Save button renders with th...' is not comparable to type 'NativePlanQuestionCall'. Types of property 'answers' are incompatible. Type '{ \"Pass 1 \\u2014 Visual Hierarchy: The plan lists this gap but has no fix. The Save button renders with the same size, weight, and color as Reset, Cancel, and Export. DESIGN.md already specifies the remedy: Save gets #1d4ed8 fill with white text; the other three are ghost neutral buttons. Should I add this fix speci...' is not comparable to type 'Record<string, string>'. Property '\"Pass 1 \\u2014 Visual Hierarchy: The plan lists this gap but has no fix. The Save button renders with the same size, weight, and color as Reset, Cancel, and Export. DESIGN.md already specifies the remedy: Save gets #1d4ed8 fill with white text; the other three are ghost neutral buttons. Should I add this fix specification to the plan? <gstack-qid:plan-design-review-gap1-visual-hierarchy>\"' is incompatible with index signature. Type 'undefined' is not comparable to type 'string'.": 1,
@@ -258,10 +250,6 @@
"test/helpers/shared-libs-path-fixture.ts\tTS2352\tConversion of type '{ env: { GSTACK_HOME: string; }; repo: string; root: string; state: string; }' to type 'SharedLibsFixture' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first. Type '{ env: { GSTACK_HOME: string; }; repo: string; root: string; state: string; }' is missing the following properties from type 'SharedLibsFixture': bin, trace, hookTrace, tip": 1,
"test/helpers/shared-libs-plan-actor.ts\tTS18046\t'questions' is of type 'unknown'.": 1,
"test/impeccable-fixtures.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type 'string | undefined' is not assignable to parameter of type 'string'. Type 'undefined' is not assignable to type 'string'.": 1,
"test/llm-judge-abort.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type '{ passed: boolean; }' is not assignable to parameter of type 'undefined'.": 3,
"test/llm-judge-frontier.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type '{ reason: string; score: number; }' is not assignable to parameter of type 'undefined'.": 1,
"test/llm-judge-frontier.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type '{ score: number; }' is not assignable to parameter of type 'undefined'.": 3,
"test/llm-judge-stream.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type '{ actionability: number; clarity: number; completeness: number; reasoning: string; }' is not assignable to parameter of type 'undefined'.": 1,
"test/model-overlays.test.ts\tTS2322\tType 'string' is not assignable to type '\"claude\" | \"fable-5\" | \"gemini\" | \"gpt\" | \"gpt-5.4\" | \"gpt-5.6-sol\" | \"gpt-6-astra\" | \"o-series\" | \"opus-4-7\" | \"opus-4-8\" | \"sonnet-5\" | undefined'.": 4,
"test/native-auto-decide-pty.test.ts\tTS2345\tArgument of type 'string | undefined' is not assignable to parameter of type 'string'. Type 'undefined' is not assignable to type 'string'.": 1,
"test/native-auto-decide.test.ts\tTS2345\tArgument of type '{ assistantMessages: { sessionId: string; text: string; timestamp: string; }[]; calls: never[]; status: string; }' is not assignable to parameter of type 'PlanCountTranscript'. Types of property 'status' are incompatible. Type 'string' is not assignable to type '\"error\" | \"missing\" | \"ready\"'.": 1,
@@ -423,8 +411,6 @@
"test/pty-workspace-trust.test.ts\tTS2345\tArgument of type '(_command: any, options: any) => any' is not assignable to parameter of type '{ <const In extends SpawnOptions.Writable = \"ignore\", const Out extends SpawnOptions.Readable = \"pipe\", const Err extends SpawnOptions.Readable = \"inherit\">(options: SpawnOptions<In, Out, Err> & { cmd: string[]; }): Subprocess<...>; <const In extends SpawnOptions.Writable = \"ignore\", const Out extends SpawnOptions.R...'. Target signature provides too few arguments. Expected 2 or more, but got 1.": 1,
"test/pty-workspace-trust.test.ts\tTS2559\tType '5000' has no properties in common with type '{ pollMs?: number | undefined; since?: number | undefined; timeoutMs?: number | undefined; }'.": 1,
"test/qa-browser-preservation.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type 'number | null' is not assignable to parameter of type 'number'. Type 'null' is not assignable to type 'number'.": 1,
"test/qa-exploratory-callers.test.ts\tTS2345\tArgument of type 'unknown' is not assignable to parameter of type '\"review-exploratory-small-cli\" | \"ship-exploratory-late-input\" | \"ship-exploratory-plan-checks\" | \"ship-exploratory-small-cli\" | \"ship-exploratory-unavailable\"'.": 1,
"test/qa-exploratory-callers.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. The type 'readonly [\"review-exploratory-small-cli\", \"ship-exploratory-small-cli\", \"ship-exploratory-unavailable\", \"ship-exploratory-plan-checks\", \"ship-exploratory-late-input\"]' is 'readonly' and cannot be assigned to the mutable type 'unknown[]'.": 1,
"test/qa-functional-fixture.test.ts\tTS7006\tParameter 'request' implicitly has an 'any' type.": 2,
"test/qa-functional-prompt.test.ts\tTS18046\t'capture' is of type 'unknown'.": 4,
"test/qa-functional-prompt.test.ts\tTS7006\tParameter 'block' implicitly has an 'any' type.": 2,
@@ -437,9 +423,7 @@
"test/review-count-markdown.test.ts\tTS2352\tConversion of type '({ answered: boolean; answeredAt: string; answers: { ...; }; failed: boolean; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; sessionId: string; toolUseId: string; unansweredQuestionIndices: never[]; } | { ...; } | { ...; } | { ...; } | { ...' to type 'NativePlanQuestionCall[]' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first. Type '({ answered: boolean; answeredAt: string; answers: { ...; }; failed: boolean; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; sessionId: string; toolUseId: string; unansweredQuestionIndices: never[]; } | ... 7 more ... | { ...; })[]' is not comparable to type 'NativePlanQuestionCall[]'. Type '{ answered: boolean; answeredAt: string; answers: { ...; }; failed: boolean; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; sessionId: string; toolUseId: string; unansweredQuestionIndices: never[]; } | ... 7 more ... | { ...; }' is not comparable to type 'NativePlanQuestionCall'. Type '{ sessionId: string; toolUseId: string; questions: { header: string; multiSelect: boolean; options: { description: string; label: string; }[]; question: string; }[]; answered: boolean; failed: boolean; answers: { \"D1 \\u2014 Add gstack skill routing rules to this project's CLAUDE.md?\\nProject/branch/task: plan-count ...' is not comparable to type 'NativePlanQuestionCall'. Types of property 'answers' are incompatible. Type '{ \"D1 \\u2014 Add gstack skill routing rules to this project's CLAUDE.md?\\nProject/branch/task: plan-count fixture on main, running /plan-design-review on PLAN.md.\\nELI10: gstack skills work best when the project's CLAUDE.md tells the assistant which slash command to reach for (bugs \\u2192 /investigate, design plan \\...' is not comparable to type 'Record<string, string>'. Property '\"D1 \\u2014 Add gstack skill routing rules to this project's CLAUDE.md?\\nProject/branch/task: plan-count fixture on main, running /plan-design-review on PLAN.md.\\nELI10: gstack skills work best when the project's CLAUDE.md tells the assistant which slash command to reach for (bugs \\u2192 /investigate, design plan \\u2192 /plan-design-review, and so on). Without it you invoke skills by hand each time. This is a one-time prompt per project.\\nStakes if we pick wrong: pick A and CLAUDE.md gains a short section you may not want in a fixture repo; pick B and skills are never suggested automatically here.\\nRecommendation: A because routing rules cost one short section and save repeated manual invocations.\\nNote: options differ in kind, not coverage \\u2014 no completeness score.\\nNet: convenience of auto-routing vs keeping the fixture CLAUDE.md untouched. Note: plan mode is active, so if you pick A the CLAUDE.md edit and commit happen after we leave plan mode.\"' is incompatible with index signature. Type 'undefined' is not comparable to type 'string'.": 1,
"test/salience-allowlist.test.ts\tTS2307\tCannot find module '../bin/gstack-brain-cache' or its corresponding type declarations.": 3,
"test/schema-version-migration.test.ts\tTS2307\tCannot find module '../bin/gstack-brain-cache' or its corresponding type declarations.": 3,
"test/schema-version-migration.test.ts\tTS2353\tObject literal may only specify known properties, and 'timeout' does not exist in type '(done: (err?: unknown) => void) => void | Promise<unknown>'.": 3,
"test/section-capture-native-tools.test.ts\tTS2339\tProperty 'CI' does not exist on type '{ NODE_ENV?: string | undefined; PATH: string; TZ?: string | undefined; }'.": 1,
"test/session-runner-browse-errors.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type 'never[]' is not assignable to parameter of type 'undefined'.": 1,
"test/session-runner-browse-errors.test.ts\tTS7006\tParameter 'row' implicitly has an 'any' type.": 6,
"test/setup-gbrain-path4-caller.test.ts\tTS2339\tProperty 'diagnostic-secret' does not exist on type '{ 'no-init': number; 'no-install': number; 'no-registration': number; 'no-verifier': number; }'.": 1,
"test/setup-gbrain-path4-caller.test.ts\tTS2339\tProperty 'exit' does not exist on type '{ 'no-init': number; 'no-install': number; 'no-registration': number; 'no-verifier': number; }'.": 1,
@@ -453,12 +437,10 @@
"test/setup-gbrain-path4-caller.test.ts\tTS2339\tProperty 'wrong-engine' does not exist on type '{ 'no-init': number; 'no-install': number; 'no-registration': number; 'no-verifier': number; }'.": 1,
"test/setup-gbrain-remote-caller.test.ts\tTS18048\t'lateDecision' is possibly 'undefined'.": 1,
"test/shared-libs-checker-interface-evidence.test.ts\tTS18048\t'current' is possibly 'undefined'.": 1,
"test/shared-libs-checker-interface-evidence.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. The type 'readonly [\"symlinks\", \"submodule\", \"ignored\", \"legacy\", \"assume-unchanged\", \"skip-worktree\", \"removed-filter\"]' is 'readonly' and cannot be assigned to the mutable type 'unknown[]'.": 2,
"test/shared-libs-fixture.test.ts\tTS18046\t'packet' is of type 'unknown'.": 4,
"test/shared-libs-fixture.test.ts\tTS2345\tArgument of type '(options: { label: string; } | { description: string; label: string; } | { description: string; label: string; }) => Promise<void>' is not assignable to parameter of type '(...args: [{ label: string; } | { description: string; label: string; } | { description: string; label: string; }, done: (err?: unknown) => void] | [{ label: string; } | { description: string; label: string; } | { ...; }, { ...; } | undefined, done: (err?: unknown) => void]) => void | Promise<...>'. Types of parameters 'options' and 'args' are incompatible. Type '[{ label: string; } | { description: string; label: string; } | { description: string; label: string; }, done: (err?: unknown) => void] | [{ label: string; } | { description: string; label: string; } | { description: string; label: string; }, { ...; } | undefined, done: (err?: unknown) => void]' is not assignable to type '[options: { label: string; } | { description: string; label: string; } | { description: string; label: string; }]'. Type '[{ label: string; } | { description: string; label: string; } | { description: string; label: string; }, done: (err?: unknown) => void]' is not assignable to type '[options: { label: string; } | { description: string; label: string; } | { description: string; label: string; }]'. Source has 2 element(s) but target allows only 1.": 1,
"test/shared-libs-fixture.test.ts\tTS2345\tArgument of type '(options: { label: string; } | { description: string; label: string; } | { label: string; preview: string; } | { description: string; label: string; preview: string; } | { label: string; } | { description: string; label: string; } | { ...; }) => Promise<...>' is not assignable to parameter of type '(...args: [{ label: string; } | { description: string; label: string; } | { label: string; preview: string; } | { description: string; label: string; preview: string; } | { label: string; } | { description: string; label: string; } | { ...; }, done: (err?: unknown) => void] | [...]) => void | Promise<...>'. Types of parameters 'options' and 'args' are incompatible. Type '[{ label: string; } | { description: string; label: string; } | { label: string; preview: string; } | { description: string; label: string; preview: string; } | { label: string; } | { description: string; label: string; } | { ...; }, done: (err?: unknown) => void] | [...]' is not assignable to type '[options: { label: string; } | { description: string; label: string; } | { label: string; preview: string; } | { description: string; label: string; preview: string; } | { label: string; } | { description: string; label: string; } | { ...; }]'. Type '[{ label: string; } | { description: string; label: string; } | { label: string; preview: string; } | { description: string; label: string; preview: string; } | { label: string; } | { description: string; label: string; } | { ...; }, done: (err?: unknown) => void]' is not assignable to type '[options: { label: string; } | { description: string; label: string; } | { label: string; preview: string; } | { description: string; label: string; preview: string; } | { label: string; } | { description: string; label: string; } | { ...; }]'. Source has 2 element(s) but target allows only 1.": 1,
"test/shared-libs-fixture.test.ts\tTS2345\tArgument of type '({ input }: { input: any; }) => Promise<void>' is not assignable to parameter of type '(args_0: unknown, ...args: unknown[]) => void | Promise<unknown>'. Types of parameters '__0' and 'args_0' are incompatible. Type 'unknown' is not assignable to type '{ input: any; }'.": 1,
"test/shared-libs-fixture.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type 'readonly [\"Skip\", \"Keep current\", \"Decline\", \"Do not change\", \"Leave as-is\"] | readonly [\"Fix it\", \"Apply remedy\", \"Approve\", \"Extract helper\", \"Reuse library\", \"Choice (recommended)\"]' is not assignable to parameter of type 'unknown[]'. The type 'readonly [\"Skip\", \"Keep current\", \"Decline\", \"Do not change\", \"Leave as-is\"]' is 'readonly' and cannot be assigned to the mutable type 'unknown[]'.": 1,
"test/shared-libs-fixture.test.ts\tTS7053\tElement implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ \"Pre-Landing Review: 0 issues (0 critical, 0 informational). 1 [ADVISORY] needs your input:\\n\\n1. [ADVISORY] src/retry-worker.ts:2 \\u2014 Duplicated `retrySeconds` parser (shared-libs, confidence 9/10, maintainability + core)\\n Both src/retry-worker.ts:2-15 (this diff) and src/retry-route.ts:2-15 are verbatim co...'. No index signature with a parameter of type 'string' was found on type '{ \"Pre-Landing Review: 0 issues (0 critical, 0 informational). 1 [ADVISORY] needs your input:\\n\\n1. [ADVISORY] src/retry-worker.ts:2 \\u2014 Duplicated `retrySeconds` parser (shared-libs, confidence 9/10, maintainability + core)\\n Both src/retry-worker.ts:2-15 (this diff) and src/retry-route.ts:2-15 are verbatim co...'.": 1,
"test/shared-libs-review-start-evidence.test.ts\tTS2345\tArgument of type 'unknown' is not assignable to parameter of type 'number | undefined'.": 1,
"test/shared-libs-stage-actor.test.ts\tTS2769\tNo overload matches this call. The last overload gave the following error. Argument of type 'string | undefined' is not assignable to parameter of type 'string'. Type 'undefined' is not assignable to type 'string'.": 1,