mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-04 10:26:52 +02:00
test: attribute quoted prior-record field lists, state the judge reason bound in its schema, move split-overflow to marathon
Census 36629958451 reds: - outside-plan-disabled-no-fallback: the model quoted the pre-existing record as a parenthesized field list with its exact timestamp; attribution now requires that exact timestamp and the record's own field values. - plan-devex-peer-comparison-classification: the judge correctly returned missing but wrote a 1069-character reason, voiding the judgment; structured outputs cannot enforce maxLength, so the bound is stated on the field. - plan-ceo-split-overflow ran 504-1188 s as one PTY flow and set the periodic lane's wall clock; it now runs weekly in the marathon lane.
This commit is contained in:
1 parent
f63e1fb7cb
commit
bf4667146c
6 files changed
+52
-8
No files matched your search
@@ -54,6 +54,9 @@ export interface PlanReviewDecisionJudgment {
|
||||
engReview?: EngReviewJudgment;
|
||||
}
|
||||
export type PlanReviewJudge = (prompt: string, model?: string, opts?: Pick<CallJudgeOptions, 'signal' | 'max_tokens' | 'jsonSchema'>) => Promise<unknown>;
|
||||
// Structured outputs cannot enforce maxLength, so the reason bound the local
|
||||
// validator applies is stated on the field the model writes.
|
||||
const REASON_FIELD = { type: 'string', description: '1-1000 characters: under 120 words.' } as const;
|
||||
// Only response structure is constrained. Identity, exact quotes, enum casing,
|
||||
// uncertainty, target coverage, independence and count checks remain local.
|
||||
function planReviewDecisionSchema(withPeerComparison: boolean, withEngReview = false): NonNullable<CallJudgeOptions['jsonSchema']> {
|
||||
@@ -68,7 +71,7 @@ function planReviewDecisionSchema(withPeerComparison: boolean, withEngReview = f
|
||||
toolUseId: { type: 'string' }, questionIndex: { type: 'integer' },
|
||||
kind: { type: 'string', enum: ['finding', 'scope', 'workflow', 'backlog', 'uncertain'] },
|
||||
targetIds: { type: 'array', items: { type: 'string' } },
|
||||
independentDecisions: { type: 'integer' }, reason: { type: 'string' },
|
||||
independentDecisions: { type: 'integer' }, reason: REASON_FIELD,
|
||||
evidence: { type: 'array', items: {
|
||||
type: 'object', additionalProperties: false, required: ['field', 'optionIndex', 'quote'],
|
||||
properties: {
|
||||
@@ -86,7 +89,7 @@ function planReviewDecisionSchema(withPeerComparison: boolean, withEngReview = f
|
||||
type: 'object', additionalProperties: false,
|
||||
required: ['status', 'regression', 'approvals', 'navigation', 'reason'],
|
||||
properties: {
|
||||
status: { type: 'string', enum: ['complete', 'missing', 'uncertain'] }, reason: { type: 'string' },
|
||||
status: { type: 'string', enum: ['complete', 'missing', 'uncertain'] }, reason: REASON_FIELD,
|
||||
regression: { type: 'array', items: { type: 'object', additionalProperties: false,
|
||||
required: ['role', 'source', 'quote'], properties: {
|
||||
role: { type: 'string', enum: ['critical', 'baseline', 'replay', 'assertions', 'approved-differences'] },
|
||||
@@ -112,7 +115,7 @@ function planReviewDecisionSchema(withPeerComparison: boolean, withEngReview = f
|
||||
properties: { name: { type: 'string' }, quote: { type: 'string' } },
|
||||
} },
|
||||
productQuote: { type: 'string' }, groundingQuote: { type: 'string' },
|
||||
implicationQuote: { type: 'string' }, reason: { type: 'string' },
|
||||
implicationQuote: { type: 'string' }, reason: REASON_FIELD,
|
||||
},
|
||||
} } : {}),
|
||||
},
|
||||
|
||||
Reference in new issue
Block a user