CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-05-07 05:56:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat: feature discovery flow gated by per-feature markers

Browse Source 
Extends generateUpgradeCheck() to surface new features once per user
after a just-upgraded session. No more silent features.

Codex review caught: spawned sessions (OpenClaw, etc.) must skip the
discovery prompt entirely — they can't interactively answer. Feature
discovery now checks SPAWNED_SESSION first and is silent in those.

Discovery is per-feature, not per-upgrade. Each feature has its own
marker file at ~/.claude/skills/gstack/.feature-prompted-{name}. Once
the user has been shown a feature (accepted, shown docs, or skipped),
the marker is touched and the prompt never fires again for that
feature. Future features get their own markers.

V1 features surfaced:
- continuous-checkpoint: offer to enable checkpoint_mode=continuous
- model-overlay: inform-only note about --model flag and MODEL_OVERLAY
  line in preamble output

Max one prompt per session to avoid nagging. Fires only on JUST_UPGRADED
(not every session), plus spawned-session skip.

Changes:
- scripts/resolvers/preamble.ts: extend generateUpgradeCheck() with
  feature discovery rules, per-marker-file semantics, spawned-session
  exclusion, and max-one-per-session cap.
- All skill SKILL.md files regenerated to include the new section.
- Golden ship fixtures regenerated.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-04-17 06:06:57 +08:00
parent fe34349966
commit c1d6fd8706
36 changed files with 1152 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
setup-deploy/SKILL.md
+32 -1
View File
@@ -114,7 +114,38 @@ or invoking other gstack skills, use the `/gstack-` prefix (e.g., `/gstack-qa` i
of `/qa`, `/gstack-ship` instead of `/ship`). Disk paths are unaffected — always use
`~/.claude/skills/gstack/[skill-name]/SKILL.md` for reading skill files.
If output shows `UPGRADE_AVAILABLE <old> <new>`: read `~/.claude/skills/gstack/gstack-upgrade/SKILL.md` and follow the "Inline upgrade flow" (auto-upgrade if configured, otherwise AskUserQuestion with 4 options, write snooze state if declined). If `JUST_UPGRADED <from> <to>`: tell user "Running gstack v{to} (just updated!)" and continue.
If output shows `UPGRADE_AVAILABLE <old> <new>`: read `~/.claude/skills/gstack/gstack-upgrade/SKILL.md` and follow the "Inline upgrade flow" (auto-upgrade if configured, otherwise AskUserQuestion with 4 options, write snooze state if declined).
If output shows `JUST_UPGRADED <from> <to>` AND `SPAWNED_SESSION` is NOT set: tell
the user "Running gstack v{to} (just updated!)" and then check for new features to
surface. For each per-feature marker below, if the marker file is missing AND the
feature is plausibly useful for this user, use AskUserQuestion to let them try it.
Fire once per feature per user, NOT once per upgrade.
**In spawned sessions (`SPAWNED_SESSION` = "true"): SKIP feature discovery entirely.**
Just print "Running gstack v{to}" and continue. Orchestrators do not want interactive
prompts from sub-sessions.
**Feature discovery markers and prompts** (one at a time, max one per session):
1. `~/.claude/skills/gstack/.feature-prompted-continuous-checkpoint` →
Prompt: "Continuous checkpoint auto-commits your work as you go with `WIP:` prefix
so you never lose progress to a crash. Local-only by default — doesn't push
anywhere unless you turn that on. Want to try it?"
Options: A) Enable continuous mode, B) Show me first (print the section from
the preamble Continuous Checkpoint Mode), C) Skip.
If A: run `~/.claude/skills/gstack/bin/gstack-config set checkpoint_mode continuous`.
Always: `touch ~/.claude/skills/gstack/.feature-prompted-continuous-checkpoint`
2. `~/.claude/skills/gstack/.feature-prompted-model-overlay` →
Inform only (no prompt): "Model overlays are active. `MODEL_OVERLAY: {model}`
shown in the preamble output tells you which behavioral patch is applied.
Override with `--model` when regenerating skills (e.g., `bun run gen:skill-docs
--model gpt-5.4`). Default is claude."
Always: `touch ~/.claude/skills/gstack/.feature-prompted-model-overlay`
After handling JUST_UPGRADED (prompts done or skipped), continue with the skill
workflow.
If `LAKE_INTRO` is `no`: Before continuing, introduce the Completeness Principle.
Tell the user: "gstack follows the **Boil the Lake** principle — always do the complete