From c7a24ec9c1c0314ed55eefc29cd1bf0fc1344ecf Mon Sep 17 00:00:00 2001 From: garrytan Date: Sat, 3 Oct 2026 22:31:38 +0000 Subject: [PATCH] I3: plan-eng-review states when findings first enter the report and that the scope menu's recommendation needs no repo probe Judge rationales for 'plan-eng-review/SKILL.md sections' (actionability 3.67 in periodic run 37151477069, clarity 3 in 36385945043 and 35567915613) cite two concrete tensions: 'do not add findings before Scope Challenge C' versus the ledger saves C itself performs, and 'Recommendation: A when a branch diff exists' versus 'do not probe for session state'. The write policy now says findings first enter through Scope Challenge C's ledger saves; the selector says its Recommendation line advises the user and needs no repository inspection. The pinned sentence becomes the new meaning-level regex. --- plan-eng-review/SKILL.md.tmpl | 2 +- plan-eng-review/sections/review-sections.md.tmpl | 4 ++-- test/plan-review-cases.test.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plan-eng-review/SKILL.md.tmpl b/plan-eng-review/SKILL.md.tmpl index 6e0391efc..0f0d612d1 100644 --- a/plan-eng-review/SKILL.md.tmpl +++ b/plan-eng-review/SKILL.md.tmpl @@ -48,7 +48,7 @@ Name the selected plan by its title or path; use "this draft" only for an untitl When no exception above applied: -1. Choose listed, enabled MCP AskUserQuestion, otherwise listed native. First tool call = AskUserQuestion (tool_use). Send this exact menu and wait. +1. Choose listed, enabled MCP AskUserQuestion, otherwise listed native. First tool call = AskUserQuestion (tool_use). Send this exact menu and wait; its Recommendation line advises the user, so do not inspect the repository to resolve it. 2. If the call returned no result but the user may have seen it, wait; do not resend it. If the tool is unavailable, disallowed (`--disallowedTools`) or failed before reaching the user, send the menu as plain prose and STOP, whatever the session type; the session type never chooses a target or approves work. Options start at column 0, without blockquotes. Never guess a target. What should I review? diff --git a/plan-eng-review/sections/review-sections.md.tmpl b/plan-eng-review/sections/review-sections.md.tmpl index a10408559..c6e424648 100644 --- a/plan-eng-review/sections/review-sections.md.tmpl +++ b/plan-eng-review/sections/review-sections.md.tmpl @@ -49,8 +49,8 @@ QA Test Plan/task JSONL keep discovery paths `$GSTACK_STATE_ROOT/projects/{slug} existing destination and preserve its content. For a new file, create permitted parent directories, then write that header, an unchanged copy of the original plan (for plan targets), and the scope record or ledger being saved. Recheck option 3's collision before -creation; use a suffix rather than overwrite. Do not add findings or fixes before -Scope Challenge C. Put records before an existing `## GSTACK REVIEW REPORT`, or +creation; use a suffix rather than overwrite. Findings and fixes first enter +through Scope Challenge C's ledger saves, never earlier. Put records before an existing `## GSTACK REVIEW REPORT`, or at EOF if absent; create that terminal report only at Plan File Review Report. **Write routes.** A forbidden write follows its row above. diff --git a/test/plan-review-cases.test.ts b/test/plan-review-cases.test.ts index 580e1aff9..199294b9f 100644 --- a/test/plan-review-cases.test.ts +++ b/test/plan-review-cases.test.ts @@ -48,7 +48,7 @@ describe('CI workflow clarity regressions', () => { const requirements = [ /name the fixed target in the report header/i, /read an existing destination and preserve its content/i, - /do not add findings or fixes before Scope Challenge C/i, + /findings and fixes first enter through Scope Challenge C's ledger saves, never earlier/i, /before an existing `## GSTACK REVIEW REPORT`, or at EOF/i, /create that terminal report only at Plan File Review Report/i, ];