From c8d87289b1257c00f7e32bdca0bb48ebdd231abb Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Thu, 23 Apr 2026 17:48:30 -0700 Subject: [PATCH] test: regenerate golden fixtures + update ELI10 phrase check for v1.7.0.0 Pros/Cons format rewrite (6b99df9d) changed the resolver output across all tier-2+ SKILL.md files. Three golden-file regression tests in test/host-config.test.ts and one phrase-check test in test/gen-skill-docs.test.ts were failing as expected. - test/fixtures/golden/claude-ship-SKILL.md - test/fixtures/golden/codex-ship-SKILL.md - test/fixtures/golden/factory-ship-SKILL.md Regenerated via `bun run gen:skill-docs --host all` + cp into fixtures. - test/gen-skill-docs.test.ts line 244: rename test from "ELI16 simplification rules" to "ELI10 simplification rules" and match the new phrase pattern. v1.7.0.0 uses "ELI10 (ALWAYS)" rather than legacy "Simplify (ELI10, ALWAYS)". bun test: 744 pass, 1 fail (pre-existing security-bench fixture oversize, unrelated to this branch). Co-Authored-By: Claude Opus 4.7 (1M context) --- test/fixtures/golden/claude-ship-SKILL.md | 143 +++++++++++++++++++-- test/fixtures/golden/codex-ship-SKILL.md | 143 +++++++++++++++++++-- test/fixtures/golden/factory-ship-SKILL.md | 143 +++++++++++++++++++-- test/gen-skill-docs.test.ts | 5 +- 4 files changed, 390 insertions(+), 44 deletions(-) diff --git a/test/fixtures/golden/claude-ship-SKILL.md b/test/fixtures/golden/claude-ship-SKILL.md index e56262ed..a8f5e5a4 100644 --- a/test/fixtures/golden/claude-ship-SKILL.md +++ b/test/fixtures/golden/claude-ship-SKILL.md @@ -355,6 +355,135 @@ AI orchestrator (e.g., OpenClaw). In spawned sessions: - Focus on completing the task and reporting results via prose output. - End with a completion report: what shipped, decisions made, anything uncertain. +## AskUserQuestion Format + +**ALWAYS follow this structure for every AskUserQuestion call. Every element is non-skippable. If you find yourself about to skip any of them, stop and back up.** + +### Required shape + +Every AskUserQuestion reads like a decision brief, not a bullet list: + +``` +D + +ELI10: + +Stakes if we pick wrong: + +Recommendation: because + +Completeness: A=X/10, B=Y/10 (or: Note: options differ in kind, not coverage — no completeness score) + +Pros / cons: + +A)