mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-04 15:57:33 +01:00
fix: pre-landing review fixes (plain bug fixes are exempt, proof is a repro or failing test)
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
4ddc0e418b
commit
caa17fccc0
6 files changed
+10
-10
No files matched your search
+2
-2
@@ -135,7 +135,7 @@ alone is not an ask.
|
||||
|
||||
A lane that builds something plans first. Its first act after the session-start install
|
||||
check, before any product code, is a `/autoplan` run on its brief, sized to the work. The
|
||||
phases run in order, CEO, then design, then DX, then eng, with design and DX only when the
|
||||
full run's phases run in order, CEO, then design, then DX, then eng, with design and DX only when the
|
||||
scope has them. A bug fix gets no plan review and a feature gets the lean run (both below). On Capy the
|
||||
unattended loop is `autoplan/DRIVER.md` in the gstack checkout. New functionality a lane
|
||||
takes on part-way, scope its brief did not name, gets its own plan and its own ask before
|
||||
@@ -182,7 +182,7 @@ flaky pass's repairs, slot stamps, CHANGELOG-only conflict resolves and a size o
|
||||
cap re-pinned under the controller's written grant need no plan. Two kinds of fix are exempt
|
||||
too: an S1 emergency (a broken install or upgrade, a red main, a security bug), and a fix
|
||||
from a problem list that was already diagnosed and audited, where that list is the plan.
|
||||
Any other bug fix gets no plan review (R65): `gstack-autoplan next --kind fix` prints
|
||||
Any other bug fix is exempt too (R65; the brief's reason is `bug fix (R65)`): `gstack-autoplan next --kind fix` prints
|
||||
`AUTOPLAN: not needed (bug fix; R65)` and writes nothing, and the PR carries the bug's
|
||||
proof, a repro on current main or a failing test written first. A feature gets the lean
|
||||
run, `--kind feature`: one reviewer reading the plan and the draft code together, one gate
|
||||
|
||||
Reference in new issue
Block a user