From d00d83f80a47c386c1c62a2cd0b1bae8d5ebf842 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Tue, 17 Nov 2026 19:22:05 +0800 Subject: [PATCH] Say in the release docs that the stable cut also waits on commit statuses (GST-2252) (#4436) * Say in the release docs that the stable cut also waits on commit statuses (GST-2252) The release cut skips a commit whose commit status failed and waits on one still pending, since #4257. The Green definition in docs/releases.md only named check runs. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * Add the changelog entry for the release docs' commit-status sentence (GST-2252) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- changelog.d/docs-release-cut-green-counts-commit-statuses.md | 1 + docs/releases.md | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelog.d/docs-release-cut-green-counts-commit-statuses.md diff --git a/changelog.d/docs-release-cut-green-counts-commit-statuses.md b/changelog.d/docs-release-cut-green-counts-commit-statuses.md new file mode 100644 index 000000000..847426185 --- /dev/null +++ b/changelog.d/docs-release-cut-green-counts-commit-statuses.md @@ -0,0 +1 @@ +- **docs/releases.md now says the stable release cut treats a failed commit status as red and a pending one as still going, as it has since #4257.** The docs' definition of a green commit only mentioned check runs. diff --git a/docs/releases.md b/docs/releases.md index 85dbfa765..322c4d318 100644 --- a/docs/releases.md +++ b/docs/releases.md @@ -47,7 +47,8 @@ it has completed and none failed, and `refs/notes/gstack-trains` holds no active freeze. A cancelled check run counts as red. Check runs are read the way the merge queue reads them, so a failed check whose rerun attempt created no jobs, and a workflow run that failed before creating any job, count as red -even though GitHub's default list hides them. A commit with a check run +even though GitHub's default list hides them. A failed commit status counts +as red too, and a pending one counts as still going. A commit with a check run still going is skipped and the next older one is considered, back through 7 days or 200 first-parent commits. The cut's own job lands a check run on main's head, the very commit it may cut, so check runs from this workflow's