From d046b13feae77bda7ae7dc33b16391e5e2883885 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Sun, 22 Mar 2026 23:25:40 -0700 Subject: [PATCH] =?UTF-8?q?fix:=20/cso=20E2E=20tests=20=E2=80=94=20correct?= =?UTF-8?q?=20logCost=20and=20recordE2E=20signatures?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit logCost requires (label, result), recordE2E requires (collector, name, suite, result). Fixed all 3 test cases. Co-Authored-By: Claude Opus 4.6 (1M context) --- test/skill-e2e-cso.test.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/skill-e2e-cso.test.ts b/test/skill-e2e-cso.test.ts index e291b2eb..b6cc68cc 100644 --- a/test/skill-e2e-cso.test.ts +++ b/test/skill-e2e-cso.test.ts @@ -75,7 +75,7 @@ IMPORTANT: timeout: 300_000, }); - logCost(result); + logCost('cso', result); // Should detect hardcoded API key const output = result.output.toLowerCase(); @@ -101,7 +101,7 @@ IMPORTANT: expect(reports.length).toBeGreaterThanOrEqual(1); } - recordE2E(evalCollector, 'cso-full-audit', result); + recordE2E(evalCollector, 'cso-full-audit', 'e2e-cso', result); }, 300_000); }); @@ -162,7 +162,7 @@ IMPORTANT: timeout: 240_000, }); - logCost(result); + logCost('cso', result); const output = result.output.toLowerCase(); // Should mention webhook and missing signature verification @@ -170,7 +170,7 @@ IMPORTANT: output.includes('webhook') && (output.includes('signature') || output.includes('verify')) ).toBe(true); - recordE2E(evalCollector, 'cso-diff-mode', result); + recordE2E(evalCollector, 'cso-diff-mode', 'e2e-cso', result); }, 240_000); }); @@ -235,7 +235,7 @@ IMPORTANT: timeout: 240_000, }); - logCost(result); + logCost('cso', result); const output = result.output.toLowerCase(); // Should mention unpinned action or Dockerfile issues @@ -244,6 +244,6 @@ IMPORTANT: output.includes('user directive') || output.includes('root') ).toBe(true); - recordE2E(evalCollector, 'cso-infra-scope', result); + recordE2E(evalCollector, 'cso-infra-scope', 'e2e-cso', result); }, 240_000); });