test: structural Design count boundary; TODO proposals are not findings

Replaying run 36385945043 through the Design count predicates: routing,
focus and learnings setup was not recognized as setup, Issue 1 was counted
pre-review in both attempts (the boundary fired on it), and attempt 2
counted the Font TODO proposal as a finding (review=4 and review=5 for five
issues). The paid caller now starts review at the first answered native
decision that is not setup (recognized packet, or setup header/question ID),
a completion handoff, artifact rendering or a TODO proposal (the review's
Add to TODOS.md / Skip / Build it now menu). TODO proposals are recorded as
administrative extra decisions. The replay asserts each counted call: both
attempts review=5 (Issues 1-5). isDesignCountFirstReview and its controls
are unchanged.
This commit is contained in:
garrytan committed 2026-09-29 15:04:28 +00:00
1 parent f1eeec384e
commit d05097b157
3 files changed
+127 -6

No files matched your search

+37 -3
View File
@@ -2,6 +2,11 @@ import { designFirstReviewAUQ, designReviewSetupAUQ } from './claude-pty-runner'
import type { AskUserQuestionFingerprint } from './claude-pty-runner';
import { pickDesignCountOutsideVoices } from './design-count-outside';
// Native header / question-ID vocabulary this review assigns only to setup and navigation.
const DESIGN_SETUP_HEADER = /^(?:focus|scope|learnings|routing|next steps?|outside(?: design)? voices)$/i;
const DESIGN_SETUP_ID = /(?:^|-)(?:focus|scope|setup|routing|learnings|onboarding|next-steps?|posture|mockups?|target)(?:-|$)/i;
const questionId = (question: string) => /<gstack-qid:\s*([a-z0-9-]+)\s*>/i.exec(question)?.[1] ?? '';
/** Choosing reviewer participation is setup, even when numbered or asked late. */
export function isDesignCountSetup(fp: AskUserQuestionFingerprint): boolean {
if (designReviewSetupAUQ(fp)) return true;
@@ -767,9 +772,9 @@ export function isDesignCountFirstReview(fp: AskUserQuestionFingerprint): boolea
if (designFirstReviewAUQ(fp)) return true;
return call.questions.some(q => {
if (!call.answers?.[q.question] || q.options.length < 2) return false;
if (/^(?:focus|scope|learnings|routing|next steps?|outside(?: design)? voices)$/i.test(q.header.trim())) return false;
const id = /<gstack-qid:\s*([a-z0-9-]+)\s*>/i.exec(q.question)?.[1] ?? '';
if (/(?:^|-)(?:focus|scope|setup|routing|learnings|onboarding|next-steps?|posture|mockups?|target)(?:-|$)/i.test(id)) return false;
if (DESIGN_SETUP_HEADER.test(q.header.trim())) return false;
const id = questionId(q.question);
if (DESIGN_SETUP_ID.test(id)) return false;
// Native fingerprints prepend the menu header. Inspect the actual question
// for an explicit finding that offers a plan amendment and deferral.
if (call.answered === true && call.failed === false && /^Pass\s*[1-7]\s*\([^)]*\)\s*[—–:]\s*Finding\s*[1-9]\d*:\s+\S/i.test(q.question.trim()) &&
@@ -814,6 +819,35 @@ export function isDesignCountFirstReview(fp: AskUserQuestionFingerprint): boolea
});
}
/** Setup by structure: the recognized setup packet, or a native call whose every
* question carries a setup header or setup question ID. */
export function isDesignCountStructuralSetup(fp: AskUserQuestionFingerprint): boolean {
if (isDesignCountSetup(fp)) return true;
const call = fp.nativeCall;
return !!call && call.questions.length > 0 && call.questions.every(q =>
DESIGN_SETUP_HEADER.test(q.header.trim()) || DESIGN_SETUP_ID.test(questionId(q.question)));
}
/** The review's TODO contract offers exactly A) Add to TODOS.md, B) Skip, C) Build it now. */
export function isDesignTodoProposal(fp: AskUserQuestionFingerprint): boolean {
const call = fp.nativeCall;
if (!call?.answered || call.failed || call.questions.length !== 1) return false;
const labels = call.questions[0]!.options.map(option => option.label.trim()
.replace(/^\d*[A-C][).:]?\s+/, '').replace(/\s*\(recommended\)\s*$/i, ''));
return labels.length === 3 && /^Add to TODOS\.md\b/i.test(labels[0]!) && /^Skip\b/i.test(labels[1]!) &&
/^Build it now\b/i.test(labels[2]!);
}
/** After setup, the first answered native decision that is not setup, a TODO
* proposal, a completion handoff or artifact rendering starts review. Handoff and
* artifact calls are classified before this predicate runs. */
export function isDesignCountReviewStart(fp: AskUserQuestionFingerprint): boolean {
const call = fp.nativeCall;
return !!call && call.answered === true && call.failed === false && fp.signature === `${call.sessionId}:${call.toolUseId}` &&
call.questions.length > 0 && call.questions.every(q => Boolean(call.answers?.[q.question])) &&
!isDesignCountStructuralSetup(fp) && !isDesignTodoProposal(fp);
}
/** A closed recap may explain why Eng is next; it cannot request another fix. */
function closedDesignGateRecap(tail: string, descriptions: string[]): boolean {
const navigation = /\bWhat(?:['’]s)?\s+next\?\s*<gstack-qid:[a-z0-9-]+>\s*$/i.exec(tail);