CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-08-08 23:36:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

chore: regenerate SKILL.md files and update tests + TODOS

Browse Source 
- Regenerate all SKILL.md from updated templates
- Update skill-validation tests for new gstack-slug output (3 vars)
  and new path patterns (plans/ceo, gstack-slug over REMOTE_SLUG)
- Update gen-skill-docs tests for new review path ($BRANCH.jsonl)
- Mark setup-gstack-upload + gstack-upload helper as superseded
  in TODOS.md (replaced by Supabase Storage)
- Fix last REMOTE_SLUG reference in greptile-triage.md

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-03-18 23:55:29 -07:00
co-authored by Claude Opus 4.6
parent f29232277a
commit d051f84060
15 changed files with 233 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plan-eng-review/SKILL.md
+22 -7
View File
@@ -217,14 +217,24 @@ After producing the test diagram, write a test plan artifact to the project dire
```bash
eval $(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)
USER=$(whoami)
DATETIME=$(date +%Y%m%d-%H%M%S)
mkdir -p ~/.gstack/projects/$SLUG
DATE=$(date +%Y-%m-%d)
```
Write to `~/.gstack/projects/{slug}/{user}-{branch}-test-plan-{datetime}.md`:
```bash
mkdir -p $PROJECTS_DIR/$SLUG/plans
FILE="$PROJECTS_DIR/$SLUG/plans/$DATE-$BRANCH-test-plan.md"
[ -f "$FILE" ] && FILE="$PROJECTS_DIR/$SLUG/plans/$DATE-$(date +%H%M)-$BRANCH-test-plan.md"
```
Write to the file path resolved above with this content (include the YAML frontmatter):
```markdown
---
type: test-plan
branch: {branch}
date: {YYYY-MM-DD}
skill: plan-eng-review
---
# Test Plan
Generated by /plan-eng-review on {date}
Branch: {branch}
@@ -245,6 +255,11 @@ Repo: {owner/repo}
This file is consumed by `/qa` and `/qa-only` as primary test input. Include only the information that helps a QA tester know **what to test and where** — not implementation details.
After writing the test plan, register it in the manifest:
```bash
~/.claude/skills/gstack/bin/gstack-manifest-append test-plan "plans/$(basename "$FILE")" plan-eng-review "$BRANCH"
```
### 4. Performance review
Evaluate:
* N+1 queries and database access patterns.
@@ -326,8 +341,8 @@ After producing the Completion Summary above, persist the review result:
```bash
eval $(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)
mkdir -p ~/.gstack/projects/$SLUG
echo '{"skill":"plan-eng-review","timestamp":"TIMESTAMP","status":"STATUS","unresolved":N,"critical_gaps":N,"mode":"MODE"}' >> ~/.gstack/projects/$SLUG/$BRANCH-reviews.jsonl
mkdir -p $PROJECTS_DIR/$SLUG/reviews
echo '{"skill":"plan-eng-review","timestamp":"TIMESTAMP","status":"STATUS","unresolved":N,"critical_gaps":N,"mode":"MODE"}' >> $PROJECTS_DIR/$SLUG/reviews/$BRANCH.jsonl
```
Substitute values from the Completion Summary:
@@ -343,7 +358,7 @@ After completing the review, read the review log and config to display the dashb
```bash
eval $(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)
cat ~/.gstack/projects/$SLUG/$BRANCH-reviews.jsonl 2>/dev/null || echo "NO_REVIEWS"
cat $PROJECTS_DIR/$SLUG/reviews/$BRANCH.jsonl 2>/dev/null || echo "NO_REVIEWS"
echo "---CONFIG---"
~/.claude/skills/gstack/bin/gstack-config get skip_eng_review 2>/dev/null || echo "false"
```