From d1eb3d0299a8ea401edde41ae5eae97eb3c629bb Mon Sep 17 00:00:00 2001 From: garrytan Date: Sat, 31 Oct 2026 19:16:10 +0000 Subject: [PATCH] review-collect: read a missing spawn status as null (Bun 1.4.2 returns undefined on ENOENT) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- lib/review-collect.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/review-collect.ts b/lib/review-collect.ts index 8b3053f8f..e9577c402 100644 --- a/lib/review-collect.ts +++ b/lib/review-collect.ts @@ -39,7 +39,8 @@ function gitUntil(root: string, args: string[], deadline: number): { status: num const left = deadline - Date.now(); if (left <= 0) return { status: null, out: '', err: '', timedOut: true }; const r = spawnSync('git', ['-c', 'core.quotePath=false', ...args], { cwd: root, encoding: 'utf8', timeout: left, maxBuffer: 256 * 1024 * 1024 }); - return { status: r.status, out: r.stdout ?? '', err: (r.stderr ?? '').trim() || ((r.error as NodeJS.ErrnoException | undefined)?.code ?? ''), timedOut: r.status === null && Date.now() >= deadline }; + const status = r.status ?? null; + return { status, out: r.stdout ?? '', err: (r.stderr ?? '').trim() || ((r.error as NodeJS.ErrnoException | undefined)?.code ?? ''), timedOut: status === null && Date.now() >= deadline }; } const scratch = (p: string) => p.startsWith('.gstack/tmp/'); const oneLine = (s: string) => s.replace(/[\0-\x1f]+/g, ' ').trim().slice(0, 200);