From d2c9c8fa6da3c9e237a2db4517c66cae460226bc Mon Sep 17 00:00:00 2001 From: garrytan Date: Wed, 30 Sep 2026 12:45:55 +0000 Subject: [PATCH] fix(review,ship): plan checks publish a checkpoint before each probe; only the smoke expiry stop is skipped --- review/SKILL.md | 2 +- scripts/resolvers/qa.ts | 2 +- ship/sections/review-army.md | 2 +- test/fixtures/golden/codex-ship-SKILL.md | 2 +- test/fixtures/golden/factory-ship-SKILL.md | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/review/SKILL.md b/review/SKILL.md index 11e391d6c..b407679cd 100644 --- a/review/SKILL.md +++ b/review/SKILL.md @@ -827,7 +827,7 @@ Never install, import cookies or bootstrap tests. Functional-only skips browser **3. Run smoke and plan checks.** Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit. Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock. -Plan checks and their revalidation skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`; checkpoints still publish beside D. A smoke recheck after expiry is not-run. +Plan checks and their revalidation publish a checkpoint beside D before each probe but skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`. A smoke recheck after expiry is not-run. Use finite command timeouts, capped at the caller's remaining time if it has a deadline. Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run. diff --git a/scripts/resolvers/qa.ts b/scripts/resolvers/qa.ts index 35e159599..3399db09e 100644 --- a/scripts/resolvers/qa.ts +++ b/scripts/resolvers/qa.ts @@ -257,7 +257,7 @@ Never install, import cookies or bootstrap tests. Functional-only skips browser **3. Run smoke and plan checks.** Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit. Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock. -Plan checks and their revalidation skip the \`G status D\` expiry stop and use \`--timeout-ms\`, not \`--deadline D\`; checkpoints still publish beside D. A smoke recheck after expiry is not-run. +Plan checks and their revalidation publish a checkpoint beside D before each probe but skip the \`G status D\` expiry stop and use \`--timeout-ms\`, not \`--deadline D\`. A smoke recheck after expiry is not-run. Use finite command timeouts, capped at the caller's remaining time if it has a deadline. Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run. diff --git a/ship/sections/review-army.md b/ship/sections/review-army.md index 00ff91314..54c7d9d6e 100644 --- a/ship/sections/review-army.md +++ b/ship/sections/review-army.md @@ -504,7 +504,7 @@ Run the shared preflight; start its smoke guard once. Guard every smoke probe. F **3. Run smoke and plan checks.** Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit. Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock. -Plan checks and their revalidation skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`; checkpoints still publish beside D. A smoke recheck after expiry is not-run. +Plan checks and their revalidation publish a checkpoint beside D before each probe but skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`. A smoke recheck after expiry is not-run. Use finite command timeouts, capped at the caller's remaining time if it has a deadline. Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run. diff --git a/test/fixtures/golden/codex-ship-SKILL.md b/test/fixtures/golden/codex-ship-SKILL.md index 74621b56c..fffc08cc1 100644 --- a/test/fixtures/golden/codex-ship-SKILL.md +++ b/test/fixtures/golden/codex-ship-SKILL.md @@ -2109,7 +2109,7 @@ Run the shared preflight; start its smoke guard once. Guard every smoke probe. F **3. Run smoke and plan checks.** Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit. Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock. -Plan checks and their revalidation skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`; checkpoints still publish beside D. A smoke recheck after expiry is not-run. +Plan checks and their revalidation publish a checkpoint beside D before each probe but skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`. A smoke recheck after expiry is not-run. Use finite command timeouts, capped at the caller's remaining time if it has a deadline. Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run. diff --git a/test/fixtures/golden/factory-ship-SKILL.md b/test/fixtures/golden/factory-ship-SKILL.md index c332595a7..d4d085012 100644 --- a/test/fixtures/golden/factory-ship-SKILL.md +++ b/test/fixtures/golden/factory-ship-SKILL.md @@ -2368,7 +2368,7 @@ Run the shared preflight; start its smoke guard once. Guard every smoke probe. F **3. Run smoke and plan checks.** Follow the shared Probe loop for smoke checks, replays and revalidation until the smoke limit. Then run required plan checks, even after smoke expires, using the same procedure but no smoke guard; never reset the clock. -Plan checks and their revalidation skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`; checkpoints still publish beside D. A smoke recheck after expiry is not-run. +Plan checks and their revalidation publish a checkpoint beside D before each probe but skip the `G status D` expiry stop and use `--timeout-ms`, not `--deadline D`. A smoke recheck after expiry is not-run. Use finite command timeouts, capped at the caller's remaining time if it has a deadline. Await clock/guard results before acting. When the caller's deadline expires, mark unfinished checks not-run.