From d303b9e23edb1d37db98b7f1c0c886547eed637e Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Mon, 16 Mar 2026 11:33:58 -0500 Subject: [PATCH] chore: regenerate design review SKILL.md files after merge from main Picks up BASE_BRANCH_DETECT resolver and updated contributor mode from main. Co-Authored-By: Claude Opus 4.6 (1M context) --- plan-design-review/SKILL.md | 24 +++++++++++++++--------- qa-design-review/SKILL.md | 24 +++++++++++++++--------- 2 files changed, 30 insertions(+), 18 deletions(-) diff --git a/plan-design-review/SKILL.md b/plan-design-review/SKILL.md index 598049d0..ea5ef6f5 100644 --- a/plan-design-review/SKILL.md +++ b/plan-design-review/SKILL.md @@ -45,12 +45,15 @@ Per-skill instructions may add additional formatting rules on top of this baseli ## Contributor Mode -If `_CONTRIB` is `true`: you are in **contributor mode**. When you hit friction with **gstack itself** (not the user's app), file a field report. Think: "hey, I was trying to do X with gstack and it didn't work / was confusing / was annoying. Here's what happened." +If `_CONTRIB` is `true`: you are in **contributor mode**. You're a gstack user who also helps make it better. -**gstack issues:** browse command fails/wrong output, snapshot missing elements, skill instructions unclear or misleading, binary crash/hang, unhelpful error message, any rough edge or annoyance — even minor stuff. -**NOT gstack issues:** user's app bugs, network errors to user's URL, auth failures on user's site. +**At the end of each major workflow step** (not after every single command), reflect on the gstack tooling you used. Rate your experience 0 to 10. If it wasn't a 10, think about why. If there is an obvious, actionable bug OR an insightful, interesting thing that could have been done better by gstack code or skill markdown — file a field report. Maybe our contributor will help make us better! -**To file:** write `~/.gstack/contributor-logs/{slug}.md` with this structure: +**Calibration — this is the bar:** For example, `$B js "await fetch(...)"` used to fail with `SyntaxError: await is only valid in async functions` because gstack didn't wrap expressions in async context. Small, but the input was reasonable and gstack should have handled it — that's the kind of thing worth filing. Things less consequential than this, ignore. + +**NOT worth filing:** user's app bugs, network errors to user's URL, auth failures on user's site, user's own JS logic bugs. + +**To file:** write `~/.gstack/contributor-logs/{slug}.md` with **all sections below** (do not truncate — include every section through the Date/Version footer): ``` # {Title} @@ -59,20 +62,23 @@ Hey gstack team — ran into this while using /{skill-name}: **What I was trying to do:** {what the user/agent was attempting} **What happened instead:** {what actually happened} -**How annoying (1-5):** {1=meh, 3=friction, 5=blocker} +**My rating:** {0-10} — {one sentence on why it wasn't a 10} ## Steps to reproduce 1. {step} ## Raw output -(wrap any error messages or unexpected output in a markdown code block) +``` +{paste the actual error or unexpected output here} +``` + +## What would make this a 10 +{one sentence: what gstack should have done differently} **Date:** {YYYY-MM-DD} | **Version:** {gstack version} | **Skill:** /{skill} ``` -Then run: `mkdir -p ~/.gstack/contributor-logs && open ~/.gstack/contributor-logs/{slug}.md` - -Slug: lowercase, hyphens, max 60 chars (e.g. `browse-snapshot-ref-gap`). Skip if file already exists. Max 3 reports per session. File inline and continue — don't stop the workflow. Tell user: "Filed gstack field report: {title}" +Slug: lowercase, hyphens, max 60 chars (e.g. `browse-js-no-await`). Skip if file already exists. Max 3 reports per session. File inline and continue — don't stop the workflow. Tell user: "Filed gstack field report: {title}" # /plan-design-review: Designer's Eye Audit diff --git a/qa-design-review/SKILL.md b/qa-design-review/SKILL.md index d6565fda..a5b6ace5 100644 --- a/qa-design-review/SKILL.md +++ b/qa-design-review/SKILL.md @@ -46,12 +46,15 @@ Per-skill instructions may add additional formatting rules on top of this baseli ## Contributor Mode -If `_CONTRIB` is `true`: you are in **contributor mode**. When you hit friction with **gstack itself** (not the user's app), file a field report. Think: "hey, I was trying to do X with gstack and it didn't work / was confusing / was annoying. Here's what happened." +If `_CONTRIB` is `true`: you are in **contributor mode**. You're a gstack user who also helps make it better. -**gstack issues:** browse command fails/wrong output, snapshot missing elements, skill instructions unclear or misleading, binary crash/hang, unhelpful error message, any rough edge or annoyance — even minor stuff. -**NOT gstack issues:** user's app bugs, network errors to user's URL, auth failures on user's site. +**At the end of each major workflow step** (not after every single command), reflect on the gstack tooling you used. Rate your experience 0 to 10. If it wasn't a 10, think about why. If there is an obvious, actionable bug OR an insightful, interesting thing that could have been done better by gstack code or skill markdown — file a field report. Maybe our contributor will help make us better! -**To file:** write `~/.gstack/contributor-logs/{slug}.md` with this structure: +**Calibration — this is the bar:** For example, `$B js "await fetch(...)"` used to fail with `SyntaxError: await is only valid in async functions` because gstack didn't wrap expressions in async context. Small, but the input was reasonable and gstack should have handled it — that's the kind of thing worth filing. Things less consequential than this, ignore. + +**NOT worth filing:** user's app bugs, network errors to user's URL, auth failures on user's site, user's own JS logic bugs. + +**To file:** write `~/.gstack/contributor-logs/{slug}.md` with **all sections below** (do not truncate — include every section through the Date/Version footer): ``` # {Title} @@ -60,20 +63,23 @@ Hey gstack team — ran into this while using /{skill-name}: **What I was trying to do:** {what the user/agent was attempting} **What happened instead:** {what actually happened} -**How annoying (1-5):** {1=meh, 3=friction, 5=blocker} +**My rating:** {0-10} — {one sentence on why it wasn't a 10} ## Steps to reproduce 1. {step} ## Raw output -(wrap any error messages or unexpected output in a markdown code block) +``` +{paste the actual error or unexpected output here} +``` + +## What would make this a 10 +{one sentence: what gstack should have done differently} **Date:** {YYYY-MM-DD} | **Version:** {gstack version} | **Skill:** /{skill} ``` -Then run: `mkdir -p ~/.gstack/contributor-logs && open ~/.gstack/contributor-logs/{slug}.md` - -Slug: lowercase, hyphens, max 60 chars (e.g. `browse-snapshot-ref-gap`). Skip if file already exists. Max 3 reports per session. File inline and continue — don't stop the workflow. Tell user: "Filed gstack field report: {title}" +Slug: lowercase, hyphens, max 60 chars (e.g. `browse-js-no-await`). Skip if file already exists. Max 3 reports per session. File inline and continue — don't stop the workflow. Tell user: "Filed gstack field report: {title}" # /qa-design-review: Design Audit → Fix → Verify