mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-19 06:34:43 +01:00
Tests and scratch repositories can no longer write approval rows into a real Capy Drive (GST-3027) (#4466)
Tests and scratch repositories in the temp directory can no longer write approval rows into your real Capy Drive. When `gstack-approvals` runs under `bun test`, or its state root or repository sits in the temp directory, a Drive mirror that resolves outside the temp directory (links followed) is refused with `APPROVAL_RECORD_WRITE_FAILED`; the local row is kept. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> Review-Finding: p1/red-team#1 reader=red-team
This commit is contained in:
1 parent
fc5c285035
commit
d3d35019a0
4 files changed
+80
-10
No files matched your search
@@ -2201,9 +2201,13 @@ and, as `READ_ALSO:`, the other roots it still reads (a row mirrored before the
|
||||
|
||||
**Meaning.** The local record or its Drive mirror could not be written; the line names
|
||||
the path and the error. A failed local append wrote nothing. A failed mirror write
|
||||
leaves the local row in place. Exit 1.
|
||||
leaves the local row in place. Exit 1. A fixture (a run under `bun test`, or a state root or
|
||||
repository in the temp directory) also gets this when its mirror resolves outside the temp
|
||||
directory: the line says `outside the temp root`, and nothing reaches that Drive.
|
||||
|
||||
**Fix.** Make the named directory writable, then rerun `gstack-approvals sync` to mirror again.
|
||||
For a fixture, point `HOME` or `GSTACK_APPROVALS_DIR` inside its temp directory, or set
|
||||
`GSTACK_APPROVALS_MIRROR=0`.
|
||||
|
||||
<a id="approval-import-unanswered"></a>
|
||||
### `gstack-approvals import: ... (APPROVAL_IMPORT_UNANSWERED)`
|
||||
|
||||
Reference in new issue
Block a user