mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-16 21:31:58 +01:00
fix(ship): no closing-summary template word sets the negation apart from an earlier blocker (GST-435 rule (b'))
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
de3a575715
commit
d40e14e2ff
3 files changed
+13
-8
No files matched your search
@@ -471,12 +471,13 @@ ones, and the arm lost blockers. `bin/gstack-review-dispatch` closes both ends:
|
||||
label-only heading takes the stronger of the two). A label is dropped only from a closing
|
||||
summary, a sentence that as a whole is one of a closed set of templates (GST-435): an optional
|
||||
"I found" or "there's", a negator, an optional review subject (finding, fix, change, here,
|
||||
else, "in this diff"), the label words and a short tail, as in "I found three INFORMATIONAL
|
||||
"in this diff"), the label words and a short tail, as in "I found three INFORMATIONAL
|
||||
issues and no CRITICAL ones", "Neither fix is CRITICAL" or "No CRITICAL or High findings to
|
||||
report". A sentence that names a file:line, holds an exception or contrast word (except,
|
||||
besides, but, only), runs over 100 characters or sits in a table row keeps every label, and
|
||||
so does any phrasing the templates leave out ("This is not CRITICAL" stays a phantom for lead
|
||||
judgment to fold). A kept finding never takes a weaker label than the strongest one left on its line. A `Severity:` or `Blocks:` line
|
||||
judgment to fold). No template word sets the negation apart from something named earlier, so
|
||||
"Nothing else is CRITICAL" or "No other issue is CRITICAL" after a blocker keeps its label. A kept finding never takes a weaker label than the strongest one left on its line. A `Severity:` or `Blocks:` line
|
||||
continues the finding above it until a list item, heading, bold paragraph opener or a
|
||||
second line for the same field starts another: `Severity` raises its label,
|
||||
`Blocks: yes` makes it CRITICAL and `Blocks: no` never lowers it; an inline
|
||||
|
||||
Reference in new issue
Block a user