mirror of
https://github.com/garrytan/gstack.git
synced 2026-07-07 08:37:52 +02:00
fix(plan-reviews): tighten STOP/escape-hatch directives across 4 templates
Part 2 of 4 (plan: ~/.claude/plans/system-instruction-you-are-working-polymorphic-twilight.md).
Codex caught that v1.6.3.0's reasoning collapsed on Opus 4.7: the old
escape-hatch wording ("If no issues or fix is obvious, state what
you'll do and move on — don't waste a question") let the literal
interpreter classify every finding as having an "obvious fix" and skip
AskUserQuestion entirely. Reviews became reports.
Per-template hardening (16 sites total, verified by rg):
plan-ceo-review/SKILL.md.tmpl (13 sites):
- 12 inline STOP directives: replace the full escape-hatch clause with
"zero findings → say so and proceed; findings → MUST call AskUserQuestion
as a tool_use, including for obvious fixes."
- 1 Escape hatch bullet in CRITICAL RULE section: tightened.
plan-eng-review, plan-design-review, plan-devex-review (1 site each):
- Each template's Escape hatch bullet tightened to match the new CEO wording,
adapted for each review's domain (issue/gap, decision/design/DX alternatives).
After regeneration: rg "don't waste a question" returns 0 across all
*SKILL.md.tmpl and *SKILL.md files. "zero findings, state" wording
present 16 times (matches prior count of escape-hatch sites).
bun test passes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1792,8 +1792,11 @@ DX reviews:
|
||||
* **Map to DX First Principles above.** One sentence connecting your recommendation
|
||||
to a specific principle (e.g., "This violates 'zero friction at T0' because
|
||||
[persona] needs 3 extra config steps before their first API call").
|
||||
* **Escape hatch:** If a section has no issues, say so and move on. If a gap has an
|
||||
obvious fix, state what you'll add and move on, don't waste a question.
|
||||
* **Escape hatch (tightened):** If a section has zero findings, state "No issues,
|
||||
moving on" and proceed. If it has findings, use AskUserQuestion for each — a
|
||||
gap with an "obvious fix" is still a gap and still needs user approval before
|
||||
any change lands in the plan. Only skip AskUserQuestion when the fix is
|
||||
genuinely trivial AND there are no meaningful DX alternatives. When in doubt, ask.
|
||||
* Assume the user hasn't looked at this window in 20 minutes. Re-ground every question.
|
||||
|
||||
## Required Outputs
|
||||
|
||||
@@ -666,8 +666,11 @@ DX reviews:
|
||||
* **Map to DX First Principles above.** One sentence connecting your recommendation
|
||||
to a specific principle (e.g., "This violates 'zero friction at T0' because
|
||||
[persona] needs 3 extra config steps before their first API call").
|
||||
* **Escape hatch:** If a section has no issues, say so and move on. If a gap has an
|
||||
obvious fix, state what you'll add and move on, don't waste a question.
|
||||
* **Escape hatch (tightened):** If a section has zero findings, state "No issues,
|
||||
moving on" and proceed. If it has findings, use AskUserQuestion for each — a
|
||||
gap with an "obvious fix" is still a gap and still needs user approval before
|
||||
any change lands in the plan. Only skip AskUserQuestion when the fix is
|
||||
genuinely trivial AND there are no meaningful DX alternatives. When in doubt, ask.
|
||||
* Assume the user hasn't looked at this window in 20 minutes. Re-ground every question.
|
||||
|
||||
## Required Outputs
|
||||
|
||||
Reference in New Issue
Block a user