feat(gstack2): port 6 judgment overlays (#1102 #1049 #592 #696 #1523 #1053)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Claude
2026-07-21 19:19:23 -07:00
parent 268e9ed10b
commit d72133e18e
30 changed files with 503 additions and 40 deletions
+2 -2
View File
@@ -2,7 +2,7 @@
Parity is executable, not a prose claim. Run `bun run scripts/gstack2/run-parity.ts` or the dedicated Bun tests.
The pinned release inventory passes **4,836 checks** across 55 specialist sources, 16 carved sections, 25 routing scenarios, 16 regression ports, and **78 assets**.
The pinned release inventory passes **4,866 checks** across 55 specialist sources, 16 carved sections, 25 routing scenarios, 22 regression ports, and **78 assets**.
The suite verifies:
@@ -11,7 +11,7 @@ The suite verifies:
- immutable full 1.x render hashes plus canonical specialist-render equality, with the excluded onboarding wrapper and lazy section references asserted explicitly;
- preservation of nine behavioral contract dimensions per module;
- 25 structured non-keyword routing fixtures with active/skipped modules, depth, mutation, and web context;
- 16 upstream judgment-port regression fixtures and anchors;
- 22 upstream judgment-port regression fixtures and anchors;
- all linked asset copies against their pinned Git blobs;
- frontmatter and `agents/openai.yaml` schema for each public skill.
+66 -6
View File
@@ -17,7 +17,7 @@
"packaged_section_copies": 17,
"internal_execution_adapters": 1,
"scenarios": 25,
"bug_fix_ports": 16,
"bug_fix_ports": 22,
"assets": 78,
"dependency_copies": 4,
"runtime_helpers": 41
@@ -88,7 +88,8 @@
"disposition": "BUG_FIX",
"overlays": [
679,
2030
2030,
1049
],
"original_source_file": "office-hours/SKILL.md.tmpl",
"original_line_range": "1-526",
@@ -343,7 +344,8 @@
"overlays": [
679,
1071,
2030
2030,
592
],
"original_source_file": "plan-eng-review/SKILL.md.tmpl",
"original_line_range": "1-158",
@@ -1827,7 +1829,8 @@
679,
1920,
2030,
2189
2189,
696
],
"original_source_file": "design-review/SKILL.md.tmpl",
"original_line_range": "1-313",
@@ -3672,7 +3675,9 @@
"disposition": "BUG_FIX",
"overlays": [
679,
2030
2030,
1523,
1053
],
"original_source_file": "cso/SKILL.md.tmpl",
"original_line_range": "1-408",
@@ -4008,7 +4013,8 @@
679,
884,
2030,
2186
2186,
1102
],
"original_source_file": "ship/SKILL.md.tmpl",
"original_line_range": "1-538",
@@ -7331,6 +7337,60 @@
"design-review"
],
"anchor": "GSTACK2_FIX_2189_DESIGN_THESIS_EQUIVALENCE"
},
{
"pr": 1102,
"url": "https://github.com/garrytan/gstack/pull/1102",
"title": "Read the test command from CLAUDE.md instead of hardcoding it",
"targets": [
"ship"
],
"anchor": "GSTACK2_FIX_1102_TEST_COMMAND_FROM_CLAUDEMD"
},
{
"pr": 1049,
"url": "https://github.com/garrytan/gstack/pull/1049",
"title": "Refuse to log success without a persisted design doc",
"targets": [
"office-hours"
],
"anchor": "GSTACK2_FIX_1049_NO_DOC_OUTCOME"
},
{
"pr": 592,
"url": "https://github.com/garrytan/gstack/pull/592",
"title": "Run a pre-mortem before challenging scope",
"targets": [
"plan-eng-review"
],
"anchor": "GSTACK2_FIX_592_PRE_MORTEM"
},
{
"pr": 696,
"url": "https://github.com/garrytan/gstack/pull/696",
"title": "Score each screen on a cognitive-load scale",
"targets": [
"design-review"
],
"anchor": "GSTACK2_FIX_696_COGNITIVE_LOAD"
},
{
"pr": 1523,
"url": "https://github.com/garrytan/gstack/pull/1523",
"title": "Detect the shai-hulud campaign in comprehensive mode only",
"targets": [
"cso"
],
"anchor": "GSTACK2_FIX_1523_SHAI_HULUD"
},
{
"pr": 1053,
"url": "https://github.com/garrytan/gstack/pull/1053",
"title": "Keep the audit report-only unless --fix is passed",
"targets": [
"cso"
],
"anchor": "GSTACK2_FIX_1053_FIX_MODE"
}
]
}
+6 -6
View File
@@ -11,9 +11,9 @@ The fixed public modes are: Design = `Explore | Generate | Critique | Implement`
| Legacy invocation | Replacement | Visibility | Mandatory | Judgment overlays |
|---|---|---|---|---|
| `/gstack` | `$plan --mode Discovery --module gstack` | internal (internal) | no | #679 |
| `/office-hours` | `$plan --mode Discovery --module office-hours` | internal (primary) | yes | #679, #2030 |
| `/office-hours` | `$plan --mode Discovery --module office-hours` | internal (primary) | yes | #679, #2030, #1049 |
| `/plan-ceo-review` | `$plan --mode Product --module plan-ceo-review` | internal (primary) | yes | #679, #2030 |
| `/plan-eng-review` | `$plan --mode Engineering --module plan-eng-review` | internal (primary) | yes | #679, #1071, #2030 |
| `/plan-eng-review` | `$plan --mode Engineering --module plan-eng-review` | internal (primary) | yes | #679, #1071, #2030, #592 |
| `/plan-devex-review` | `$plan --mode DX --module plan-devex-review` | internal (primary) | yes | #679, #2030 |
| `/autoplan` | `$plan --mode Full chain --module autoplan` | internal (primary) | yes | #679, #2014, #2023 |
| `/spec` | `$plan --mode Specification --module spec` | internal (primary) | yes | #679 |
@@ -28,7 +28,7 @@ The fixed public modes are: Design = `Explore | Generate | Critique | Implement`
| `/design-shotgun` | `$design --mode Explore --module design-shotgun` | internal (primary) | yes | #679, #1777 |
| `/design-html` | `$design --mode Implement --module design-html` | internal (primary) | yes | #679 |
| `/plan-design-review` | `$design --mode Critique --module plan-design-review` | internal (primary) | yes | #679, #2030, #2189 |
| `/design-review` | `$design --mode Implement --module design-review` | internal (primary) | yes | #679, #1920, #2030, #2189 |
| `/design-review` | `$design --mode Implement --module design-review` | internal (primary) | yes | #679, #1920, #2030, #2189, #696 |
| `/ios-design-review` | `$design --mode Critique --module ios-design-review` | internal (primary) | yes | #679 |
| `/diagram` | `$design --mode Generate --module diagram` | internal (internal) | no | #679 |
| `/make-pdf` | `$design --mode Generate --module make-pdf` | internal (internal) | no | #679 |
@@ -52,11 +52,11 @@ The fixed public modes are: Design = `Explore | Generate | Critique | Implement`
| `/guard` | `$debug --mode Diagnose-only --module guard` | internal (internal) | no | #679 |
| `/unfreeze` | `$debug --mode Diagnose-only --module unfreeze` | internal (internal) | no | #679 |
| `/review` | `$review --mode Normal --module review` | internal (primary) | yes | #610, #645, #679, #2030, #2141 |
| `/cso` | `$review --mode Security --module cso` | internal (primary) | yes | #679, #2030 |
| `/cso` | `$review --mode Security --module cso` | internal (primary) | yes | #679, #2030, #1523, #1053 |
| `/health` | `$review --mode Deep --module health` | internal (primary) | yes | #679 |
| `/codex` | `$review --mode Deep --module codex` | internal (primary) | yes | #679 |
| `/claude` | `$review --mode Deep --module claude` | internal (primary) | yes | #679 |
| `/ship` | `$ship --mode Prepare --module ship` | internal (primary) | yes | #679, #884, #2030, #2186 |
| `/ship` | `$ship --mode Prepare --module ship` | internal (primary) | yes | #679, #884, #2030, #2186, #1102 |
| `/land-and-deploy` | `$ship --mode Land --module land-and-deploy` | internal (primary) | yes | #679, #884 |
| `/landing-report` | `$ship --mode Prepare --module landing-report` | internal (primary) | yes | #679 |
| `/document-release` | `$ship --mode Prepare --module document-release` | internal (primary) | yes | #679 |
@@ -75,5 +75,5 @@ The fixed public modes are: Design = `Explore | Generate | Critique | Implement`
## Mechanical versus judgment changes
- `JUDGMENT_PRESERVING_CARVE`: pinned specialist workflow with the retired shared onboarding wrapper excluded, retired invocations resolved to six public routes, host/runtime paths normalized, and large carved phases loaded lazily from package-local pinned references.
- `BUG_FIX`: the canonical carved body plus a clearly delimited judgment overlay sourced from one of the 16 upstream PRs and its regression fixture.
- `BUG_FIX`: the canonical carved body plus a clearly delimited judgment overlay sourced from one of the 22 upstream PRs and its regression fixture.
- Asset relocation is byte-for-byte from the pinned Git blob and is indexed per tree.