From d9b51318072a978e8d61e90574a28494390bb54d Mon Sep 17 00:00:00 2001 From: garrytan Date: Sat, 17 Oct 2026 19:33:07 +0000 Subject: [PATCH] docs(todos): close the createQAFunctionalFixture entry and file D6 (W3-13) The git auto-maintenance entry was fixed by 0bf9d50 (#3190). D6: nested bun test output pollutes free-runner failure attribution in scripts/lib/shard-engine.ts (windows-free-tests 39053431430). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- TODOS.md | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/TODOS.md b/TODOS.md index aa26453fa..39b290d1e 100644 --- a/TODOS.md +++ b/TODOS.md @@ -5425,11 +5425,23 @@ Garry for each; revisit 2026-10-29 unless a date says otherwise. main's `flake-ledger-*` artifacts (`bun run test:health --since-days 7`) and check the free-suite flaky-pass rate is under 5% of main runs; a file still in the ledger gets a named cause or a new entry here. **Effort:** S. **Priority:** P1. -- **`createQAFunctionalFixture` sets git auto-maintenance off itself** — its - repos inherit the free runner's backstop keys in CI, but a direct `bun test` - run still races `.git/objects/maintenance.lock` during observer setup. - The helper selects 22 paid cases, so this is a priced follow-up. - **Effort:** S. **Priority:** P2. +- ~~**`createQAFunctionalFixture` sets git auto-maintenance off itself**~~ — + done in v1.91.107.0 (0bf9d50, #3190): test/helpers/qa-functional-fixture.ts + sets `gc.auto 0` and `maintenance.auto false` on its repos, as + test/helpers/qa-callers-fixture.ts does; no recurrence of the + `.git/objects` watch loss after it (fix wave 3 triage, W3-13). Original + note: — its repos inherit the free runner's backstop keys in CI, but a direct + `bun test` run still races `.git/objects/maintenance.lock` during observer + setup. **Effort:** S. **Priority:** P2. +- **Nested `bun test` output pollutes free-runner failure attribution** (fix + wave 3, D6) — windows-free-tests run 39053431430 (shard 5): a free test that + spawns a nested `bun test` echoes the child's `(fail) Review Army: Red Team > + (unnamed)` line on failure, and scripts/lib/shard-engine.ts attributed it to + the child's temporary file (`redteam.test.ts`), so the shard reported + "flaky-retry skipped: failures not fully attributed" instead of retrying the + real file. Ignore or prefix nested child result lines when attributing + failures, with a free test that feeds the captured shard log through the + attribution. **Effort:** S. **Priority:** P2. - **`test:ubicloud --diagnostic` cannot give clean counts for two ledger shards** — `ship-measure free` reruns set a private `HOME` under `/tmp` and `GSTACK_STATE_ROOT`, so `browse/test/path-validation.test.ts` (its upload