mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-14 08:59:01 +02:00
fix: sweep every remaining synchronous Agent-dispatch site with run_in_background: false
The #2440 failure shape was a silently-missing review voice — a specialist launched in the background and merged before it completed. Every remaining synchronous dispatch site now carries the explicit flag: the Red Team dispatch, the spec review loop, the Codex second-opinion/plan-review/doc-review Claude fallbacks, the adversarial subagent, design sketch and outside voices, autoplan's design/eng/dx phase dispatches, CSO parallel finding verification, and design-shotgun's variant launch. Parallel fan-outs stay parallel — multiple foreground Agent calls in one message run concurrently (the shipped v1.64.0.0 review-army pattern). GENERATED_WITH_GUIDANCE now pins all 24 generated carriers, so a new dispatch site that drops the flag fails the free suite. Six carved-skill skeleton ceilings re-measured and ratcheted (~80-130 B growth each); factory ship golden re-rendered. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
parent
1b4e1f14b0
commit
da8733fe0c
@@ -823,7 +823,7 @@ On any Codex error, fall back to the Claude subagent below.
|
||||
|
||||
**If CODEX_NOT_AVAILABLE (or Codex errored):**
|
||||
|
||||
Dispatch via the Agent tool. The subagent has fresh context — genuine independence.
|
||||
Dispatch via the Agent tool with `run_in_background: false` (subagents default to background since Claude Code v2.1.198; the findings must land before the workflow continues). The subagent has fresh context — genuine independence.
|
||||
|
||||
Subagent prompt: same mode-appropriate prompt as above (Startup or Builder variant).
|
||||
|
||||
@@ -1059,7 +1059,7 @@ codex exec "For this product approach, provide: a visual thesis (one sentence
|
||||
```
|
||||
Use a 5-minute timeout (`timeout: 300000`). After completion: `cat "$TMPERR_SKETCH" && rm -f "$TMPERR_SKETCH"`
|
||||
|
||||
2. **Claude subagent** (via Agent tool):
|
||||
2. **Claude subagent** (via Agent tool, `run_in_background: false` — subagents default to background since Claude Code v2.1.198):
|
||||
"For this product approach, what design direction would you recommend? What aesthetic, typography, and interaction patterns fit? What would make this approach feel inevitable to the user? Be specific — font names, hex colors, spacing values."
|
||||
|
||||
Present Codex output under `CODEX SAYS (design sketch):` and subagent output under `CLAUDE SUBAGENT (design direction):`.
|
||||
|
||||
@@ -170,7 +170,9 @@ Before presenting the document to the user for approval, run an adversarial revi
|
||||
|
||||
**Step 1: Dispatch reviewer subagent**
|
||||
|
||||
Use the Agent tool to dispatch an independent reviewer. The reviewer has fresh context
|
||||
Use the Agent tool to dispatch an independent reviewer, passing `run_in_background: false`
|
||||
(subagents default to background since Claude Code v2.1.198; this loop consumes the
|
||||
reviewer's verdict). The reviewer has fresh context
|
||||
and cannot see the brainstorming conversation — only the document. This ensures genuine
|
||||
adversarial independence.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user