mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-22 08:01:32 +01:00
The paid auto-decide check counts a start step that ran while the skill loaded (#4543)
Since #4509, Claude Code skills run their start step as they load, so the paid /plan-ceo-review auto-decide check could miss a run that really did auto-decide. It now accepts the start output in the loaded skill text. Why: one of the five passing runs captured for that check was credited only through the session journal, and that path needed a start command in the tool calls. Nothing to do: this changes test code and the journal reader the tests use; no skill text changes. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
7f9c1bc52a
commit
db2a56e679
6 files changed
+121
-16
No files matched your search
@@ -407,3 +407,28 @@ describe('native journal roots: SessionStart preamble, resumed genesis and reaso
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('skill text Claude Code loaded', () => {
|
||||
test('keeps only scoped, timestamped skill expansions with their load-time output', () => {
|
||||
const f = fixture();
|
||||
const text = 'Base directory for this skill: /fixture/.claude/skills/plan-ceo-review\n\n## Preamble (run first)\n\nSKILL_START_PROTO: 1\n';
|
||||
const other = (name: string) => text.replace('plan-ceo-review', name);
|
||||
f.append(
|
||||
f.record('user', [{ type: 'text', text: '<command-message>plan-ceo-review</command-message>' }]),
|
||||
f.record('user', [{ type: 'text', text }], { isMeta: true }),
|
||||
f.record('user', [{ type: 'text', text: other('typed-by-user') }]),
|
||||
f.record('user', [{ type: 'text', text: other('sidechain') }], { isMeta: true, isSidechain: true }),
|
||||
f.record('user', [{ type: 'text', text: other('untimed') }], { isMeta: true, timestamp: 'later' }),
|
||||
f.record('user', [{ type: 'text', text: other('foreign') }], { isMeta: true, cwd: '/elsewhere' }),
|
||||
f.record('user', [{ type: 'text', text: `Quoted: ${text}` }], { isMeta: true }),
|
||||
f.record('assistant', [{ type: 'text', text: other('assistant') }], { isMeta: true }),
|
||||
);
|
||||
expect(f.read().skillLoads).toEqual([{ sessionId: 'session-a', skill: 'plan-ceo-review', text, timestamp: '2026-09-08T15:31:13.607Z' }]);
|
||||
});
|
||||
|
||||
test('a transcript with no skill expansion reports none', () => {
|
||||
const f = fixture();
|
||||
f.append(f.ask('one'));
|
||||
expect(f.read().skillLoads).toBeUndefined();
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user