From dc640acd8acb4e172f96880812712046b8e7f96d Mon Sep 17 00:00:00 2001 From: garrytan Date: Tue, 29 Sep 2026 19:55:37 +0000 Subject: [PATCH] test: pin every-record outcome counts and the twelve doc-sync callbacks --- test/docsync-fault-interface.test.ts | 2 +- test/shared-libs-fixture.test.ts | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/docsync-fault-interface.test.ts b/test/docsync-fault-interface.test.ts index 374532cfc..a9e35d00c 100644 --- a/test/docsync-fault-interface.test.ts +++ b/test/docsync-fault-interface.test.ts @@ -582,7 +582,7 @@ mock.module(path.join(root, 'test/helpers/session-runner.ts'), () => ({ async ru return returnedResult; } })); await import(path.join(root, 'test/skill-e2e-ship-docsync.test.ts')); -expect(callbacks.size).toBe(13); +expect(callbacks.size).toBe(12); const names = ['ship-docsync-failure', 'ship-docsync-missing-marker', 'ship-docsync-missing-asset', 'ship-docsync-launch-failure', 'ship-docsync-timeout-unsettled', 'ship-docsync-late-result', 'ship-docsync-stale-before', 'ship-docsync-stale-after', 'ship-docsync-recovery']; diff --git a/test/shared-libs-fixture.test.ts b/test/shared-libs-fixture.test.ts index a5a5119c6..2e5c15c46 100644 --- a/test/shared-libs-fixture.test.ts +++ b/test/shared-libs-fixture.test.ts @@ -1183,7 +1183,7 @@ describe('shared-code capture attempt accounting', () => { expect(result.tests.map((row: EvalTestEntry) => row.transcript!.filter(event => event.scenario_name).length)) .toEqual([3, 3, 2, 2, 4, 4]); expect(result.total_cost_usd).toBe(0.18); - expect(collectorOutcomeCounts([result])).toEqual({ executed: 3, reused: 0, passed: 3, failed: 0, manual_accepted: 0, attempts: 6 }); + expect(collectorOutcomeCounts([result])).toEqual({ executed: 6, reused: 0, passed: 3, failed: 3, manual_accepted: 0, attempts: 6 }); }); test('missing scenarios in a later attempt cannot inherit an earlier pass', async () => { @@ -1197,7 +1197,7 @@ describe('shared-code capture attempt accounting', () => { })).rejects.toThrow('missing scenarios: second'); const result = await finalized(captures); expect(result.tests[1]).toMatchObject({ attempt: 2, passed: false, exit_reason: 'attempt_incomplete' }); - expect(collectorOutcomeCounts([result])).toEqual({ executed: 1, reused: 0, passed: 0, failed: 1, manual_accepted: 0, attempts: 2 }); + expect(collectorOutcomeCounts([result])).toEqual({ executed: 2, reused: 0, passed: 1, failed: 1, manual_accepted: 0, attempts: 2 }); }); test('setup, verification and cleanup failures survive even when all recorded captures passed', async () => { @@ -1327,7 +1327,7 @@ test('actual-retry', () => captures.runAttempt('actual-retry', ['audit'], 5_000, const result = JSON.parse(fs.readFileSync(path.join(resultDir, file), 'utf8')); expect(result.tests.map((row: EvalTestEntry) => [row.attempt, row.passed, row.exit_reason])) .toEqual([[1, false, 'timeout'], [2, true, 'success']]); - expect(collectorOutcomeCounts([result])).toEqual({ executed: 1, reused: 0, passed: 1, failed: 0, manual_accepted: 0, attempts: 2 }); + expect(collectorOutcomeCounts([result])).toEqual({ executed: 2, reused: 0, passed: 1, failed: 1, manual_accepted: 0, attempts: 2 }); }); test('Bun outer timeouts stay failed after late completion, with and without a retry', () => { @@ -1369,8 +1369,8 @@ test('outer-timeout', () => captures.runAttempt('outer-timeout', ['audit'], 50, .toEqual(mode === 'retry' ? [[1, false], [2, true]] : [[1, false]]); expect(['timeout', 'attempt_incomplete']).toContain(result.tests[0].exit_reason); expect(result.tests[0].error).toContain('Test attempt stopped:'); - expect(collectorOutcomeCounts([result])).toEqual({ executed: 1, reused: 0, manual_accepted: 0, - passed: mode === 'retry' ? 1 : 0, failed: mode === 'retry' ? 0 : 1, attempts: mode === 'retry' ? 2 : 1 }); + expect(collectorOutcomeCounts([result])).toEqual({ executed: mode === 'retry' ? 2 : 1, reused: 0, manual_accepted: 0, + passed: mode === 'retry' ? 1 : 0, failed: 1, attempts: mode === 'retry' ? 2 : 1 }); } }); });