v1.91.7.0 feat: add functional QA and pre-publication docs checks (#2983)

* feat: add surface-aware exploratory QA and ship documentation gates

* test: preserve delegated QA setup authority after main integration

* fix(qa): clarify exploration order and preserve report artifacts

* test(qa): follow the shared setup reference directly

* refactor(ship): make verification and recovery routes explicit

* test(ship): align evidence and review guards with explicit routes

* fix(workflows): clarify ship recovery and functional QA evidence

* fix(workflows): clarify approval recovery and full QA coverage

* refactor(workflows): order review transactions and clarify ship state

* fix(ship): clarify final verification and fail closed at publication

* fix(evals): attribute native atomic documentation writes

* fix(ship): clarify recovery and documentation lifecycle guidance

* fix(test): preserve observed native placeholder styling in CI

* fix(codex): report watchdog timeouts without a process-exit race

* Checkpoint functional QA implementation and workflow validation repairs

* Fix documentation and shared-review fixture contracts

* docs: clarify judge reuse and evaluation supervision

* test: align review evidence and selected case contracts

* test: verify append-only documentation checkpoints and recovery

* fix: qualify QA workflows and CI validation repairs

* fix: launch shared-libs fixture scripts on Windows

* fix: qualify QA deadlines, fixture isolation, and shard cleanup

* fix: preserve qualified QA and cancellation repairs

* fix: enforce functional fixture authority and share strict event decoding

* fix: retain free-test evidence and explain recovery

* fix: reject malformed native evidence after decoder consolidation

* test: use reliable capture for telemetry privacy filters

* test: refresh measured quick coverage and document validation costs

* Fix native fixture receipts and preserve VM validation evidence

* Align negative judge controls with upstream clarity policy

* Fix report-only QA preparation and public evidence handling

* Clarify QA-only preparation and current-report preservation

* Stream Ship quality judgments with an explicit 64k response contract

* Validate compact judge reasoning locally with supported wire schema

* Align functional QA fixture instructions with evidence acceptance

* Bind native browser diagnostics to execution evidence and align review verdicts

* Preserve native diagnostic line boundaries

* Serialize functional QA evidence from native captures

* Keep large QA evidence fixture payload out of Windows argv
This commit is contained in:
Garry Tan authored and GitHub committed 2026-09-29 06:07:35 -07:00
1 parent 65bfb0ce49
commit dcaea52800
333 files changed
+41755 -7357

No files matched your search

+57 -1
View File
@@ -313,6 +313,62 @@ describe('gstack-codex-probe: timeout wrapper + namespace hygiene', () => {
}
});
test('bash-native watchdog reports its timeout while still retiring after TERM', () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-watchdog-race-'));
try {
for (const tool of ['bash', 'sleep']) {
const resolved = spawnSync('bash', ['-c', `command -v ${tool}`], { timeout: 5000 });
expect(resolved.status).toBe(0);
fs.symlinkSync(resolved.stdout.toString().trim(), path.join(dir, tool));
}
const r = runProbe({
snippet: `
kill() {
builtin kill "$@"
local rc=$?
if [ "$1" = -TERM ] && [ "$rc" -eq 0 ]; then sleep 0.2; fi
return "$rc"
}
_gstack_codex_timeout_wrapper 0.1 sleep 30
printf 'rc=%s\\n' "$?"
`,
env: { PATH: dir },
});
expect(r.status).toBe(0);
expect(r.stdout).toBe('rc=124\n');
} finally {
fs.rmSync(dir, { recursive: true, force: true });
}
});
for (const [name, command, expected] of [
['success', 'printf finished', 'finishedrc=0\n'],
['ordinary failure', "bash -c 'exit 7'", 'rc=7\n'],
['independent signal', "bash -c 'kill -TERM $$'", 'rc=143\n'],
]) test(`bash-native watchdog preserves ${name} without waiting for its deadline`, () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-watchdog-early-'));
try {
for (const tool of ['bash', 'sleep']) {
const resolved = spawnSync('bash', ['-c', `command -v ${tool}`], { timeout: 5000 });
expect(resolved.status).toBe(0);
fs.symlinkSync(resolved.stdout.toString().trim(), path.join(dir, tool));
}
const r = runProbe({
snippet: `
trap 'printf caller-term' TERM
output=$(_gstack_codex_timeout_wrapper 10 ${command}; printf 'rc=%s\\n' "$?")
printf '%s\\n' "$output"
trap -p TERM
`,
env: { PATH: dir },
});
expect(r.status).toBe(0);
expect(r.stdout).toBe(`${expected}trap -- 'printf caller-term' SIGTERM\n`);
} finally {
fs.rmSync(dir, { recursive: true, force: true });
}
});
test('sourcing probe does NOT set errexit/trap/IFS in caller shell (namespace hygiene)', () => {
// Capture `set -o` output before and after sourcing. Any drift means the
// probe polluted the caller.
@@ -469,7 +525,7 @@ describe('codex review-mode section Step 2A: PROMPT + --base mutual exclusion gu
describe('codex timeout wrapper: /review + /ship diff passes', () => {
const WRAPPED_SITES = [
'scripts/resolvers/review.ts', // generator (source of truth)
'review/sections/adversarial.md', // review section (Step 5.7 carved out of the skeleton)
'review/sections/adversarial.md', // review section (Step 4.8 carved out of the skeleton)
'ship/sections/adversarial.md', // ship section source
];