v1.91.7.0 feat: add functional QA and pre-publication docs checks (#2983)

* feat: add surface-aware exploratory QA and ship documentation gates

* test: preserve delegated QA setup authority after main integration

* fix(qa): clarify exploration order and preserve report artifacts

* test(qa): follow the shared setup reference directly

* refactor(ship): make verification and recovery routes explicit

* test(ship): align evidence and review guards with explicit routes

* fix(workflows): clarify ship recovery and functional QA evidence

* fix(workflows): clarify approval recovery and full QA coverage

* refactor(workflows): order review transactions and clarify ship state

* fix(ship): clarify final verification and fail closed at publication

* fix(evals): attribute native atomic documentation writes

* fix(ship): clarify recovery and documentation lifecycle guidance

* fix(test): preserve observed native placeholder styling in CI

* fix(codex): report watchdog timeouts without a process-exit race

* Checkpoint functional QA implementation and workflow validation repairs

* Fix documentation and shared-review fixture contracts

* docs: clarify judge reuse and evaluation supervision

* test: align review evidence and selected case contracts

* test: verify append-only documentation checkpoints and recovery

* fix: qualify QA workflows and CI validation repairs

* fix: launch shared-libs fixture scripts on Windows

* fix: qualify QA deadlines, fixture isolation, and shard cleanup

* fix: preserve qualified QA and cancellation repairs

* fix: enforce functional fixture authority and share strict event decoding

* fix: retain free-test evidence and explain recovery

* fix: reject malformed native evidence after decoder consolidation

* test: use reliable capture for telemetry privacy filters

* test: refresh measured quick coverage and document validation costs

* Fix native fixture receipts and preserve VM validation evidence

* Align negative judge controls with upstream clarity policy

* Fix report-only QA preparation and public evidence handling

* Clarify QA-only preparation and current-report preservation

* Stream Ship quality judgments with an explicit 64k response contract

* Validate compact judge reasoning locally with supported wire schema

* Align functional QA fixture instructions with evidence acceptance

* Bind native browser diagnostics to execution evidence and align review verdicts

* Preserve native diagnostic line boundaries

* Serialize functional QA evidence from native captures

* Keep large QA evidence fixture payload out of Windows argv

test/helpers/session-runner.ts

@@ -65,14 +65,15 @@ export const STARTUP_GRACE_MS = 90_000;
  *  Pinned by test/session-runner-startup-grace.test.ts. */
 export const STARTUP_GRACE_CI_FLOOR_MS = 300_000;
 /** Existing pipe-drain allowance; never adds model work time. */
-export const SESSION_DRAIN_GRACE_MS = 5_000;
+export { SESSION_DRAIN_GRACE_MS } from './session-drain-policy';
+import { SESSION_DRAIN_GRACE_MS } from './session-drain-policy';
 
 const BROWSE_ERROR_PATTERNS = [
   /Unknown command: \w+/,
   /Unknown snapshot flag: .+/,
   /ERROR: browse binary not found/,
   /Server failed to start/,
-  /no such file or directory.*browse/i,
+  /no such file or directory.*\bbrowse(?:\.exe)?(?=$|[\s'":),])/i,
 ];
 
 // --- Testable NDJSON parser ---
@@ -247,6 +248,10 @@ export async function runSkillTest(options: {
   startupGraceMs?: number;
   /** Cancel the owned process group when an enclosing attempt expires. */
   signal?: AbortSignal;
+  nativeLifecycle?: {
+    onSpawn(pid: number): void;
+    onSettled(input: { deadline: number; exited: boolean }): Promise<void>;
+  };
 }): Promise<SkillTestResult> {
   const startTime = Date.now();
   options.signal?.throwIfAborted();
@@ -461,7 +466,7 @@ Before source Reads and after each saved checkpoint, use Bash to run exactly \`d
   phaseTimer = setTimeout(() => killRun(true), Math.max(0, startTime + startupGraceMs - Date.now()));
   proc.stdin!.on('error', () => { /* exit handling reports early child failure */ });
   if (signal?.aborted || Date.now() >= deadline) onAbort();
-  else proc.stdin!.end(prompt);
+  else if (!options.nativeLifecycle) proc.stdin!.end(prompt);
   /** Called once by the read loop on the first NDJSON byte. */
   const armWorkPhase = (elapsedMs: number): void => {
     clearTimeout(phaseTimer);
@@ -481,8 +486,11 @@ Before source Reads and after each saved checkpoint, use Bash to run exactly \`d
   const decoder = new TextDecoder();
   let buf = '';
   const projectLine = options.publicStreamDiagnostics ? publicStreamProjection(startTime) : (line: string) => line;
+  let lifecycleFailure: unknown;
 
   try {
+    options.nativeLifecycle?.onSpawn(proc.pid!);
+    if (options.nativeLifecycle && !signal?.aborted && Date.now() < deadline) proc.stdin!.end(prompt);
     try {
       while (true) {
         const { done, value } = await reader.read();
@@ -574,7 +582,36 @@ Before source Reads and after each saved checkpoint, use Bash to run exactly \`d
     }
 
     await Promise.race([Promise.all([procExited, stderrClosed]), forcedDrain]);
+  } catch (error) {
+    lifecycleFailure = error;
+    throw error;
   } finally {
+    if (options.nativeLifecycle) {
+      killProcessGroup(proc, 'SIGKILL');
+      closePipes();
+      armDrain();
+      try {
+        await Promise.race([procExited, forcedDrain]);
+        let hookTimer: ReturnType<typeof setTimeout> | undefined;
+        try {
+          await Promise.race([
+            options.nativeLifecycle.onSettled({ deadline: drainDeadline, exited: exitCode !== undefined && !processError }),
+            new Promise<never>((_, reject) => {
+              hookTimer = setTimeout(() => reject(new Error('native lifecycle settlement deadline exceeded')), Math.max(0, drainDeadline - Date.now()));
+            }),
+          ]);
+        } finally { clearTimeout(hookTimer); }
+      } catch (error) {
+        if (lifecycleFailure) throw new AggregateError([lifecycleFailure, error], 'native lifecycle failed');
+        throw error;
+      } finally {
+        clearTimeout(phaseTimer);
+        clearTimeout(drainTimer);
+        signal?.removeEventListener('abort', onAbort);
+        proc.removeListener('exit', onExit);
+        proc.stderr!.removeListener('data', onStderr);
+      }
+    }
     clearTimeout(phaseTimer);
     clearTimeout(drainTimer);
     signal?.removeEventListener('abort', onAbort);
@@ -605,8 +642,7 @@ Before source Reads and after each saved checkpoint, use Bash to run exactly \`d
   const { transcript, resultLine, toolCalls } = parsed;
   const browseErrors: string[] = [];
 
-  // Scan transcript + stderr for browse errors
-  const allText = transcript.map(e => JSON.stringify(e)).join('\n') + '\n' + stderr;
+  const allText = toolCalls.filter(call => call.tool === 'Bash').map(call => call.output).join('\n') + '\n' + stderr;
   for (const pattern of BROWSE_ERROR_PATTERNS) {
     const match = allText.match(pattern);
     if (match) {