mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-10 10:40:32 +01:00
Keep a numbered review finding's closing paragraph on that finding after a nested list (GST-2174) (#4237)
* Keep a numbered review finding's closing paragraph on that finding after a nested list (GST-2174) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * Keep the nested-list join from lowering a separate finding or a CRITICAL item The join that keeps a numbered native finding's closing paragraph now ends after that first paragraph, skips bold-led margin paragraphs and verdict lines, applies only to the native voice's items, and never lowers an item that names CRITICAL or P0. Each of these let a separate finding's Severity and Blocks: no lower a FIXABLE blocker to Low (GST-2174). Review-Finding: review/specialist-batched#1 reader=testing Review-Finding: review/red-team#2 reader=red-team Review-Finding: review/red-team#3 reader=red-team Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * Describe the numbered-finding nested-list rule and add its changelog entry docs/review-policy.md now says how the collector keeps a native numbered finding's first closing paragraph after a nested list (GST-2174). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
1 parent
a58e6e27c6
commit
dcebc44fa7
4 files changed
+111
-3
No files matched your search
@@ -913,7 +913,11 @@ ones, and the arm lost blockers. `bin/gstack-review-dispatch` closes both ends:
|
||||
never split off as a second record (GST-1031); the line right under the heading that carries those fields, no other
|
||||
label and no file:line joins it at the stronger label (not under a heading that names CRITICAL or P0 itself), the way an unlocated paragraph after a blank line already does. An unnumbered, unlabeled bullet with no file:line
|
||||
under a paragraph finding whose Severity or Blocks line has not come yet is that finding's detail, so the field line after it
|
||||
lands on the finding; a numbered item is its own finding.
|
||||
lands on the finding; a numbered item is its own finding. A native adversarial numbered list item (`1. **FIXABLE. …**`)
|
||||
with no fields of its own keeps, after an unlabeled nested list, its indented lines and the first paragraph after a blank
|
||||
line until its fields come, so that paragraph's `Severity` and `Blocks` bind to the item instead of forming a second record;
|
||||
an item naming CRITICAL or P0 is never lowered, and a list item, heading, lead label, file:line, bold paragraph opener,
|
||||
verdict line or any later paragraph starts the next finding (ALPH-93).
|
||||
A reader's own no-defect closing sentence is no finding at the label it denies (GST-435): a prose line with no
|
||||
list, heading, bold or lead label, no `Severity` or `Blocks` field, no FIXABLE or INVESTIGATE, no file:line or path
|
||||
and no exception clause, with no line above it in its paragraph that runs on (no closing period) or names an
|
||||
|
||||
Reference in new issue
Block a user