mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-04 18:36:54 +02:00
test: one owner per case id, a structural devex 0B setup rule, and correct design/gbrain actors
- plan-design-review-plan-mode was registered by two files; the PTY smoke is now plan-design-review-plan-mode-smoke, and a registry test requires one owner per case in case-sharded files. - plan-devex-finding-floor: the template's 0B narrative-confirmation question is classified as setup structurally instead of timing out a Haiku assessor. - setup-gbrain-remote: the actor accepted 'skip' on the MCP-registration question the test asserts; it now accepts that question and declines others. - design-review-plugin-handoff: the fake engine cited a file absent from the fixture repo and index.html linked a missing styles.css. Captured-question regressions with negative controls; each case passed a focused paid run.
This commit is contained in:
1 parent
8cf87d4729
commit
dfe5e733fb
10 files changed
+152
-21
No files matched your search
@@ -137,6 +137,14 @@ function deterministicPlanFloorSetup(input: PlanFloorReview): PlanFloorAssessmen
|
||||
/\b(?:developer|sdk developer|user)\b/.test(question) &&
|
||||
/\b(?:experiences|journey|narrative)\b/.test(question);
|
||||
|
||||
// plan-devex-review 0B's confirmation contract: the brief asks whether the
|
||||
// narrative matches reality and every option is one of its three answers
|
||||
// (accurate / some wrong / way off). Any remedy option leaves it to the assessor.
|
||||
const isDxNarrativeConfirmation =
|
||||
/\b(?:empathy|narrative)\b/.test(header) &&
|
||||
/\b(?:narrative|journey)\b[^?\n]*\bmatch\b[^?\n]*\?/.test(q.question.split(/\r?\n/)[0]!.toLowerCase()) &&
|
||||
q.options.every(o => /^(?:[a-d][).:]\s*)?(?:(?:this is\s+)?accurate|some\b[^,]*?\b(?:wrong|corrections?)|(?:this is\s+)?way off)\b/i.test(o.label.trim()));
|
||||
|
||||
const isProductTypeSetup =
|
||||
header === 'product type' &&
|
||||
/^is this\b/.test(question) &&
|
||||
@@ -146,7 +154,7 @@ function deterministicPlanFloorSetup(input: PlanFloorReview): PlanFloorAssessmen
|
||||
/^(?:mode|review mode)$/.test(header) &&
|
||||
/\b(?:which|what)\b.*\breview mode\b/.test(question);
|
||||
|
||||
if (!isDxEmpathySetup && !isProductTypeSetup && !isReviewModeSetup) return null;
|
||||
if (!isDxEmpathySetup && !isDxNarrativeConfirmation && !isProductTypeSetup && !isReviewModeSetup) return null;
|
||||
|
||||
return validatePlanFloorAssessment(input, {
|
||||
kind: 'setup',
|
||||
|
||||
Reference in new issue
Block a user