test(helpers): shared skill-census helper with three explicit counts

physicalSkillFiles (symlinked dirs included, root router included), authoredSkills (realpath-deduped, router excluded), registryEntries (what ./setup registers: unique frontmatter names + _gstack-command). One counting authority for the hermetic seeder, context-bill ground truth, and the catalog-budget test — connect-chrome's dir symlink and the root router otherwise produce three subtly different hand-rolled censuses. Ported-wave foundation (C11). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-09-13 00:19:03 +02:00 · 2026-08-12 15:31:46 -07:00
parent d078622b73
commit e78db4e309
2 changed files with 165 additions and 0 deletions
@@ -0,0 +1,69 @@
+/**
+ * Pins the three-count contract of test/helpers/skill-census.ts (C11).
+ *
+ * No hardcoded totals here — the catalog-budget test owns the ratchet.
+ * This file pins the STRUCTURAL relationships that make the three counts
+ * mean different things, using the live repo as the fixture.
+ */
+
+import { describe, expect, it } from 'bun:test';
+import * as fs from 'fs';
+import * as path from 'path';
+import { frontmatterName, skillCensus } from './helpers/skill-census';
+
+const ROOT = path.resolve(new URL(import.meta.url).pathname, '..', '..');
+const census = skillCensus(ROOT);
+
+describe('skillCensus', () => {
+  it('physicalSkillFiles includes the root router and the symlinked dir', () => {
+    expect(census.physicalSkillFiles).toContain('SKILL.md');
+    expect(census.physicalSkillFiles).toContain('connect-chrome/SKILL.md');
+    expect(census.physicalSkillFiles).toContain('open-gstack-browser/SKILL.md');
+  });
+
+  it('authoredSkills dedupes the connect-chrome symlink and excludes the root router', () => {
+    expect(census.authoredSkills).toContain('open-gstack-browser');
+    expect(census.authoredSkills).not.toContain('connect-chrome');
+    // Root router is not an authored skill; its dir entry would be '' anyway.
+    for (const name of census.authoredSkills) expect(name.length).toBeGreaterThan(0);
+  });
+
+  it('registryEntries carries the root alias and collapses shared frontmatter names', () => {
+    expect(census.registryEntries).toContain('_gstack-command');
+    expect(
+      census.registryEntries.filter((n) => n === 'open-gstack-browser'),
+    ).toHaveLength(1);
+  });
+
+  it('count relationships hold: physical = authored + root + symlink dups', () => {
+    const symlinkDups = census.physicalSkillFiles.length - 1 - census.authoredSkills.length;
+    expect(symlinkDups).toBeGreaterThanOrEqual(1); // connect-chrome today
+    // Registry = unique frontmatter names + root alias. It can only collapse
+    // entries relative to physical, never invent them.
+    expect(census.registryEntries.length).toBeLessThanOrEqual(census.physicalSkillFiles.length);
+    expect(census.registryEntries.length).toBeGreaterThan(census.authoredSkills.length - 1);
+  });
+
+  it('frontmatterName mirrors setup: first ^name: line, whitespace stripped', () => {
+    const qa = frontmatterName(path.join(ROOT, 'qa', 'SKILL.md'));
+    expect(qa).toBe('qa');
+    const alias = frontmatterName(path.join(ROOT, 'connect-chrome', 'SKILL.md'));
+    expect(alias).toBe('open-gstack-browser');
+    expect(frontmatterName(path.join(ROOT, 'no-such-dir', 'SKILL.md'))).toBe('');
+  });
+
+  it('every registry entry a host would see resolves back to a physical SKILL.md', () => {
+    const names = new Set(
+      census.physicalSkillFiles
+        .filter((p) => p !== 'SKILL.md')
+        .map((p) => frontmatterName(path.join(ROOT, p)) || path.dirname(p)),
+    );
+    for (const entry of census.registryEntries) {
+      if (entry === '_gstack-command') {
+        expect(fs.existsSync(path.join(ROOT, 'SKILL.md'))).toBe(true);
+      } else {
+        expect(names.has(entry)).toBe(true);
+      }
+    }
+  });
+});