CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-08-07 23:08:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: replace source <(gstack-slug) with eval for bash compatibility

Browse Source 
Under bash with set -euo pipefail, source <(cmd) process substitution
doesn't reliably set variables in the caller's scope. The variables
stay empty and -u (nounset) crashes the script. eval "$(cmd)" works
correctly in both bash and zsh.

Fixes: gstack-review-read, gstack-review-log, gstack-slug comment,
gen-skill-docs.ts resolver functions, and regression tests.
This commit is contained in:
Garry Tan
2026-03-22 20:57:49 -07:00
parent 4cd4d11cb0
commit e877d3d870
28 changed files with 72 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files
design-review/SKILL.md
+2 -2
View File
@@ -774,7 +774,7 @@ Compare screenshots and observations across pages for:
**Project-scoped:**
```bash
source <(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null) && mkdir -p ~/.gstack/projects/$SLUG
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)" && mkdir -p ~/.gstack/projects/$SLUG
```
Write to: `~/.gstack/projects/{slug}/{user}-{branch}-design-audit-{datetime}.md`
@@ -1142,7 +1142,7 @@ Write the report to both local and project-scoped locations:
**Project-scoped:**
```bash
source <(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null) && mkdir -p ~/.gstack/projects/$SLUG
eval "$(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)" && mkdir -p ~/.gstack/projects/$SLUG
```
Write to `~/.gstack/projects/{slug}/{user}-{branch}-design-audit-{datetime}.md`
design-review/SKILL.md.tmpl
+1 -1
View File
@@ -224,7 +224,7 @@ Write the report to both local and project-scoped locations:
**Project-scoped:**
```bash
source <(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null) && mkdir -p ~/.gstack/projects/$SLUG
{{SLUG_SETUP}}
```
Write to `~/.gstack/projects/{slug}/{user}-{branch}-design-audit-{datetime}.md`