fix(proactive): off gates the office-hours handoff; the preamble and router scope the setting to unasked suggestions

The office-hours next-review handoff gated on the legacy false only, so an off user was still asked to launch /plan-eng-review. The per-skill preamble now says the setting governs unasked suggestions and this skill's own steps still run (a handoff, a review gate, a dispatched /document-release is not a suggestion), at exactly the previous length, so the 89 size pins return to main's values; the router says the same in full. Found by /ship's specialist and red-team review.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
garrytanandcapy-ai[bot] committed 2026-10-26 01:11:52 +00:00
1 parent cf2d66ca0d
commit ecb3940d47
60 files changed
+246 -216

No files matched your search

@@ -8,7 +8,7 @@ import type { TemplateContext } from '../types';
* the fence prose scopes and the model follows.
*/
export function generateUpgradeCheck(ctx: TemplateContext): string {
return `If \`PROACTIVE\` is \`false\` or \`off\`, suggest no skill, even by asking; if \`core\` (default), only /office-hours, /review, /qa and /ship; \`all\` or \`true\`: any.
return `If \`PROACTIVE\` is \`false\`/\`off\`: suggest no skill unasked, nor ask to. \`core\`: only /office-hours, /review, /qa, /ship. \`all\`/\`true\`: any. This skill's steps still run.
If \`SKILL_PREFIX\` is \`true\`, suggest \`/gstack-*\` names; disk paths stay \`${ctx.paths.skillRoot}/[skill-name]/SKILL.md\`.`;
If \`SKILL_PREFIX\` is \`true\` use \`/gstack-*\` names; paths stay \`${ctx.paths.skillRoot}/[skill-name]/SKILL.md\`.`;
}